[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[ https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184129#comment-14184129 ] Xuefu Zhang commented on HIVE-6165: --- +1 > Unify HivePreparedStatement from jdbc:hive and jdbc:hive2 > - > > Key: HIVE-6165 > URL: https://issues.apache.org/jira/browse/HIVE-6165 > Project: Hive > Issue Type: Bug > Components: HiveServer2, JDBC >Reporter: Helmut Zechmann >Priority: Minor > Attachments: HIVE-6165.1.patch.txt, HIVE-6165.1.patch.txt, > HIVE-6165.2.patch, HIVE-6165.2.patch.txt, HIVE-6165.2.patch.txt > > > org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc > driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2 > jdbc drivers contain lots of duplicate code. > Especially hive-HivePreparedStatement supports "setObject", while the hive2 > version does not. > Share more code between the two to avoid duplicate work and to make sure that > both support the broadest possible feature set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[
https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184035#comment-14184035
]
Hive QA commented on HIVE-6165:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12676946/HIVE-6165.2.patch.txt
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 6578 tests executed
*Failed tests:*
{noformat}
org.apache.hive.minikdc.TestJdbcWithMiniKdc.testNegativeTokenAuth
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1450/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1450/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1450/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12676946 - PreCommit-HIVE-TRUNK-Build
> Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
> -
>
> Key: HIVE-6165
> URL: https://issues.apache.org/jira/browse/HIVE-6165
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, JDBC
>Reporter: Helmut Zechmann
>Priority: Minor
> Attachments: HIVE-6165.1.patch.txt, HIVE-6165.1.patch.txt,
> HIVE-6165.2.patch, HIVE-6165.2.patch.txt, HIVE-6165.2.patch.txt
>
>
> org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc
> driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2
> jdbc drivers contain lots of duplicate code.
> Especially hive-HivePreparedStatement supports "setObject", while the hive2
> version does not.
> Share more code between the two to avoid duplicate work and to make sure that
> both support the broadest possible feature set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[ https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183231#comment-14183231 ] Xuefu Zhang commented on HIVE-6165: --- Yeah. I knew. However, the test failures seems unrelated, but I'm not quite sure. Thus, I liked to have another run to confirm. Thanks for pointing it out thought. > Unify HivePreparedStatement from jdbc:hive and jdbc:hive2 > - > > Key: HIVE-6165 > URL: https://issues.apache.org/jira/browse/HIVE-6165 > Project: Hive > Issue Type: Bug > Components: HiveServer2, JDBC >Reporter: Helmut Zechmann >Priority: Minor > Attachments: HIVE-6165.1.patch.txt, HIVE-6165.1.patch.txt, > HIVE-6165.2.patch, HIVE-6165.2.patch.txt, HIVE-6165.2.patch.txt > > > org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc > driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2 > jdbc drivers contain lots of duplicate code. > Especially hive-HivePreparedStatement supports "setObject", while the hive2 > version does not. > Share more code between the two to avoid duplicate work and to make sure that > both support the broadest possible feature set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[ https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183213#comment-14183213 ] Gunther Hagleitner commented on HIVE-6165: -- [~xuefuz] - i've already done that. the last Hive QA entry is for .2 patch (i stripped the .txt by mistake). > Unify HivePreparedStatement from jdbc:hive and jdbc:hive2 > - > > Key: HIVE-6165 > URL: https://issues.apache.org/jira/browse/HIVE-6165 > Project: Hive > Issue Type: Bug > Components: HiveServer2, JDBC >Reporter: Helmut Zechmann >Priority: Minor > Attachments: HIVE-6165.1.patch.txt, HIVE-6165.1.patch.txt, > HIVE-6165.2.patch, HIVE-6165.2.patch.txt, HIVE-6165.2.patch.txt > > > org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc > driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2 > jdbc drivers contain lots of duplicate code. > Especially hive-HivePreparedStatement supports "setObject", while the hive2 > version does not. > Share more code between the two to avoid duplicate work and to make sure that > both support the broadest possible feature set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[
https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182648#comment-14182648
]
Hive QA commented on HIVE-6165:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12676822/HIVE-6165.2.patch
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 6563 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cbo_correctness
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_cbo_correctness
org.apache.hive.hcatalog.streaming.TestStreaming.testInterleavedTransactionBatchCommits
org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchCommit_Json
org.apache.hive.minikdc.TestJdbcWithMiniKdc.testNegativeTokenAuth
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1439/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1439/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1439/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12676822 - PreCommit-HIVE-TRUNK-Build
> Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
> -
>
> Key: HIVE-6165
> URL: https://issues.apache.org/jira/browse/HIVE-6165
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, JDBC
>Reporter: Helmut Zechmann
>Priority: Minor
> Attachments: HIVE-6165.1.patch.txt, HIVE-6165.1.patch.txt,
> HIVE-6165.2.patch, HIVE-6165.2.patch.txt
>
>
> org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc
> driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2
> jdbc drivers contain lots of duplicate code.
> Especially hive-HivePreparedStatement supports "setObject", while the hive2
> version does not.
> Share more code between the two to avoid duplicate work and to make sure that
> both support the broadest possible feature set.
> CLEAR LIBRARY CACHE
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[
https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182334#comment-14182334
]
Hive QA commented on HIVE-6165:
---
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12676735/HIVE-6165.2.patch.txt
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1425/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1425/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1425/
Messages:
{noformat}
This message was trimmed, see log for full details
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:68:4:
Decision can match input such as "LPAREN KW_CASE KW_IF" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:68:4:
Decision can match input such as "LPAREN LPAREN KW_IF" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:115:5:
Decision can match input such as "KW_CLUSTER KW_BY LPAREN" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:127:5:
Decision can match input such as "KW_PARTITION KW_BY LPAREN" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:138:5:
Decision can match input such as "KW_DISTRIBUTE KW_BY LPAREN" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:149:5:
Decision can match input such as "KW_SORT KW_BY LPAREN" using multiple
alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:166:7:
Decision can match input such as "STAR" using multiple alternatives: 1, 2
As a result, alternative(s) 2 were disabled for that input
warning(200): IdentifiersParser.g:179:5:
Decision can match input such as "KW_STRUCT" using multiple alternatives: 4, 6
As a result, alternative(s) 6 were disabled for that input
warning(200): IdentifiersParser.g:179:5:
Decision can match input such as "KW_ARRAY" using multiple alternatives: 2, 6
As a result, alternative(s) 6 were disabled for that input
warning(200): IdentifiersParser.g:179:5:
Decision can match input such as "KW_UNIONTYPE" using multiple alternatives: 5,
6
As a result, alternative(s) 6 were disabled for that input
warning(200): IdentifiersParser.g:261:5:
Decision can match input such as "KW_NULL" using multiple alternatives: 1, 8
As a result, alternative(s) 8 were disabled for that input
warning(200): IdentifiersParser.g:261:5:
Decision can match input such as "KW_FALSE" using multiple alternatives: 3, 8
As a result, alternative(s) 8 were disabled for that input
warning(200): IdentifiersParser.g:261:5:
Decision can match input such as "KW_TRUE" using multiple alternatives: 3, 8
As a result, alternative(s) 8 were disabled for that input
warning(200): IdentifiersParser.g:261:5:
Decision can match input such as "KW_DATE StringLiteral" using multiple
alternatives: 2, 3
As a result, alternative(s) 3 were disabled for that input
warning(200): IdentifiersParser.g:393:5:
Decision can match input such as "{KW_LIKE, KW_REGEXP, KW_RLIKE} KW_CLUSTER
KW_BY" using multiple alternatives: 2, 9
As a result, alternative(s) 9 were disabled for that input
warning(200): IdentifiersParser.g:393:5:
Decision can match input such as "{KW_LIKE, KW_REGEXP, KW_RLIKE} KW_UNION
KW_ALL" using multiple alternatives: 2, 9
As a result, alternative(s) 9 were disabled for that input
warning(200): IdentifiersParser.g:393:5:
Decision can match input such as "{KW_LIKE, KW_REGEXP, KW_RLIKE} KW_SORT KW_BY"
using multiple alternatives: 2, 9
As a result, alternative(s) 9 were disabled for that input
warning(200): IdentifiersParser.g:393:5:
Decision can match input such as "{KW_LIKE, KW_REGEXP, KW_RLIKE} KW_INSERT
KW_INTO" using multiple alternatives: 2, 9
As a result, alternative(s) 9 were disabled for that input
warning(200): IdentifiersParser.g:393:5:
Decision can match input such as "{KW_LIKE, KW_REGEXP, KW_RLIKE} KW_LATERAL
KW_VIEW" using multiple alternatives: 2, 9
As a result, alternative(s) 9 were disabled for that input
warning(200): IdentifiersParser.g:393:5:
Decision can match input such as "KW_BETWEEN KW_MAP LPAREN" using multiple
alternatives: 8, 9
As a result, alternative(s) 9 were disabled for that input
warning(200): IdentifiersParser.g:393:5:
Decision can match input such as "{KW_LIKE, KW_REGEXP, KW_RLIKE} KW_DISTRIBUTE
KW_BY" using multiple alternatives: 2, 9
As a res
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[ https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182002#comment-14182002 ] Xuefu Zhang commented on HIVE-6165: --- Rebased the patch with latest trunk. > Unify HivePreparedStatement from jdbc:hive and jdbc:hive2 > - > > Key: HIVE-6165 > URL: https://issues.apache.org/jira/browse/HIVE-6165 > Project: Hive > Issue Type: Bug > Components: HiveServer2, JDBC >Reporter: Helmut Zechmann >Priority: Minor > Attachments: HIVE-6165.1.patch.txt, HIVE-6165.1.patch.txt, > HIVE-6165.2.patch.txt > > > org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc > driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2 > jdbc drivers contain lots of duplicate code. > Especially hive-HivePreparedStatement supports "setObject", while the hive2 > version does not. > Share more code between the two to avoid duplicate work and to make sure that > both support the broadest possible feature set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[ https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14181017#comment-14181017 ] Xuefu Zhang commented on HIVE-6165: --- [~lethum], could you please rebase the patch? > Unify HivePreparedStatement from jdbc:hive and jdbc:hive2 > - > > Key: HIVE-6165 > URL: https://issues.apache.org/jira/browse/HIVE-6165 > Project: Hive > Issue Type: Bug > Components: HiveServer2, JDBC >Reporter: Helmut Zechmann >Priority: Minor > Attachments: HIVE-6165.1.patch.txt, HIVE-6165.1.patch.txt > > > org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc > driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2 > jdbc drivers contain lots of duplicate code. > Especially hive-HivePreparedStatement supports "setObject", while the hive2 > version does not. > Share more code between the two to avoid duplicate work and to make sure that > both support the broadest possible feature set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[
https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179300#comment-14179300
]
Hive QA commented on HIVE-6165:
---
{color:red}Overall{color}: -1 no tests executed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12676157/HIVE-6165.1.patch.txt
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1378/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/1378/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-1378/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ [[ -n /usr/java/jdk1.7.0_45-cloudera ]]
+ export JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera
+ JAVA_HOME=/usr/java/jdk1.7.0_45-cloudera
+ export
PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+
PATH=/usr/java/jdk1.7.0_45-cloudera/bin/:/usr/local/apache-maven-3.0.5/bin:/usr/java/jdk1.7.0_45-cloudera/bin:/usr/local/apache-ant-1.9.1/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/hiveptest/bin
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost
-Dhttp.proxyPort=3128'
+ cd /data/hive-ptest/working/
+ tee /data/hive-ptest/logs/PreCommit-HIVE-TRUNK-Build-1378/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ svn = \s\v\n ]]
+ [[ -n '' ]]
+ [[ -d apache-svn-trunk-source ]]
+ [[ ! -d apache-svn-trunk-source/.svn ]]
+ [[ ! -d apache-svn-trunk-source ]]
+ cd apache-svn-trunk-source
+ svn revert -R .
Reverted 'common/src/java/org/apache/hadoop/hive/conf/HiveConf.java'
Reverted
'ql/src/test/results/clientnegative/authorization_disallow_transform.q.out'
Reverted
'ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/TestSQLStdHiveAccessControllerHS2.java'
Reverted 'ql/src/test/queries/clientnegative/authorization_disallow_transform.q'
Reverted
'ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAccessController.java'
++ awk '{print $2}'
++ egrep -v '^X|^Performing status on external'
++ svn status --no-ignore
+ rm -rf target datanucleus.log ant/target shims/target shims/0.20/target
shims/0.20S/target shims/0.23/target shims/aggregator/target
shims/common/target shims/common-secure/target packaging/target
hbase-handler/target testutils/target jdbc/target metastore/target
itests/target itests/hcatalog-unit/target itests/test-serde/target
itests/qtest/target itests/hive-unit-hadoop2/target itests/hive-minikdc/target
itests/hive-unit/target itests/custom-serde/target itests/util/target
hcatalog/target hcatalog/core/target hcatalog/streaming/target
hcatalog/server-extensions/target hcatalog/hcatalog-pig-adapter/target
hcatalog/webhcat/svr/dependency-reduced-pom.xml hcatalog/webhcat/svr/target
hcatalog/webhcat/java-client/target accumulo-handler/target hwi/target
common/target common/src/gen
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java.orig service/target
contrib/target serde/target beeline/target odbc/target cli/target
ql/dependency-reduced-pom.xml ql/target
ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/TestSQLStdHiveAccessControllerHS2.java
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/SettableConfigUpdater.java
+ svn update
Fetching external item into 'hcatalog/src/test/e2e/harness'
External at revision 1633483.
At revision 1633483.
+ patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hive-ptest/working/scratch/build.patch
+ [[ -f /data/hive-ptest/working/scratch/build.patch ]]
+ chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh
+ /data/hive-ptest/working/scratch/smart-apply-patch.sh
/data/hive-ptest/working/scratch/build.patch
The patch does not appear to apply with p0, p1, or p2
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12676157 - PreCommit-HIVE-TRUNK-Build
> Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
> -
>
> Key: HIVE-6165
> URL: https://issues.apache.org/jira/browse/HIVE-6165
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, JDBC
>Reporter: Helmut Zechmann
>
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[
https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068244#comment-14068244
]
Hive QA commented on HIVE-6165:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12656810/HIVE-6165.1.patch.txt
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5734 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_ql_rewrite_gbtoidx
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_fail_8
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/868/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/868/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-868/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12656810
> Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
> -
>
> Key: HIVE-6165
> URL: https://issues.apache.org/jira/browse/HIVE-6165
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2, JDBC
>Reporter: Helmut Zechmann
>Priority: Minor
> Attachments: HIVE-6165.1.patch.txt
>
>
> org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc
> driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2
> jdbc drivers contain lots of duplicate code.
> Especially hive-HivePreparedStatement supports "setObject", while the hive2
> version does not.
> Share more code between the two to avoid duplicate work and to make sure that
> both support the broadest possible feature set.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[ https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866831#comment-13866831 ] Xuefu Zhang commented on HIVE-6165: --- I think "copying" is fine. > Unify HivePreparedStatement from jdbc:hive and jdbc:hive2 > - > > Key: HIVE-6165 > URL: https://issues.apache.org/jira/browse/HIVE-6165 > Project: Hive > Issue Type: Bug > Components: HiveServer2, JDBC >Affects Versions: 0.12.0 >Reporter: Helmut Zechmann >Priority: Minor > > org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc > driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2 > jdbc drivers contain lots of duplicate code. > Especially hive-HivePreparedStatement supports "setObject", while the hive2 > version does not. > Share more code between the two to avoid duplicate work and to make sure that > both support the broadest possible feature set. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[ https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866652#comment-13866652 ] Helmut Zechmann commented on HIVE-6165: --- That makes sense. Maybe the functionality implemented in the old JDBC driver but missing in JDBC driver 2 (setObject and maybe others) can be ported by simply copying the code. > Unify HivePreparedStatement from jdbc:hive and jdbc:hive2 > - > > Key: HIVE-6165 > URL: https://issues.apache.org/jira/browse/HIVE-6165 > Project: Hive > Issue Type: Bug > Components: HiveServer2, JDBC >Affects Versions: 0.12.0 >Reporter: Helmut Zechmann >Priority: Minor > > org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc > driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2 > jdbc drivers contain lots of duplicate code. > Especially hive-HivePreparedStatement supports "setObject", while the hive2 > version does not. > Share more code between the two to avoid duplicate work and to make sure that > both support the broadest possible feature set. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6165) Unify HivePreparedStatement from jdbc:hive and jdbc:hive2
[ https://issues.apache.org/jira/browse/HIVE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865652#comment-13865652 ] Xuefu Zhang commented on HIVE-6165: --- My understanding is that the old JDBC dirver is deprecated or close to be deprecated, and we probably don't want to make any changes unless absolutely necessary. Thus, I think the duplication is acceptable, and we are only moving JDBC driver 2 forward. > Unify HivePreparedStatement from jdbc:hive and jdbc:hive2 > - > > Key: HIVE-6165 > URL: https://issues.apache.org/jira/browse/HIVE-6165 > Project: Hive > Issue Type: Bug > Components: HiveServer2, JDBC >Affects Versions: 0.12.0 >Reporter: Helmut Zechmann >Priority: Minor > > org.apache.hadoop.hive.jdbc.HivePreparedStatement.class from the hive jdbc > driver and org.apache.hive.jdbc.HivePreparedStatement.class from the hive2 > jdbc drivers contain lots of duplicate code. > Especially hive-HivePreparedStatement supports "setObject", while the hive2 > version does not. > Share more code between the two to avoid duplicate work and to make sure that > both support the broadest possible feature set. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
