[jira] [Commented] (HIVE-6481) Add .reviewboardrc file
[ https://issues.apache.org/jira/browse/HIVE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925300#comment-13925300 ] Lefty Leverenz commented on HIVE-6481: -- This could be documented in the wiki here: * [How To Contribute: Review Process |https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-ReviewProcess] (I'm a newbie on the review board, so won't volunteer.) Add .reviewboardrc file --- Key: HIVE-6481 URL: https://issues.apache.org/jira/browse/HIVE-6481 Project: Hive Issue Type: Improvement Components: Build Infrastructure Reporter: Carl Steinbach Assignee: Carl Steinbach Fix For: 0.13.0 Attachments: HIVE-6481.1.patch, HIVE-6481.2.patch We should add a .reviewboardrc file to trunk in order to streamline the review process. Used in conjunction with RBTools this file makes posting a review request as simple as executing the following command: % rbt post -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6481) Add .reviewboardrc file
[ https://issues.apache.org/jira/browse/HIVE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13925358#comment-13925358 ] Carl Steinbach commented on HIVE-6481: -- I updated the wiki some instructions for using rbt. Add .reviewboardrc file --- Key: HIVE-6481 URL: https://issues.apache.org/jira/browse/HIVE-6481 Project: Hive Issue Type: Improvement Components: Build Infrastructure Reporter: Carl Steinbach Assignee: Carl Steinbach Fix For: 0.13.0 Attachments: HIVE-6481.1.patch, HIVE-6481.2.patch We should add a .reviewboardrc file to trunk in order to streamline the review process. Used in conjunction with RBTools this file makes posting a review request as simple as executing the following command: % rbt post -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6481) Add .reviewboardrc file
[
https://issues.apache.org/jira/browse/HIVE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13913595#comment-13913595
]
Hive QA commented on HIVE-6481:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12630736/HIVE-6481.2.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5180 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketmapjoin6
{noformat}
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1493/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1493/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12630736
Add .reviewboardrc file
---
Key: HIVE-6481
URL: https://issues.apache.org/jira/browse/HIVE-6481
Project: Hive
Issue Type: Improvement
Components: Build Infrastructure
Reporter: Carl Steinbach
Assignee: Carl Steinbach
Attachments: HIVE-6481.1.patch, HIVE-6481.2.patch
We should add a .reviewboardrc file to trunk in order to streamline the
review process.
Used in conjunction with RBTools this file makes posting a review request as
simple as executing the following command:
% rbt post
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HIVE-6481) Add .reviewboardrc file
[ https://issues.apache.org/jira/browse/HIVE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13913618#comment-13913618 ] Xuefu Zhang commented on HIVE-6481: --- +1 I think it's good to document the brief usage somewhere on Hive wiki. For instance, I wasn't aware that I had to make a local commit in order to post the diff for review. Also, after rbt post command, we still need to access the web UI to publish the review. Add .reviewboardrc file --- Key: HIVE-6481 URL: https://issues.apache.org/jira/browse/HIVE-6481 Project: Hive Issue Type: Improvement Components: Build Infrastructure Reporter: Carl Steinbach Assignee: Carl Steinbach Attachments: HIVE-6481.1.patch, HIVE-6481.2.patch We should add a .reviewboardrc file to trunk in order to streamline the review process. Used in conjunction with RBTools this file makes posting a review request as simple as executing the following command: % rbt post -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HIVE-6481) Add .reviewboardrc file
[
https://issues.apache.org/jira/browse/HIVE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13910035#comment-13910035
]
Hive QA commented on HIVE-6481:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12630388/HIVE-6481.1.patch
{color:green}SUCCESS:{color} +1 5176 tests passed
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1464/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1464/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12630388
Add .reviewboardrc file
---
Key: HIVE-6481
URL: https://issues.apache.org/jira/browse/HIVE-6481
Project: Hive
Issue Type: Improvement
Components: Build Infrastructure
Reporter: Carl Steinbach
Assignee: Carl Steinbach
Attachments: HIVE-6481.1.patch
We should add a .reviewboardrc file to trunk in order to streamline the
review process.
Used in conjunction with RBTools this file makes posting a review request as
simple as executing the following command:
% rbt post
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
