[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14051220#comment-14051220 ] Lefty Leverenz commented on HIVE-6643: -- *hive.exec.check.crossproducts* is documented in the wiki here: * [Configuration Properties -- hive.exec.check.crossproducts | https://cwiki.apache.org/confluence/display/Hive/Configuration+Properties#ConfigurationProperties-hive.exec.check.crossproducts] I added a comment to HIVE-6586 so it won't get lost in the shuffle when HIVE-6037 changes HiveConf.java. Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.13.0 Attachments: HIVE-6643.1.patch, HIVE-6643.2.patch, HIVE-6643.3.patch, HIVE-6643.4.patch, HIVE-6643.5.patch, HIVE-6643.6.patch, HIVE-6643.7.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954740#comment-13954740 ] Harish Butani commented on HIVE-6643: - Thanks for updating the wiki. Added the Release Note. Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.13.0 Attachments: HIVE-6643.1.patch, HIVE-6643.2.patch, HIVE-6643.3.patch, HIVE-6643.4.patch, HIVE-6643.5.patch, HIVE-6643.6.patch, HIVE-6643.7.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951715#comment-13951715 ] Lefty Leverenz commented on HIVE-6643: -- This adds *hive.exec.check.crossproducts* to HiveConf.java and hive-default.xml.template, so I'll add it to the wiki and include it in HIVE-6586 so the description can be put in the new HiveConf.java after HIVE-6037 gets committed. Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.13.0 Attachments: HIVE-6643.1.patch, HIVE-6643.2.patch, HIVE-6643.3.patch, HIVE-6643.4.patch, HIVE-6643.5.patch, HIVE-6643.6.patch, HIVE-6643.7.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951716#comment-13951716 ] Lefty Leverenz commented on HIVE-6643: -- A release note for *hive.exec.check.crossproducts* would also be good. Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.13.0 Attachments: HIVE-6643.1.patch, HIVE-6643.2.patch, HIVE-6643.3.patch, HIVE-6643.4.patch, HIVE-6643.5.patch, HIVE-6643.6.patch, HIVE-6643.7.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950289#comment-13950289 ] Harish Butani commented on HIVE-6643: - fix more .q.out files Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.13.0 Attachments: HIVE-6643.1.patch, HIVE-6643.2.patch, HIVE-6643.3.patch, HIVE-6643.4.patch, HIVE-6643.5.patch, HIVE-6643.6.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948288#comment-13948288 ] Alan Gates commented on HIVE-6643: -- I see the following errors when I run the tests: 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join0 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join23 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join_filters 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join_nulls 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_12 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_view 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_cross_join 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input23 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join0 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join23 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_alt_syntax 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_cond_pushdown_1 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_cond_pushdown_3 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_cond_pushdown_unqual1 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_cond_pushdown_unqual3 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_filters 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_nulls 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_no_hooks 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_nonblock_op_deduplicate 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ppd_repeated_alias 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_print_header 2014-03-26 17:33:15 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample8 Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.13.0 Attachments: HIVE-6643.1.patch, HIVE-6643.2.patch, HIVE-6643.3.patch, HIVE-6643.4.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948437#comment-13948437 ] Harish Butani commented on HIVE-6643: - fix .q.out diffs Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.13.0 Attachments: HIVE-6643.1.patch, HIVE-6643.2.patch, HIVE-6643.3.patch, HIVE-6643.4.patch, HIVE-6643.5.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948872#comment-13948872 ] Alan Gates commented on HIVE-6643: -- I still see the following failures when running the tests on the latest patch: 2014-03-27 01:20:45 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input23 2014-03-27 01:20:45 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join0 2014-03-27 01:20:45 WARN PTest:205 - org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join23 Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Fix For: 0.13.0 Attachments: HIVE-6643.1.patch, HIVE-6643.2.patch, HIVE-6643.3.patch, HIVE-6643.4.patch, HIVE-6643.5.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13938542#comment-13938542 ] Hive QA commented on HIVE-6643: --- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12635022/HIVE-6643.2.patch Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1864/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1864/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n '' ]] + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'M2_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + M2_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-Build-1864/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ svn = \s\v\n ]] + [[ -n '' ]] + [[ -d apache-svn-trunk-source ]] + [[ ! -d apache-svn-trunk-source/.svn ]] + [[ ! -d apache-svn-trunk-source ]] + cd apache-svn-trunk-source + svn revert -R . Reverted 'metastore/scripts/upgrade/derby/hive-schema-0.13.0.derby.sql' Reverted 'metastore/scripts/upgrade/derby/hive-schema-0.14.0.derby.sql' Reverted 'metastore/scripts/upgrade/mysql/hive-schema-0.13.0.mysql.sql' Reverted 'metastore/scripts/upgrade/mysql/hive-schema-0.14.0.mysql.sql' Reverted 'metastore/scripts/upgrade/oracle/hive-schema-0.13.0.oracle.sql' Reverted 'metastore/scripts/upgrade/oracle/hive-schema-0.14.0.oracle.sql' Reverted 'metastore/scripts/upgrade/postgres/hive-schema-0.14.0.postgres.sql' Reverted 'metastore/scripts/upgrade/postgres/hive-schema-0.13.0.postgres.sql' ++ awk '{print $2}' ++ egrep -v '^X|^Performing status on external' ++ svn status --no-ignore + rm -rf target datanucleus.log ant/target shims/target shims/0.20/target shims/0.20S/target shims/0.23/target shims/aggregator/target shims/common/target shims/common-secure/target packaging/target hbase-handler/target testutils/target jdbc/target metastore/target itests/target itests/hcatalog-unit/target itests/test-serde/target itests/qtest/target itests/hive-unit/target itests/custom-serde/target itests/util/target hcatalog/target hcatalog/storage-handlers/hbase/target hcatalog/server-extensions/target hcatalog/core/target hcatalog/webhcat/svr/target hcatalog/webhcat/java-client/target hcatalog/hcatalog-pig-adapter/target hwi/target common/target common/src/gen contrib/target service/target serde/target beeline/target odbc/target cli/target ql/dependency-reduced-pom.xml ql/target + svn update Uitests/qtest/pom.xml Ucommon/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java Ucommon/src/java/org/apache/hadoop/hive/conf/HiveConf.java Ucommon/src/java/org/apache/hadoop/hive/common/type/Decimal128.java Uql/src/test/results/clientpositive/vector_decimal_aggregate.q.out Aql/src/test/results/clientpositive/tez/orc_analyze.q.out Aql/src/test/results/clientpositive/orc_analyze.q.out Aql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPrintf.java Aql/src/test/queries/clientpositive/orc_analyze.q Aql/src/java/org/apache/hadoop/hive/ql/plan/StatsNoJobWork.java Uql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java Uql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMRTableScan1.java Aql/src/java/org/apache/hadoop/hive/ql/exec/StatsNoJobTask.java Uql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/MathExpr.java U ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorUDAFSumDecimal.java Uql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java Aql/src/java/org/apache/hadoop/hive/ql/io/StatsProvidingRecordReader.java Uql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java Uql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java Uql/src/java/org/apache/hadoop/hive/ql/parse/ProcessAnalyzeTable.java Uql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java Uql/src/gen/vectorization/UDAFTemplates/VectorUDAFVarDecimal.txt Uconf/hive-default.xml.template Fetching external item into 'hcatalog/src/test/e2e/harness' Updated external to revision 1578659. Updated to revision 1578659. + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13936068#comment-13936068 ] Hive QA commented on HIVE-6643: --- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12634302/HIVE-6643.1.patch Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1800/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1800/console Messages: {noformat} This message was trimmed, see log for full details [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /data/hive-ptest/working/apache-svn-trunk-source/hwi/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-hwi --- [INFO] Executing tasks main: [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/hwi/target/tmp [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/hwi/target/warehouse [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/hwi/target/tmp/conf [copy] Copying 5 files to /data/hive-ptest/working/apache-svn-trunk-source/hwi/target/tmp/conf [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ hive-hwi --- [INFO] Compiling 2 source files to /data/hive-ptest/working/apache-svn-trunk-source/hwi/target/test-classes [INFO] [INFO] --- maven-surefire-plugin:2.16:test (default-test) @ hive-hwi --- [INFO] Tests are skipped. [INFO] [INFO] --- maven-jar-plugin:2.2:jar (default-jar) @ hive-hwi --- [INFO] Building jar: /data/hive-ptest/working/apache-svn-trunk-source/hwi/target/hive-hwi-0.14.0-SNAPSHOT.jar [INFO] [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ hive-hwi --- [INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-hwi --- [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/hwi/target/hive-hwi-0.14.0-SNAPSHOT.jar to /data/hive-ptest/working/maven/org/apache/hive/hive-hwi/0.14.0-SNAPSHOT/hive-hwi-0.14.0-SNAPSHOT.jar [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/hwi/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/hive-hwi/0.14.0-SNAPSHOT/hive-hwi-0.14.0-SNAPSHOT.pom [INFO] [INFO] [INFO] Building Hive ODBC 0.14.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-odbc --- [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/odbc (includes = [datanucleus.log, derby.log], excludes = []) [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ hive-odbc --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-odbc --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-odbc --- [INFO] Executing tasks main: [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/odbc/target/tmp [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/odbc/target/warehouse [mkdir] Created dir: /data/hive-ptest/working/apache-svn-trunk-source/odbc/target/tmp/conf [copy] Copying 5 files to /data/hive-ptest/working/apache-svn-trunk-source/odbc/target/tmp/conf [INFO] Executed tasks [INFO] [INFO] --- maven-site-plugin:3.3:attach-descriptor (attach-descriptor) @ hive-odbc --- [INFO] [INFO] --- maven-install-plugin:2.4:install (default-install) @ hive-odbc --- [INFO] Installing /data/hive-ptest/working/apache-svn-trunk-source/odbc/pom.xml to /data/hive-ptest/working/maven/org/apache/hive/hive-odbc/0.14.0-SNAPSHOT/hive-odbc-0.14.0-SNAPSHOT.pom [INFO] [INFO] [INFO] Building Hive Shims Aggregator 0.14.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hive-shims-aggregator --- [INFO] Deleting /data/hive-ptest/working/apache-svn-trunk-source/shims (includes = [datanucleus.log, derby.log], excludes = []) [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ hive-shims-aggregator --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (define-classpath) @ hive-shims-aggregator --- [INFO] Executing tasks main: [INFO] Executed tasks [INFO] [INFO] --- maven-antrun-plugin:1.7:run (setup-test-dirs) @ hive-shims-aggregator --- [INFO] Executing tasks main: [mkdir] Created dir:
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934486#comment-13934486 ] Gunther Hagleitner commented on HIVE-6643: -- Minor comments on rb. This is neat: +1 Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Attachments: HIVE-6643.1.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934629#comment-13934629 ] Harish Butani commented on HIVE-6643: - thanks gunther for the review. Will make the changes you have suggested. Submitting patch to check if any existing tests are affected by this check. Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Attachments: HIVE-6643.1.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932668#comment-13932668 ] Harish Butani commented on HIVE-6643: - preliminary patch attached. There are some issues with this: - for MapJoins: the warning only shows the bigTable (even this is not available). Hopefully the Vertex/Stage and Operator information is enough for the user to see where the cross product is happening. - for Shuffle Joins: we need the HIVE-4293 changes to show the tables in a Reducer that has more than 1 input. - the .q.out files have the warnings, but these are appearing before the preehooks for the queries. Is this ok? Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Attachments: HIVE-6643.1.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6643) Add a check for cross products in plans and output a warning
[ https://issues.apache.org/jira/browse/HIVE-6643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932671#comment-13932671 ] Harish Butani commented on HIVE-6643: - review at: https://reviews.apache.org/r/19165/ Add a check for cross products in plans and output a warning Key: HIVE-6643 URL: https://issues.apache.org/jira/browse/HIVE-6643 Project: Hive Issue Type: Bug Reporter: Harish Butani Assignee: Harish Butani Attachments: HIVE-6643.1.patch Now that we support old style join syntax, it is easy to write queries that generate a plan with a cross product. For e.g. say you have A join B join C join D on A.x = B.x and A.y = D.y and C.z = D.z So the JoinTree is: A — B |__ D — C Since we don't reorder join graphs, we will end up with a cross product between (A join B) and C -- This message was sent by Atlassian JIRA (v6.2#6252)