[jira] [Commented] (HIVE-6726) Hcat cli does not close SessionState
[ https://issues.apache.org/jira/browse/HIVE-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967194#comment-13967194 ] Thejas M Nair commented on HIVE-6726: - +1 Hcat cli does not close SessionState Key: HIVE-6726 URL: https://issues.apache.org/jira/browse/HIVE-6726 Project: Hive Issue Type: Bug Affects Versions: 0.13.0, 0.14.0 Reporter: Sushanth Sowmyan Assignee: Sushanth Sowmyan Attachments: HIVE-6726.patch When running HCat E2E tests, it was observed that hcat cli left Tez sessions on the RM which ultimately die upon timeout. Expected behavior is to clean the Tez sessions immediately upon exit. This is causing slowness in system tests as over time lot of orphan Tez sessions hang around. On looking through code, it seems obvious in retrospect because HCatCli starts a SessionState, but does not explicitly call close on them, exiting the jvm through System.exit instead. This needs to be changed to explicitly call SessionState.close() before exiting. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6726) Hcat cli does not close SessionState
[ https://issues.apache.org/jira/browse/HIVE-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951433#comment-13951433 ] Sushanth Sowmyan commented on HIVE-6726: [~thejas]/[~hagleitn], can I bother either of you for a review for this? Hcat cli does not close SessionState Key: HIVE-6726 URL: https://issues.apache.org/jira/browse/HIVE-6726 Project: Hive Issue Type: Bug Affects Versions: 0.13.0, 0.14.0 Reporter: Sushanth Sowmyan Assignee: Sushanth Sowmyan Attachments: HIVE-6726.patch When running HCat E2E tests, it was observed that hcat cli left Tez sessions on the RM which ultimately die upon timeout. Expected behavior is to clean the Tez sessions immediately upon exit. This is causing slowness in system tests as over time lot of orphan Tez sessions hang around. On looking through code, it seems obvious in retrospect because HCatCli starts a SessionState, but does not explicitly call close on them, exiting the jvm through System.exit instead. This needs to be changed to explicitly call SessionState.close() before exiting. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6726) Hcat cli does not close SessionState
[ https://issues.apache.org/jira/browse/HIVE-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945789#comment-13945789 ] Sushanth Sowmyan commented on HIVE-6726: Note - the test failures listed here are not related to this hcat cli fix. Hcat cli does not close SessionState Key: HIVE-6726 URL: https://issues.apache.org/jira/browse/HIVE-6726 Project: Hive Issue Type: Bug Affects Versions: 0.13.0, 0.14.0 Reporter: Sushanth Sowmyan Assignee: Sushanth Sowmyan Attachments: HIVE-6726.patch When running HCat E2E tests, it was observed that hcat cli left Tez sessions on the RM which ultimately die upon timeout. Expected behavior is to clean the Tez sessions immediately upon exit. This is causing slowness in system tests as over time lot of orphan Tez sessions hang around. On looking through code, it seems obvious in retrospect because HCatCli starts a SessionState, but does not explicitly call close on them, exiting the jvm through System.exit instead. This needs to be changed to explicitly call SessionState.close() before exiting. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6726) Hcat cli does not close SessionState
[
https://issues.apache.org/jira/browse/HIVE-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944750#comment-13944750
]
Hive QA commented on HIVE-6726:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12636099/HIVE-6726.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 5443 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table
org.apache.hive.service.cli.thrift.TestThriftHttpCLIService.testExecuteStatementAsync
{noformat}
Test results:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1939/testReport
Console output:
http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1939/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12636099
Hcat cli does not close SessionState
Key: HIVE-6726
URL: https://issues.apache.org/jira/browse/HIVE-6726
Project: Hive
Issue Type: Bug
Affects Versions: 0.13.0, 0.14.0
Reporter: Sushanth Sowmyan
Assignee: Sushanth Sowmyan
Attachments: HIVE-6726.patch
When running HCat E2E tests, it was observed that hcat cli left Tez sessions
on the RM which ultimately die upon timeout. Expected behavior is to clean
the Tez sessions immediately upon exit. This is causing slowness in system
tests as over time lot of orphan Tez sessions hang around.
On looking through code, it seems obvious in retrospect because HCatCli
starts a SessionState, but does not explicitly call close on them, exiting
the jvm through System.exit instead. This needs to be changed to explicitly
call SessionState.close() before exiting.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HIVE-6726) Hcat cli does not close SessionState
[ https://issues.apache.org/jira/browse/HIVE-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943501#comment-13943501 ] Sushanth Sowmyan commented on HIVE-6726: [~hagleitn], could I bug you to have a quick look at this patch to see if this is sufficient? Hcat cli does not close SessionState Key: HIVE-6726 URL: https://issues.apache.org/jira/browse/HIVE-6726 Project: Hive Issue Type: Bug Affects Versions: 0.13.0, 0.14.0 Reporter: Sushanth Sowmyan Assignee: Sushanth Sowmyan Attachments: HIVE-6726.patch When running HCat E2E tests, it was observed that hcat cli left Tez sessions on the RM which ultimately die upon timeout. Expected behavior is to clean the Tez sessions immediately upon exit. This is causing slowness in system tests as over time lot of orphan Tez sessions hang around. On looking through code, it seems obvious in retrospect because HCatCli starts a SessionState, but does not explicitly call close on them, exiting the jvm through System.exit instead. This needs to be changed to explicitly call SessionState.close() before exiting. -- This message was sent by Atlassian JIRA (v6.2#6252)
