[jira] [Commented] (HIVE-6952) Hive 0.13 HiveOutputFormat breaks backwards compatibility
[
https://issues.apache.org/jira/browse/HIVE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13979388#comment-13979388
]
Hive QA commented on HIVE-6952:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12641391/HIVE-6952.patch
{color:red}ERROR:{color} -1 due to 42 failed/errored test(s), 5417 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join32
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_filter_numeric
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby2_map_skew
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_sort_1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_sort_skew_1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_infer_bucket_sort_list_bucket
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_6
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_7
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_8
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_mapjoin_test_outer
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_nullgroup3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_orc_createas1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ppd_join4
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_select_dummy_source
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_list_bucket
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_partscan_1_23
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_symlink_text_input_format
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_truncate_column_list_bucket
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf_current_database
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_10
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_12
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_13
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_14
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_17
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_19
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_20
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_21
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_22
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_23
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_24
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_4
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_5
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_7
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_8
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union_remove_9
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketizedhiveinputformat
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table
org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority2
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_dynamic_partitions_with_whitelist
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_stats_partialscan_autogether
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/22/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/22/console
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 42 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12641391
> Hive 0.13 HiveOutputFormat breaks backwards compatibility
> -
>
> Key: HIVE-6952
> URL: https://issues.apache.org/jira/browse/HIVE-6952
> Project: Hive
> Issue Type: Bug
> Components: File Formats, Serializers/Deserializers
>Affects Versions: 0.13.0
>Reporter: Costin Leau
>Assignee: Ashutosh Chauhan
>Priority: Blocker
> Attachments: HIVE-6952.patch
>
>
> Hive 0.13 changed the signature of HiveOutputFormat (through commit r1527149)
> breaking backwards compatibility with previous releases; the return type of
> getHiveRecordWriter has been changed from RecordWriter to FSRecordWriter.
> FSRecordWriter intr
[jira] [Commented] (HIVE-6952) Hive 0.13 HiveOutputFormat breaks backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978038#comment-13978038 ] Costin Leau commented on HIVE-6952: --- Can't comment on the entire commit but the HiveOutputFormat seems to be fixed now (it's the same as before). Do you have any ETA for 0.13.1? Cause as it stands right now 0.13 is unusable and the more 0.13.1 is postpone, the more likely the breakage will be propagated into the various Hadoop distros out there. Thanks, > Hive 0.13 HiveOutputFormat breaks backwards compatibility > - > > Key: HIVE-6952 > URL: https://issues.apache.org/jira/browse/HIVE-6952 > Project: Hive > Issue Type: Bug > Components: File Formats, Serializers/Deserializers >Affects Versions: 0.13.0 >Reporter: Costin Leau >Assignee: Ashutosh Chauhan >Priority: Blocker > Attachments: HIVE-6952.patch > > > Hive 0.13 changed the signature of HiveOutputFormat (through commit r1527149) > breaking backwards compatibility with previous releases; the return type of > getHiveRecordWriter has been changed from RecordWriter to FSRecordWriter. > FSRecordWriter introduces one new method on top of RecordWriter however it > does not extend the previous interface and it lives in a completely new > package. > Thus code running fine on Hive 0.12 breaks on Hive 0.13. After the upgrade, > code running on HIve 0.13, will break on anything lower than this. > This could have easily been avoided by extending the existing interface or > introducing a new one that RecordWriter could have extended going forward. By > changing the signature, the existing contract (and compatibility) has been > voided. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6952) Hive 0.13 HiveOutputFormat breaks backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977785#comment-13977785 ] Prasanth J commented on HIVE-6952: -- LGTM. +1 (non-binding) > Hive 0.13 HiveOutputFormat breaks backwards compatibility > - > > Key: HIVE-6952 > URL: https://issues.apache.org/jira/browse/HIVE-6952 > Project: Hive > Issue Type: Bug > Components: File Formats, Serializers/Deserializers >Affects Versions: 0.13.0 >Reporter: Costin Leau >Assignee: Ashutosh Chauhan >Priority: Blocker > Attachments: HIVE-6952.patch > > > Hive 0.13 changed the signature of HiveOutputFormat (through commit r1527149) > breaking backwards compatibility with previous releases; the return type of > getHiveRecordWriter has been changed from RecordWriter to FSRecordWriter. > FSRecordWriter introduces one new method on top of RecordWriter however it > does not extend the previous interface and it lives in a completely new > package. > Thus code running fine on Hive 0.12 breaks on Hive 0.13. After the upgrade, > code running on HIve 0.13, will break on anything lower than this. > This could have easily been avoided by extending the existing interface or > introducing a new one that RecordWriter could have extended going forward. By > changing the signature, the existing contract (and compatibility) has been > voided. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HIVE-6952) Hive 0.13 HiveOutputFormat breaks backwards compatibility
[ https://issues.apache.org/jira/browse/HIVE-6952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976591#comment-13976591 ] Costin Leau commented on HIVE-6952: --- Actually taking a closer look indicates that FSRecordWriter and RecordWriter are identical - they both implement the same two methods, with the _exact_ same signature which makes the breaking change even more puzzling. > Hive 0.13 HiveOutputFormat breaks backwards compatibility > - > > Key: HIVE-6952 > URL: https://issues.apache.org/jira/browse/HIVE-6952 > Project: Hive > Issue Type: Bug > Components: File Formats, Serializers/Deserializers >Affects Versions: 0.13.0 >Reporter: Costin Leau >Priority: Blocker > > Hive 0.13 changed the signature of HiveOutputFormat (through commit r1527149) > breaking backwards compatibility with previous releases; the return type of > getHiveRecordWriter has been changed from RecordWriter to FSRecordWriter. > FSRecordWriter introduces one new method on top of RecordWriter however it > does not extend the previous interface and it lives in a completely new > package. > Thus code running fine on Hive 0.12 breaks on Hive 0.13. After the upgrade, > code running on HIve 0.13, will break on anything lower than this. > This could have easily been avoided by extending the existing interface or > introducing a new one that RecordWriter could have extended going forward. By > changing the signature, the existing contract (and compatibility) has been > voided. -- This message was sent by Atlassian JIRA (v6.2#6252)
