[jira] [Commented] (HIVE-7892) Thrift Set type not working with Hive

2014-09-21 Thread Lefty Leverenz (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142366#comment-14142366
 ] 

Lefty Leverenz commented on HIVE-7892:
--

Agreed, thanks [~satish.mittal].

 Thrift Set type not working with Hive
 -

 Key: HIVE-7892
 URL: https://issues.apache.org/jira/browse/HIVE-7892
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Reporter: Satish Mittal
Assignee: Satish Mittal
 Fix For: 0.14.0

 Attachments: HIVE-7892.1.patch, HIVE-7892.patch.txt


 Thrift supports List, Map and Struct complex types, which get mapped to 
 Array, Map and Struct complex types in Hive respectively. However thrift Set 
 type doesn't seem to be working. 
 Here is an example thrift struct:
 {noformat}
 namespace java sample.thrift
 struct setrow {
 1: required seti32 ids,
 2: required string name,
 }
 {noformat}
 A Hive table is created with ROW FORMAT SERDE 
 'org.apache.hadoop.hive.serde2.thrift.ThriftDeserializer' WITH 
 SERDEPROPERTIES ('serialization.class'='sample.thrift.setrow', 
 'serialization.format'='org.apache.thrift.protocol.TBinaryProtocol').
 Describing the table shows:
 {noformat}
 hive describe settable; 
 OK
 ids   structfrom deserializer   
 namestringfrom deserializer
 {noformat}
 Issuing a select query on set column throws SemanticException:
 {noformat}
 hive select ids from settable;
 FAILED: SemanticException java.lang.IllegalArgumentException: Error: name 
 expected at the position 7 of 'struct' but '' is found.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-7892) Thrift Set type not working with Hive

2014-09-20 Thread Lefty Leverenz (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141818#comment-14141818
 ] 

Lefty Leverenz commented on HIVE-7892:
--

Should this be documented in the wiki?

We don't have a wikidoc for the Thrift SerDe (but probably should).  Here are 
some places it is mentioned:

* [Developer Guide -- Hive SerDe | 
https://cwiki.apache.org/confluence/display/Hive/DeveloperGuide#DeveloperGuide-HiveSerDe]
* [SerDe -- Built-in SerDes | 
https://cwiki.apache.org/confluence/display/Hive/SerDe#SerDe-Built-inSerDes]

Hive complex types are documented here:

* [Hive Data Types -- Complex Types | 
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-ComplexTypes]

 Thrift Set type not working with Hive
 -

 Key: HIVE-7892
 URL: https://issues.apache.org/jira/browse/HIVE-7892
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Reporter: Satish Mittal
Assignee: Satish Mittal
 Fix For: 0.14.0

 Attachments: HIVE-7892.1.patch, HIVE-7892.patch.txt


 Thrift supports List, Map and Struct complex types, which get mapped to 
 Array, Map and Struct complex types in Hive respectively. However thrift Set 
 type doesn't seem to be working. 
 Here is an example thrift struct:
 {noformat}
 namespace java sample.thrift
 struct setrow {
 1: required seti32 ids,
 2: required string name,
 }
 {noformat}
 A Hive table is created with ROW FORMAT SERDE 
 'org.apache.hadoop.hive.serde2.thrift.ThriftDeserializer' WITH 
 SERDEPROPERTIES ('serialization.class'='sample.thrift.setrow', 
 'serialization.format'='org.apache.thrift.protocol.TBinaryProtocol').
 Describing the table shows:
 {noformat}
 hive describe settable; 
 OK
 ids   structfrom deserializer   
 namestringfrom deserializer
 {noformat}
 Issuing a select query on set column throws SemanticException:
 {noformat}
 hive select ids from settable;
 FAILED: SemanticException java.lang.IllegalArgumentException: Error: name 
 expected at the position 7 of 'struct' but '' is found.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-7892) Thrift Set type not working with Hive

2014-09-20 Thread Satish Mittal (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141865#comment-14141865
 ] 

Satish Mittal commented on HIVE-7892:
-

[~leftylev] The following wiki briefly mentions various available Hive Serdes:

* [Developer Guide -- Hive SerDe | 
https://cwiki.apache.org/confluence/display/Hive/DeveloperGuide#DeveloperGuide-HiveSerDe
 ]

We can probably mention against ThriftSerde that Thrift complex types get 
mapped to Hive complex types (List-Array, Map-, Struct - Struct 
respectively). With HIVE-7892, Thrift Set type gets mapped to Hive Array type. 
User can setup a Thrift based table using ThriftDeserializer class and query 
various Thrift fields through Hive query.

 Thrift Set type not working with Hive
 -

 Key: HIVE-7892
 URL: https://issues.apache.org/jira/browse/HIVE-7892
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Reporter: Satish Mittal
Assignee: Satish Mittal
 Fix For: 0.14.0

 Attachments: HIVE-7892.1.patch, HIVE-7892.patch.txt


 Thrift supports List, Map and Struct complex types, which get mapped to 
 Array, Map and Struct complex types in Hive respectively. However thrift Set 
 type doesn't seem to be working. 
 Here is an example thrift struct:
 {noformat}
 namespace java sample.thrift
 struct setrow {
 1: required seti32 ids,
 2: required string name,
 }
 {noformat}
 A Hive table is created with ROW FORMAT SERDE 
 'org.apache.hadoop.hive.serde2.thrift.ThriftDeserializer' WITH 
 SERDEPROPERTIES ('serialization.class'='sample.thrift.setrow', 
 'serialization.format'='org.apache.thrift.protocol.TBinaryProtocol').
 Describing the table shows:
 {noformat}
 hive describe settable; 
 OK
 ids   structfrom deserializer   
 namestringfrom deserializer
 {noformat}
 Issuing a select query on set column throws SemanticException:
 {noformat}
 hive select ids from settable;
 FAILED: SemanticException java.lang.IllegalArgumentException: Error: name 
 expected at the position 7 of 'struct' but '' is found.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-7892) Thrift Set type not working with Hive

2014-09-11 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130323#comment-14130323
 ] 

Hive QA commented on HIVE-7892:
---



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12667976/HIVE-7892.1.patch

{color:green}SUCCESS:{color} +1 6196 tests passed

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/743/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/743/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-743/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12667976

 Thrift Set type not working with Hive
 -

 Key: HIVE-7892
 URL: https://issues.apache.org/jira/browse/HIVE-7892
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Reporter: Satish Mittal
Assignee: Satish Mittal
 Attachments: HIVE-7892.1.patch, HIVE-7892.patch.txt


 Thrift supports List, Map and Struct complex types, which get mapped to 
 Array, Map and Struct complex types in Hive respectively. However thrift Set 
 type doesn't seem to be working. 
 Here is an example thrift struct:
 {noformat}
 namespace java sample.thrift
 struct setrow {
 1: required seti32 ids,
 2: required string name,
 }
 {noformat}
 A Hive table is created with ROW FORMAT SERDE 
 'org.apache.hadoop.hive.serde2.thrift.ThriftDeserializer' WITH 
 SERDEPROPERTIES ('serialization.class'='sample.thrift.setrow', 
 'serialization.format'='org.apache.thrift.protocol.TBinaryProtocol').
 Describing the table shows:
 {noformat}
 hive describe settable; 
 OK
 ids   structfrom deserializer   
 namestringfrom deserializer
 {noformat}
 Issuing a select query on set column throws SemanticException:
 {noformat}
 hive select ids from settable;
 FAILED: SemanticException java.lang.IllegalArgumentException: Error: name 
 expected at the position 7 of 'struct' but '' is found.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-7892) Thrift Set type not working with Hive

2014-09-10 Thread Amareshwari Sriramadasu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14128138#comment-14128138
 ] 

Amareshwari Sriramadasu commented on HIVE-7892:
---

Code changes look fine. Can you update the test output for 
convert_enum_to_string.q and upload the patch?

 Thrift Set type not working with Hive
 -

 Key: HIVE-7892
 URL: https://issues.apache.org/jira/browse/HIVE-7892
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Reporter: Satish Mittal
Assignee: Satish Mittal
 Attachments: HIVE-7892.patch.txt


 Thrift supports List, Map and Struct complex types, which get mapped to 
 Array, Map and Struct complex types in Hive respectively. However thrift Set 
 type doesn't seem to be working. 
 Here is an example thrift struct:
 {noformat}
 namespace java sample.thrift
 struct setrow {
 1: required seti32 ids,
 2: required string name,
 }
 {noformat}
 A Hive table is created with ROW FORMAT SERDE 
 'org.apache.hadoop.hive.serde2.thrift.ThriftDeserializer' WITH 
 SERDEPROPERTIES ('serialization.class'='sample.thrift.setrow', 
 'serialization.format'='org.apache.thrift.protocol.TBinaryProtocol').
 Describing the table shows:
 {noformat}
 hive describe settable; 
 OK
 ids   structfrom deserializer   
 namestringfrom deserializer
 {noformat}
 Issuing a select query on set column throws SemanticException:
 {noformat}
 hive select ids from settable;
 FAILED: SemanticException java.lang.IllegalArgumentException: Error: name 
 expected at the position 7 of 'struct' but '' is found.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-7892) Thrift Set type not working with Hive

2014-09-09 Thread Satish Mittal (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126866#comment-14126866
 ] 

Satish Mittal commented on HIVE-7892:
-

Review: https://reviews.apache.org/r/25473/

 Thrift Set type not working with Hive
 -

 Key: HIVE-7892
 URL: https://issues.apache.org/jira/browse/HIVE-7892
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Reporter: Satish Mittal
Assignee: Satish Mittal
 Attachments: HIVE-7892.patch.txt


 Thrift supports List, Map and Struct complex types, which get mapped to 
 Array, Map and Struct complex types in Hive respectively. However thrift Set 
 type doesn't seem to be working. 
 Here is an example thrift struct:
 {noformat}
 namespace java sample.thrift
 struct setrow {
 1: required seti32 ids,
 2: required string name,
 }
 {noformat}
 A Hive table is created with ROW FORMAT SERDE 
 'org.apache.hadoop.hive.serde2.thrift.ThriftDeserializer' WITH 
 SERDEPROPERTIES ('serialization.class'='sample.thrift.setrow', 
 'serialization.format'='org.apache.thrift.protocol.TBinaryProtocol').
 Describing the table shows:
 {noformat}
 hive describe settable; 
 OK
 ids   structfrom deserializer   
 namestringfrom deserializer
 {noformat}
 Issuing a select query on set column throws SemanticException:
 {noformat}
 hive select ids from settable;
 FAILED: SemanticException java.lang.IllegalArgumentException: Error: name 
 expected at the position 7 of 'struct' but '' is found.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-7892) Thrift Set type not working with Hive

2014-09-09 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14127199#comment-14127199
 ] 

Hive QA commented on HIVE-7892:
---



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12667390/HIVE-7892.patch.txt

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 6186 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_convert_enum_to_string
org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/709/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/709/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-709/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12667390

 Thrift Set type not working with Hive
 -

 Key: HIVE-7892
 URL: https://issues.apache.org/jira/browse/HIVE-7892
 Project: Hive
  Issue Type: Bug
  Components: Serializers/Deserializers
Reporter: Satish Mittal
Assignee: Satish Mittal
 Attachments: HIVE-7892.patch.txt


 Thrift supports List, Map and Struct complex types, which get mapped to 
 Array, Map and Struct complex types in Hive respectively. However thrift Set 
 type doesn't seem to be working. 
 Here is an example thrift struct:
 {noformat}
 namespace java sample.thrift
 struct setrow {
 1: required seti32 ids,
 2: required string name,
 }
 {noformat}
 A Hive table is created with ROW FORMAT SERDE 
 'org.apache.hadoop.hive.serde2.thrift.ThriftDeserializer' WITH 
 SERDEPROPERTIES ('serialization.class'='sample.thrift.setrow', 
 'serialization.format'='org.apache.thrift.protocol.TBinaryProtocol').
 Describing the table shows:
 {noformat}
 hive describe settable; 
 OK
 ids   structfrom deserializer   
 namestringfrom deserializer
 {noformat}
 Issuing a select query on set column throws SemanticException:
 {noformat}
 hive select ids from settable;
 FAILED: SemanticException java.lang.IllegalArgumentException: Error: name 
 expected at the position 7 of 'struct' but '' is found.
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)