[jira] [Commented] (HIVE-9166) Place an upper bound for SARG CNF conversion
[ https://issues.apache.org/jira/browse/HIVE-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253818#comment-14253818 ] Vikram Dixit K commented on HIVE-9166: -- +1 for 0.14 > Place an upper bound for SARG CNF conversion > > > Key: HIVE-9166 > URL: https://issues.apache.org/jira/browse/HIVE-9166 > Project: Hive > Issue Type: Bug >Affects Versions: 0.14.0, 0.15.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran > Labels: orcfile > Attachments: HIVE-9166-branch-0.14.1.patch, HIVE-9166.1.patch, > HIVE-9166.2.patch, HIVE-9166.3.patch > > > SARG creation in ORC, applies several optimizations to expression tree. In > that CNF conversion is an exponential algorithm as it finds all combinations > of expressions when converting from OR of AND form to AND of OR form (CNF). > We need an upper bound for this algorithm to prevent it from running for long > time and generating huge combinations list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9166) Place an upper bound for SARG CNF conversion
[
https://issues.apache.org/jira/browse/HIVE-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252818#comment-14252818
]
Hive QA commented on HIVE-9166:
---
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12688162/HIVE-9166.3.patch
{color:green}SUCCESS:{color} +1 6718 tests passed
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2135/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2135/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2135/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12688162 - PreCommit-HIVE-TRUNK-Build
> Place an upper bound for SARG CNF conversion
>
>
> Key: HIVE-9166
> URL: https://issues.apache.org/jira/browse/HIVE-9166
> Project: Hive
> Issue Type: Bug
>Affects Versions: 0.14.0, 0.15.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
> Labels: orcfile
> Attachments: HIVE-9166.1.patch, HIVE-9166.2.patch, HIVE-9166.3.patch
>
>
> SARG creation in ORC, applies several optimizations to expression tree. In
> that CNF conversion is an exponential algorithm as it finds all combinations
> of expressions when converting from OR of AND form to AND of OR form (CNF).
> We need an upper bound for this algorithm to prevent it from running for long
> time and generating huge combinations list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-9166) Place an upper bound for SARG CNF conversion
[ https://issues.apache.org/jira/browse/HIVE-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252438#comment-14252438 ] Prasanth Jayachandran commented on HIVE-9166: - [~vikram.dixit] Can we have this for 0.14.1? > Place an upper bound for SARG CNF conversion > > > Key: HIVE-9166 > URL: https://issues.apache.org/jira/browse/HIVE-9166 > Project: Hive > Issue Type: Bug >Affects Versions: 0.14.0, 0.15.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran > Labels: orcfile > Attachments: HIVE-9166.1.patch, HIVE-9166.2.patch, HIVE-9166.3.patch > > > SARG creation in ORC, applies several optimizations to expression tree. In > that CNF conversion is an exponential algorithm as it finds all combinations > of expressions when converting from OR of AND form to AND of OR form (CNF). > We need an upper bound for this algorithm to prevent it from running for long > time and generating huge combinations list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9166) Place an upper bound for SARG CNF conversion
[ https://issues.apache.org/jira/browse/HIVE-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252406#comment-14252406 ] Owen O'Malley commented on HIVE-9166: - +1 LGTM You probably should add a test case where there is something other than the large CNF. something like (and leaf-1 (or ...)) You should end up with leaf-1 as your final expression. > Place an upper bound for SARG CNF conversion > > > Key: HIVE-9166 > URL: https://issues.apache.org/jira/browse/HIVE-9166 > Project: Hive > Issue Type: Bug >Affects Versions: 0.14.0, 0.15.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran > Labels: orcfile > Attachments: HIVE-9166.1.patch, HIVE-9166.2.patch > > > SARG creation in ORC, applies several optimizations to expression tree. In > that CNF conversion is an exponential algorithm as it finds all combinations > of expressions when converting from OR of AND form to AND of OR form (CNF). > We need an upper bound for this algorithm to prevent it from running for long > time and generating huge combinations list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9166) Place an upper bound for SARG CNF conversion
[ https://issues.apache.org/jira/browse/HIVE-9166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252392#comment-14252392 ] Prasanth Jayachandran commented on HIVE-9166: - [~owen.omalley] Can you plz take a look at the fix? > Place an upper bound for SARG CNF conversion > > > Key: HIVE-9166 > URL: https://issues.apache.org/jira/browse/HIVE-9166 > Project: Hive > Issue Type: Bug >Affects Versions: 0.14.0, 0.15.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran > Labels: orcfile > Attachments: HIVE-9166.1.patch > > > SARG creation in ORC, applies several optimizations to expression tree. In > that CNF conversion is an exponential algorithm as it finds all combinations > of expressions when converting from OR of AND form to AND of OR form (CNF). > We need an upper bound for this algorithm to prevent it from running for long > time and generating huge combinations list. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
