[jira] [Commented] (HIVE-9489) add javadoc for UDFType annotation
[ https://issues.apache.org/jira/browse/HIVE-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296557#comment-14296557 ] Lefty Leverenz commented on HIVE-9489: -- +1 ... although two more quibbles could be fixed (@return true if the udf is deterministic - UDF; non deterministic - non-deterministic). Sorry I missed them the first time. add javadoc for UDFType annotation -- Key: HIVE-9489 URL: https://issues.apache.org/jira/browse/HIVE-9489 Project: Hive Issue Type: Bug Components: Documentation, UDF Reporter: Thejas M Nair Assignee: Thejas M Nair Fix For: 1.2.0 Attachments: HIVE-9489.1.patch, HIVE-9489.2.patch It is not clearly described, when a UDF should be marked as deterministic, stateful or distinctLike. Adding javadoc for now. This information should also be incorporated in the wikidoc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9489) add javadoc for UDFType annotation
[
https://issues.apache.org/jira/browse/HIVE-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296653#comment-14296653
]
Hive QA commented on HIVE-9489:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12695157/HIVE-9489.2.patch
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 7405 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_join38
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_subquery_in
org.apache.hive.hcatalog.templeton.TestWebHCatE2e.getHiveVersion
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2565/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2565/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2565/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12695157 - PreCommit-HIVE-TRUNK-Build
add javadoc for UDFType annotation
--
Key: HIVE-9489
URL: https://issues.apache.org/jira/browse/HIVE-9489
Project: Hive
Issue Type: Bug
Components: Documentation, UDF
Reporter: Thejas M Nair
Assignee: Thejas M Nair
Fix For: 1.2.0
Attachments: HIVE-9489.1.patch, HIVE-9489.2.patch
It is not clearly described, when a UDF should be marked as deterministic,
stateful or distinctLike.
Adding javadoc for now. This information should also be incorporated in the
wikidoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-9489) add javadoc for UDFType annotation
[ https://issues.apache.org/jira/browse/HIVE-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297852#comment-14297852 ] Lefty Leverenz commented on HIVE-9489: -- +1 Thanks for indulging my nitpicks, Thejas. add javadoc for UDFType annotation -- Key: HIVE-9489 URL: https://issues.apache.org/jira/browse/HIVE-9489 Project: Hive Issue Type: Bug Components: Documentation, UDF Reporter: Thejas M Nair Assignee: Thejas M Nair Fix For: 1.2.0 Attachments: HIVE-9489.1.patch, HIVE-9489.2.patch, HIVE-9489.3.patch It is not clearly described, when a UDF should be marked as deterministic, stateful or distinctLike. Adding javadoc for now. This information should also be incorporated in the wikidoc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-9489) add javadoc for UDFType annotation
[
https://issues.apache.org/jira/browse/HIVE-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294952#comment-14294952
]
Hive QA commented on HIVE-9489:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12694904/HIVE-9489.1.patch
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 7403 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_auto_mult_tables
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_join38
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_subquery_in
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2546/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/2546/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-2546/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12694904 - PreCommit-HIVE-TRUNK-Build
add javadoc for UDFType annotation
--
Key: HIVE-9489
URL: https://issues.apache.org/jira/browse/HIVE-9489
Project: Hive
Issue Type: Bug
Components: Documentation, UDF
Reporter: Thejas M Nair
Assignee: Thejas M Nair
Fix For: 1.2.0
Attachments: HIVE-9489.1.patch
It is not clearly described, when a UDF should be marked as deterministic,
stateful or distinctLike.
Adding javadoc for now. This information should also be incorporated in the
wikidoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-9489) add javadoc for UDFType annotation
[
https://issues.apache.org/jira/browse/HIVE-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14294894#comment-14294894
]
Lefty Leverenz commented on HIVE-9489:
--
Hmph. Not many typos for me to find. ;)
{{+ * Certain optimizations should not be applied if UDF is not
deterministic}}
... needs a period at end of line.
{{+ * don't apply for such UDFS, as they need to be invoked for each record.}}
... UDFs, not UDFS.
{{+ * A UDF is considered distinctLike if the udf can be evaluated on just
the}}
... udf should be UDF.
add javadoc for UDFType annotation
--
Key: HIVE-9489
URL: https://issues.apache.org/jira/browse/HIVE-9489
Project: Hive
Issue Type: Bug
Components: Documentation, UDF
Reporter: Thejas M Nair
Assignee: Thejas M Nair
Fix For: 1.2.0
Attachments: HIVE-9489.1.patch
It is not clearly described, when a UDF should be marked as deterministic,
stateful or distinctLike.
Adding javadoc for now. This information should also be incorporated in the
wikidoc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-9489) add javadoc for UDFType annotation
[ https://issues.apache.org/jira/browse/HIVE-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296295#comment-14296295 ] Ashutosh Chauhan commented on HIVE-9489: +1 add javadoc for UDFType annotation -- Key: HIVE-9489 URL: https://issues.apache.org/jira/browse/HIVE-9489 Project: Hive Issue Type: Bug Components: Documentation, UDF Reporter: Thejas M Nair Assignee: Thejas M Nair Fix For: 1.2.0 Attachments: HIVE-9489.1.patch, HIVE-9489.2.patch It is not clearly described, when a UDF should be marked as deterministic, stateful or distinctLike. Adding javadoc for now. This information should also be incorporated in the wikidoc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
