BELUGA BEHR created HIVE-20168:
----------------------------------

             Summary: ReduceSinkOperator Logging Hidden
                 Key: HIVE-20168
                 URL: https://issues.apache.org/jira/browse/HIVE-20168
             Project: Hive
          Issue Type: Bug
          Components: Operators
    Affects Versions: 3.0.0, 4.0.0
            Reporter: BELUGA BEHR


[https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java]

 
{code:java}
if (LOG.isTraceEnabled()) {
  if (numRows == cntr) {
    cntr = logEveryNRows == 0 ? cntr * 10 : numRows + logEveryNRows;
    if (cntr < 0 || numRows < 0) {
      cntr = 0;
      numRows = 1;
    }
    LOG.info(toString() + ": records written - " + numRows);
  }
}

...

if (LOG.isTraceEnabled()) {
  LOG.info(toString() + ": records written - " + numRows);
}
{code}

There are logging guards here checking for TRACE level debugging but the 
logging is actually INFO.  This is important logging for detecting data skew.  
Please change guards to check for INFO... or I would prefer that the guards are 
removed altogether since it's very rare that a service is running with only 
WARN level logging.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to