[jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
[ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Resolution: Fixed Fix Version/s: 0.10.0 Status: Resolved (was: Patch Available) Committed to trunk. Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.8.0, 0.9.0 Reporter: Mithun Radhakrishnan Assignee: Ashutosh Chauhan Fix For: 0.10.0 Attachments: hive-2715_2.patch, hive-2715.patch I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
Hi Ashutosh, Thank you for working on it. After upgrade, is this still the command to build thrift ant thriftif -Dthrift.home=/usr/local I upgrade my thrift to 0.9.0. I see the following files generated and not in version control: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ Constants.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.ja va Thanks Tim On 11/8/12 1:54 AM, Ashutosh Chauhan (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.pl ugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Resolution: Fixed Fix Version/s: 0.10.0 Status: Resolved (was: Patch Available) Committed to trunk. Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.8.0, 0.9.0 Reporter: Mithun Radhakrishnan Assignee: Ashutosh Chauhan Fix For: 0.10.0 Attachments: hive-2715_2.patch, hive-2715.patch I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
Hi Gang, Thrift 0.9 generates those files with name hive_metastoreConstants.java and serdeConstants.java now[1] So, references for Constants.java needs to be updated. Constants.java itself is no longer generated and I have removed it from trunk. Yeah, command remains same as you pointed out. [1] https://issues.apache.org/jira/browse/THRIFT-1090 Thanks, Ashutosh On Thu, Nov 8, 2012 at 8:05 AM, Gang Tim Liu g...@fb.com wrote: Hi Ashutosh, Thank you for working on it. After upgrade, is this still the command to build thrift ant thriftif -Dthrift.home=/usr/local I upgrade my thrift to 0.9.0. I see the following files generated and not in version control: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ Constants.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.ja va Thanks Tim On 11/8/12 1:54 AM, Ashutosh Chauhan (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.pl ugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Resolution: Fixed Fix Version/s: 0.10.0 Status: Resolved (was: Patch Available) Committed to trunk. Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.8.0, 0.9.0 Reporter: Mithun Radhakrishnan Assignee: Ashutosh Chauhan Fix For: 0.10.0 Attachments: hive-2715_2.patch, hive-2715.patch I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
Hi Ashutosh, Thank you for clarification. On 11/8/12 8:21 AM, Ashutosh Chauhan hashut...@apache.org wrote: Hi Gang, Thrift 0.9 generates those files with name hive_metastoreConstants.java and serdeConstants.java now[1] So, references for Constants.java needs to be updated. Constants.java itself is no longer generated and I have removed it from trunk. Yeah, command remains same as you pointed out. [1] https://issues.apache.org/jira/browse/THRIFT-1090 Thanks, Ashutosh On Thu, Nov 8, 2012 at 8:05 AM, Gang Tim Liu g...@fb.com wrote: Hi Ashutosh, Thank you for working on it. After upgrade, is this still the command to build thrift ant thriftif -Dthrift.home=/usr/local I upgrade my thrift to 0.9.0. I see the following files generated and not in version control: metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/ap i/ Constants.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants. ja va Thanks Tim On 11/8/12 1:54 AM, Ashutosh Chauhan (JIRA) j...@apache.org wrote: [ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.p l ugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Resolution: Fixed Fix Version/s: 0.10.0 Status: Resolved (was: Patch Available) Committed to trunk. Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.8.0, 0.9.0 Reporter: Mithun Radhakrishnan Assignee: Ashutosh Chauhan Fix For: 0.10.0 Attachments: hive-2715_2.patch, hive-2715.patch I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
[ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Attachment: hive-2715_2.patch Updated patch. Differences from previous patch: * Added megastruct.thrift in thriftif target of serde/build.xml So, now MegaStruct.java, MiniStruct.java and MyEnum.java are getting updated. * Deleted now stale Constants.java As a results bunch of changes in various places to update its references. * Kept php files since I think they should be there. Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.8.0, 0.9.0 Reporter: Mithun Radhakrishnan Assignee: Ashutosh Chauhan Attachments: hive-2715_2.patch, hive-2715.patch I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
[ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Status: Patch Available (was: Open) Yes, it is. Forgot to hit Patch Available. Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.9.0, 0.8.0 Reporter: Mithun Radhakrishnan Assignee: Ashutosh Chauhan Attachments: hive-2715_2.patch, hive-2715.patch I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
[
https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carl Steinbach updated HIVE-2715:
-
Status: Open (was: Patch Available)
@Ashutosh: After applying the patch I deleted the contents of
*/src/gen/thrift/*, and then tried running the thriftif target again, and
noticed that the following files are not replaced:
{noformat}
D
metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Constants.java
D metastore/src/gen/thrift/gen-php/ThriftHiveMetastore.php
D metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php
D metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_constants.php
D metastore/src/gen/thrift/gen-php/hive_metastore/hive_metastore_types.php
D metastore/src/gen/thrift/gen-php/hive_metastore_constants.php
D metastore/src/gen/thrift/gen-php/hive_metastore_types.php
D ql/src/gen/thrift/gen-php/queryplan/queryplan_types.php
D serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/Constants.java
D
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
D
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MiniStruct.java
D
serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MyEnum.java
D serde/src/gen/thrift/gen-php/serde/serde_constants.php
D serde/src/gen/thrift/gen-php/serde/serde_types.php
D service/src/gen/thrift/gen-php/hive_service/ThriftHive.php
D service/src/gen/thrift/gen-php/hive_service/hive_service_types.php
{noformat}
The missing Constants.java files appear to be caused by THRIFT-1090.
I also think it would be a good idea to modify the thriftif Ant target to
automatically clean the old generated artifacts before running the code
generator. The HiveServer2 patch actually includes this modification, so maybe
it would be worthwhile copying it from there and including it in this patch.
Upgrade Thrift dependency to 0.9.0
--
Key: HIVE-2715
URL: https://issues.apache.org/jira/browse/HIVE-2715
Project: Hive
Issue Type: Bug
Components: Metastore
Affects Versions: 0.9.0, 0.8.0
Reporter: Mithun Radhakrishnan
Assignee: Ashutosh Chauhan
Attachments: hive-2715.patch
I work on HCatalog (0.2). Recently, we ran into HCat_server running out of
memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468,
recently fixed).
HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0.
(The bug also exists on 0.7.0.)
May I please enquire if Hive can't depend on a more current version of
thrift? (Does it break the metastore?) I'm afraid I'm not privy to the
reasoning behind Hive's dependency on a slightly dated thrift-lib.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
[ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Assignee: Ashutosh Chauhan Affects Version/s: 0.9.0 Status: Patch Available (was: Open) Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.9.0, 0.8.0 Reporter: Mithun Radhakrishnan Assignee: Ashutosh Chauhan Attachments: hive-2715.patch I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
[ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Attachment: hive-2715.patch Patch which updates thrift dependency to 0.9 Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.8.0, 0.9.0 Reporter: Mithun Radhakrishnan Attachments: hive-2715.patch I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
[ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashutosh Chauhan updated HIVE-2715: --- Fix Version/s: (was: 0.9.0) Unlinking from 0.9 Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.8.0 Reporter: Mithun Radhakrishnan I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2715) Upgrade Thrift dependency to 0.9.0
[ https://issues.apache.org/jira/browse/HIVE-2715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Steinbach updated HIVE-2715: - Fix Version/s: (was: 0.8.1) Summary: Upgrade Thrift dependency to 0.9.0 (was: Memory leak in TSaslServerTransport) Looks like the fix for THRIFT-1468 will be included in the as-yet-unreleased version 0.9.0. We can update Hive's Thrift dependency once this release goes GA. Upgrade Thrift dependency to 0.9.0 -- Key: HIVE-2715 URL: https://issues.apache.org/jira/browse/HIVE-2715 Project: Hive Issue Type: Bug Components: Metastore Affects Versions: 0.8.0 Reporter: Mithun Radhakrishnan Fix For: 0.9.0 I work on HCatalog (0.2). Recently, we ran into HCat_server running out of memory every few days, and it boiled down to a bug in thrift, (THRIFT-1468, recently fixed). HCat-0.2-branch depends on Hive-0.8, which in turn depends on thrift-0.5.0. (The bug also exists on 0.7.0.) May I please enquire if Hive can't depend on a more current version of thrift? (Does it break the metastore?) I'm afraid I'm not privy to the reasoning behind Hive's dependency on a slightly dated thrift-lib. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
