[jira] [Updated] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events

2013-04-23 Thread Phabricator (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4393:
--

Attachment: HIVE-4393.D10443.2.patch

Mrrrgn updated the revision HIVE-4393 [jira] Make the deleteData flag 
accessable from DropTable/Partition events.

  Added more descriptive comments.

Reviewers: JIRA, kevinwilfong

REVISION DETAIL
  https://reviews.facebook.net/D10443

CHANGE SINCE LAST DIFF
  https://reviews.facebook.net/D10443?vs=32631id=32751#toc

AFFECTED FILES
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
  
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
  metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java
  
metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropPartitionEvent.java
  
metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropTableEvent.java

To: JIRA, kevinwilfong, Mrrrgn


 Make the deleteData flag accessable from DropTable/Partition events
 ---

 Key: HIVE-4393
 URL: https://issues.apache.org/jira/browse/HIVE-4393
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Morgan Phillips
Assignee: Morgan Phillips
Priority: Minor
 Attachments: HIVE-4393.D10443.1.patch, HIVE-4393.D10443.2.patch


 On occasion, due to some error during a drop, information is removed from the 
 metastore but data, which should have been removed, remains intact on the 
 DFS.  In order to log such events via PreEvent and Event listeners a new 
 method 'getDeleteData' should be added to (Pre)DropPartitionEvent and 
 (Pre)DropTableEvent which returns the deleteData flag's value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events

2013-04-23 Thread Namit Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Namit Jain updated HIVE-4393:
-

Status: Patch Available  (was: Open)

 Make the deleteData flag accessable from DropTable/Partition events
 ---

 Key: HIVE-4393
 URL: https://issues.apache.org/jira/browse/HIVE-4393
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Morgan Phillips
Assignee: Morgan Phillips
Priority: Minor
 Attachments: HIVE-4393.D10443.1.patch, HIVE-4393.D10443.2.patch


 On occasion, due to some error during a drop, information is removed from the 
 metastore but data, which should have been removed, remains intact on the 
 DFS.  In order to log such events via PreEvent and Event listeners a new 
 method 'getDeleteData' should be added to (Pre)DropPartitionEvent and 
 (Pre)DropTableEvent which returns the deleteData flag's value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events

2013-04-23 Thread Namit Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Namit Jain updated HIVE-4393:
-

   Resolution: Fixed
Fix Version/s: 0.12.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

Committed. Thanks Morgan

 Make the deleteData flag accessable from DropTable/Partition events
 ---

 Key: HIVE-4393
 URL: https://issues.apache.org/jira/browse/HIVE-4393
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Morgan Phillips
Assignee: Morgan Phillips
Priority: Minor
 Fix For: 0.12.0

 Attachments: HIVE-4393.D10443.1.patch, HIVE-4393.D10443.2.patch


 On occasion, due to some error during a drop, information is removed from the 
 metastore but data, which should have been removed, remains intact on the 
 DFS.  In order to log such events via PreEvent and Event listeners a new 
 method 'getDeleteData' should be added to (Pre)DropPartitionEvent and 
 (Pre)DropTableEvent which returns the deleteData flag's value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events

2013-04-22 Thread Phabricator (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4393:
--

Attachment: HIVE-4393.D10443.1.patch

Mrrrgn requested code review of HIVE-4393 [jira] Make the deleteData flag 
accessable from DropTable/Partition events.

Reviewers: JIRA

HIVE-4393 made deleteData accessable from (Pre)DropPartitionEvent and 
(Pre)DropTableEvent.

On occasion, due to some error during a drop, information is removed from the 
metastore but data, which should have been removed, remains intact on the DFS.  
In order to log such events via PreEvent and Event listeners a new method 
'getDeleteData' should be added to (Pre)DropPartitionEvent and 
(Pre)DropTableEvent which returns the deleteData flag's value.

TEST PLAN
  Compiled and ran.

REVISION DETAIL
  https://reviews.facebook.net/D10443

AFFECTED FILES
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
  
metastore/src/java/org/apache/hadoop/hive/metastore/events/DropPartitionEvent.java
  metastore/src/java/org/apache/hadoop/hive/metastore/events/DropTableEvent.java
  
metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropPartitionEvent.java
  
metastore/src/java/org/apache/hadoop/hive/metastore/events/PreDropTableEvent.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/24987/

To: JIRA, Mrrrgn


 Make the deleteData flag accessable from DropTable/Partition events
 ---

 Key: HIVE-4393
 URL: https://issues.apache.org/jira/browse/HIVE-4393
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Morgan Phillips
Assignee: Morgan Phillips
Priority: Minor
 Attachments: HIVE-4393.D10443.1.patch


 On occasion, due to some error during a drop, information is removed from the 
 metastore but data, which should have been removed, remains intact on the 
 DFS.  In order to log such events via PreEvent and Event listeners a new 
 method 'getDeleteData' should be added to (Pre)DropPartitionEvent and 
 (Pre)DropTableEvent which returns the deleteData flag's value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events

2013-04-22 Thread Morgan Phillips (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Morgan Phillips updated HIVE-4393:
--

Status: Patch Available  (was: Open)

 Make the deleteData flag accessable from DropTable/Partition events
 ---

 Key: HIVE-4393
 URL: https://issues.apache.org/jira/browse/HIVE-4393
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Morgan Phillips
Assignee: Morgan Phillips
Priority: Minor
 Attachments: HIVE-4393.D10443.1.patch


 On occasion, due to some error during a drop, information is removed from the 
 metastore but data, which should have been removed, remains intact on the 
 DFS.  In order to log such events via PreEvent and Event listeners a new 
 method 'getDeleteData' should be added to (Pre)DropPartitionEvent and 
 (Pre)DropTableEvent which returns the deleteData flag's value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Updated] (HIVE-4393) Make the deleteData flag accessable from DropTable/Partition events

2013-04-22 Thread Namit Jain (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-4393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Namit Jain updated HIVE-4393:
-

Status: Open  (was: Patch Available)

 Make the deleteData flag accessable from DropTable/Partition events
 ---

 Key: HIVE-4393
 URL: https://issues.apache.org/jira/browse/HIVE-4393
 Project: Hive
  Issue Type: Improvement
  Components: Metastore
Reporter: Morgan Phillips
Assignee: Morgan Phillips
Priority: Minor
 Attachments: HIVE-4393.D10443.1.patch


 On occasion, due to some error during a drop, information is removed from the 
 metastore but data, which should have been removed, remains intact on the 
 DFS.  In order to log such events via PreEvent and Event listeners a new 
 method 'getDeleteData' should be added to (Pre)DropPartitionEvent and 
 (Pre)DropTableEvent which returns the deleteData flag's value.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira