[jira] [Updated] (HIVE-7452) Boolean comparison is done through reference equality rather than using equals

2014-08-07 Thread KangHS (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

KangHS updated HIVE-7452:
-

Status: Patch Available  (was: Open)

 Boolean comparison is done through reference equality rather than using equals
 --

 Key: HIVE-7452
 URL: https://issues.apache.org/jira/browse/HIVE-7452
 Project: Hive
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
 Attachments: HIVE-7452.patch


 In Driver#doAuthorization():
 {code}
 if (tbl != null  !tableAuthChecked.contains(tbl.getTableName()) 
 !(tableUsePartLevelAuth.get(tbl.getTableName()) == Boolean.TRUE)) 
 {
 {code}
 The above comparison should be done using .equals() method.
 The comparison below doesn't evaluate to true:
 {code}
 Boolean b = new Boolean(true);
 if (b == Boolean.TRUE) {
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HIVE-7452) Boolean comparison is done through reference equality rather than using equals

2014-08-07 Thread KangHS (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-7452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

KangHS updated HIVE-7452:
-

Attachment: HIVE-7452.patch

Change the boolean comparison method.
- doAuthrization()
- getTableParitionUsedColums()


 Boolean comparison is done through reference equality rather than using equals
 --

 Key: HIVE-7452
 URL: https://issues.apache.org/jira/browse/HIVE-7452
 Project: Hive
  Issue Type: Bug
Reporter: Ted Yu
Priority: Minor
 Attachments: HIVE-7452.patch


 In Driver#doAuthorization():
 {code}
 if (tbl != null  !tableAuthChecked.contains(tbl.getTableName()) 
 !(tableUsePartLevelAuth.get(tbl.getTableName()) == Boolean.TRUE)) 
 {
 {code}
 The above comparison should be done using .equals() method.
 The comparison below doesn't evaluate to true:
 {code}
 Boolean b = new Boolean(true);
 if (b == Boolean.TRUE) {
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)