[jira] [Updated] (HIVE-7600) ConstantPropagateProcFactory uses reference equality on Boolean

2014-08-08 Thread Ashutosh Chauhan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-7600:
---

Assignee: KangHS

 ConstantPropagateProcFactory uses reference equality on Boolean
 ---

 Key: HIVE-7600
 URL: https://issues.apache.org/jira/browse/HIVE-7600
 Project: Hive
  Issue Type: Bug
Reporter: Ted Yu
Assignee: KangHS
 Attachments: HIVE-7600.patch


 shortcutFunction() has the following code:
 {code}
   if (c.getValue() == Boolean.FALSE) {
 {code}
 Boolean.FALSE.equals() should be used.
 There're a few other occurrences of using reference equality on Boolean in 
 this class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HIVE-7600) ConstantPropagateProcFactory uses reference equality on Boolean

2014-08-08 Thread Ashutosh Chauhan (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Chauhan updated HIVE-7600:
---

   Resolution: Fixed
Fix Version/s: 0.14.0
   Status: Resolved  (was: Patch Available)

Committed to trunk. Thanks, KangHS!

 ConstantPropagateProcFactory uses reference equality on Boolean
 ---

 Key: HIVE-7600
 URL: https://issues.apache.org/jira/browse/HIVE-7600
 Project: Hive
  Issue Type: Bug
Reporter: Ted Yu
Assignee: KangHS
 Fix For: 0.14.0

 Attachments: HIVE-7600.patch


 shortcutFunction() has the following code:
 {code}
   if (c.getValue() == Boolean.FALSE) {
 {code}
 Boolean.FALSE.equals() should be used.
 There're a few other occurrences of using reference equality on Boolean in 
 this class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HIVE-7600) ConstantPropagateProcFactory uses reference equality on Boolean

2014-08-07 Thread KangHS (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

KangHS updated HIVE-7600:
-

Attachment: HIVE-7600.patch

Change the compared method for Boolean's value.
- shortcutFunction()
- process()

 ConstantPropagateProcFactory uses reference equality on Boolean
 ---

 Key: HIVE-7600
 URL: https://issues.apache.org/jira/browse/HIVE-7600
 Project: Hive
  Issue Type: Bug
Reporter: Ted Yu
 Attachments: HIVE-7600.patch


 shortcutFunction() has the following code:
 {code}
   if (c.getValue() == Boolean.FALSE) {
 {code}
 Boolean.FALSE.equals() should be used.
 There're a few other occurrences of using reference equality on Boolean in 
 this class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Updated] (HIVE-7600) ConstantPropagateProcFactory uses reference equality on Boolean

2014-08-07 Thread KangHS (JIRA)

 [ 
https://issues.apache.org/jira/browse/HIVE-7600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

KangHS updated HIVE-7600:
-

Status: Patch Available  (was: Open)

 ConstantPropagateProcFactory uses reference equality on Boolean
 ---

 Key: HIVE-7600
 URL: https://issues.apache.org/jira/browse/HIVE-7600
 Project: Hive
  Issue Type: Bug
Reporter: Ted Yu
 Attachments: HIVE-7600.patch


 shortcutFunction() has the following code:
 {code}
   if (c.getValue() == Boolean.FALSE) {
 {code}
 Boolean.FALSE.equals() should be used.
 There're a few other occurrences of using reference equality on Boolean in 
 this class.



--
This message was sent by Atlassian JIRA
(v6.2#6252)