[jira] [Updated] (HIVE-8379) NanoTimeUtils performs some work needlessly
[ https://issues.apache.org/jira/browse/HIVE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Peña updated HIVE-8379: -- Status: Patch Available (was: Open) Patch attached with a rebase. NanoTimeUtils performs some work needlessly --- Key: HIVE-8379 URL: https://issues.apache.org/jira/browse/HIVE-8379 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Assignee: Sergio Peña Priority: Minor Attachments: HIVE-8379.1.patch, HIVE-8379.2.patch Portions of the math done with the constants can be pre-computed: https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L70 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8379) NanoTimeUtils performs some work needlessly
[ https://issues.apache.org/jira/browse/HIVE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Peña updated HIVE-8379: -- Attachment: HIVE-8379.2.patch NanoTimeUtils performs some work needlessly --- Key: HIVE-8379 URL: https://issues.apache.org/jira/browse/HIVE-8379 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Assignee: Sergio Peña Priority: Minor Attachments: HIVE-8379.1.patch, HIVE-8379.2.patch Portions of the math done with the constants can be pre-computed: https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L70 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8379) NanoTimeUtils performs some work needlessly
[ https://issues.apache.org/jira/browse/HIVE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Peña updated HIVE-8379: -- Status: Open (was: Patch Available) NanoTimeUtils performs some work needlessly --- Key: HIVE-8379 URL: https://issues.apache.org/jira/browse/HIVE-8379 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Assignee: Sergio Peña Priority: Minor Attachments: HIVE-8379.1.patch, HIVE-8379.2.patch Portions of the math done with the constants can be pre-computed: https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L70 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8379) NanoTimeUtils performs some work needlessly
[ https://issues.apache.org/jira/browse/HIVE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brock Noland updated HIVE-8379: --- Resolution: Fixed Fix Version/s: 1.2.0 Status: Resolved (was: Patch Available) Thank you Sergio! I have committed this to trunk! NanoTimeUtils performs some work needlessly --- Key: HIVE-8379 URL: https://issues.apache.org/jira/browse/HIVE-8379 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Assignee: Sergio Peña Priority: Minor Fix For: 1.2.0 Attachments: HIVE-8379.1.patch, HIVE-8379.2.patch Portions of the math done with the constants can be pre-computed: https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L70 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8379) NanoTimeUtils performs some work needlessly
[ https://issues.apache.org/jira/browse/HIVE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Peña updated HIVE-8379: -- Status: Patch Available (was: Open) NanoTimeUtils performs some work needlessly --- Key: HIVE-8379 URL: https://issues.apache.org/jira/browse/HIVE-8379 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Assignee: Sergio Peña Priority: Minor Attachments: HIVE-8379.1.patch Portions of the math done with the constants can be pre-computed: https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L70 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8379) NanoTimeUtils performs some work needlessly
[ https://issues.apache.org/jira/browse/HIVE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Peña updated HIVE-8379: -- Attachment: HIVE-8379.1.patch Patch attached that makes the code more readable by using constants names specific to the nano time. I run some JMH micro benchmark times look almost the same for both approaches. NanoTimeUtils performs some work needlessly --- Key: HIVE-8379 URL: https://issues.apache.org/jira/browse/HIVE-8379 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Assignee: Sergio Peña Priority: Minor Attachments: HIVE-8379.1.patch Portions of the math done with the constants can be pre-computed: https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L70 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-8379) NanoTimeUtils performs some work needlessly
[ https://issues.apache.org/jira/browse/HIVE-8379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brock Noland updated HIVE-8379: --- Priority: Minor (was: Major) NanoTimeUtils performs some work needlessly --- Key: HIVE-8379 URL: https://issues.apache.org/jira/browse/HIVE-8379 Project: Hive Issue Type: Sub-task Reporter: Brock Noland Priority: Minor Portions of the math done with the constants can be pre-computed: https://github.com/apache/hive/blob/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java#L70 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
