[jira] Commented: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new commands for SHOW/DESCRIBE indexes

2010-11-08 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929659#action_12929659
 ] 

He Yongqiang commented on HIVE-1497:


+/*if (!tbl.isIndexed()) {
+  console.printError(Table  + tableName +  does not have any indexes);
+  return 1;
+}*/

need to be removed.

{noformat}
setFetchTask(createFetchTask(showIndexesDesc.getSchema()));
{noformat}

need to be removed.

There is no index comment in the new testcase. Can you add some test cases?

SHOW INDEX ON shidx_t1; right now lists all indexes on the given table? Can we 
also support show one index? i mean sth like : 'show index index_name on tbl'  
(you can do it in a follow up jira)

Right now the show index output format is:

{noformat}
+idx_name   tab_namecol_name
idx_tab_nameidx_typecomment 
+
+
+idx_1  show_idx_full   key 
default__show_idx_full_idx_1__  compact 
+idx_2  show_idx_full   value1  
default__show_idx_full_idx_2__  compact 
+idx_3  show_idx_full   value2  
default__show_idx_full_idx_3__  compact  
{noformat}

John, is this intentional? 

Otherwise, the patch looks good.

 support COMMENT clause on CREATE INDEX, and add new commands for 
 SHOW/DESCRIBE indexes
 --

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, 
 hive-1497.p1.patch, hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new commands for SHOW/DESCRIBE indexes

2010-11-08 Thread John Sichi (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929674#action_12929674
 ] 

John Sichi commented on HIVE-1497:
--

Right, we decided to do more details for a single index in a separate DESCRIBE 
command.  Russell, please open a followup JIRA for that one now, link it to 
this one as related, and then edit the title for this one.

 support COMMENT clause on CREATE INDEX, and add new commands for 
 SHOW/DESCRIBE indexes
 --

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, 
 hive-1497.p1.patch, hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new commands for SHOW/DESCRIBE indexes

2010-11-08 Thread John Sichi (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12929763#action_12929763
 ] 

John Sichi commented on HIVE-1497:
--

Oops, the followup already exists (HIVE-1764).  I'll edit the title of this one.

 support COMMENT clause on CREATE INDEX, and add new commands for 
 SHOW/DESCRIBE indexes
 --

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, 
 hive-1497.p1.patch, hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new commands for SHOW/DESCRIBE indexes

2010-11-04 Thread Russell Melick (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12928140#action_12928140
 ] 

Russell Melick commented on HIVE-1497:
--

Should also update the Index wiki:

http://wiki.apache.org/hadoop/Hive/IndexDev

 support COMMENT clause on CREATE INDEX, and add new commands for 
 SHOW/DESCRIBE indexes
 --

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: HIVE-1497.4.patch, HIVE-1497.5.patch, 
 hive-1497.p1.patch, hive-1497.p2.patch, hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1497) support COMMENT clause on CREATE INDEX, and add new commands for SHOW/DESCRIBE indexes

2010-11-01 Thread John Sichi (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12927086#action_12927086
 ] 

John Sichi commented on HIVE-1497:
--

As discussed in last week's conf call, we'll need a followup for a separate 
DESCRIBE command (which will cover properties and partitions).

 support COMMENT clause on CREATE INDEX, and add new commands for 
 SHOW/DESCRIBE indexes
 --

 Key: HIVE-1497
 URL: https://issues.apache.org/jira/browse/HIVE-1497
 Project: Hive
  Issue Type: Improvement
  Components: Indexing
Affects Versions: 0.7.0
Reporter: John Sichi
Assignee: Russell Melick
 Fix For: 0.7.0

 Attachments: hive-1497.p1.patch, hive-1497.p2.patch, 
 hive-1497.p3.patch


 We need to work out the syntax for SHOW/DESCRIBE, taking partitioning into 
 account.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.