Re: Is there a way to test schema evolution scripts?
Hello, The tests under DbInstallBase [1] seem to do more or less what you want. Check them out and if something is missing don't hesitate to enrich them. Best, Stamatis [1] https://github.com/apache/hive/blob/5e46e80bc7d059093aece81e3886ba5ee425ee95/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/DbInstallBase.java On Mon, Jul 10, 2023 at 5:46 PM Ayush Saxena wrote: > > Hi Zsolt, > You can start by exploring this: > https://github.com/apache/hive/blob/master/standalone-metastore/DEV-README > > It has steps to run those metatore scripts over different database > types locally. > > -Ayush > > On Mon, 10 Jul 2023 at 20:30, Zsolt Miskolczi > wrote: > > > > Hi, > > > > I just stared at a pull request about using liquibase for schema evolution > > and I was thinking how such a change can be validated. > > > > I think the main issue is that we support multiple types of relational > > databases but precommit tests don't test them at all. > > > > I think if we want to check if the idea works, it is enough to: > > - introduce a proper docker based instance for each type of database > > (postgres and derby first). > > - run the upgrade scripts on them > > - check if any error occurs > > > > And the end goal should be something like having validation scripts and > > check if we are able to run selects after the upgrades and fresh installs. > > > > > > What do you think about that? > > > > Thank you, > > Zsolt Miskolczi
Re: Is there a way to test schema evolution scripts?
Hi Zsolt, You can start by exploring this: https://github.com/apache/hive/blob/master/standalone-metastore/DEV-README It has steps to run those metatore scripts over different database types locally. -Ayush On Mon, 10 Jul 2023 at 20:30, Zsolt Miskolczi wrote: > > Hi, > > I just stared at a pull request about using liquibase for schema evolution > and I was thinking how such a change can be validated. > > I think the main issue is that we support multiple types of relational > databases but precommit tests don't test them at all. > > I think if we want to check if the idea works, it is enough to: > - introduce a proper docker based instance for each type of database > (postgres and derby first). > - run the upgrade scripts on them > - check if any error occurs > > And the end goal should be something like having validation scripts and > check if we are able to run selects after the upgrades and fresh installs. > > > What do you think about that? > > Thank you, > Zsolt Miskolczi
Is there a way to test schema evolution scripts?
Hi, I just stared at a pull request about using liquibase for schema evolution and I was thinking how such a change can be validated. I think the main issue is that we support multiple types of relational databases but precommit tests don't test them at all. I think if we want to check if the idea works, it is enough to: - introduce a proper docker based instance for each type of database (postgres and derby first). - run the upgrade scripts on them - check if any error occurs And the end goal should be something like having validation scripts and check if we are able to run selects after the upgrades and fresh installs. What do you think about that? Thank you, Zsolt Miskolczi
