----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11239/ -----------------------------------------------------------
(Updated May 20, 2013, 3:11 p.m.) Review request for hive, Jitendra Pandey and Eric Hanson. Summary (updated) ----------------- HIVE-4450 Extend vectorized Group By aggregates to support keys Description ------- Add VectorKeyHashWrapper and related components for vectorized GROUP BY key evaluation. Add keyed aggregation buffers and key->buffer map in VectorGroupByOperator Extended the aggregation operators to support a keyed batch evaluation operation. This addresses bug HIVE-4450. https://issues.apache.org/jira/browse/HIVE-4450 Diffs ----- metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f9da781 ql/src/java/org/apache/hadoop/hive/ql/exec/VectorHashKeyWrapper.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/VectorHashKeyWrapperBatch.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorAggregationBufferBatch.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java bcee45c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 1a0d98a ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/VectorAggregateExpression.java 8623fe5 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFAvgDouble.java bf6f786 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFAvgLong.java 23aa6dd ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFCountDouble.java 0995a01 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFCountLong.java 5f595c5 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMaxDouble.java 7616752 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMaxLong.java 3c16d33 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMinDouble.java 7067c1c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFMinLong.java 9f813b2 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFStdPopDouble.java 022b449 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFStdPopLong.java 9f658d1 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFStdSampDouble.java cb5f47d ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFStdSampLong.java 882795b ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFSumDouble.java b4b425d ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFSumLong.java 9420aa2 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFVarPopDouble.java 0d58bb9 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFVarPopLong.java 2c27e8f ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFVarSampDouble.java 4156e18 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/aggregates/gen/VectorUDAFVarSampLong.java 7042382 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/CodeGen.java 53d9a7a ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFAvg.txt PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFCount.txt b51e526 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFMinMax.txt 8c952c1 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFSum.txt b321654 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/templates/VectorUDAFVar.txt 29abddf ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java 8415498 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestConstantVectorExpression.java f2e5399 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/util/FakeCaptureOutputOperator.java e4cd0b6 Diff: https://reviews.apache.org/r/11239/diff/ Testing ------- New unit tests added for aggregated expressions with keys, including null keys. Thanks, Remus Rusanu