Re: Review Request 12562: HIVE-4858: Sort show grant result to improve usability and testability
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12562/#review23533 --- Ship it! Ship It! - Brock Noland On July 17, 2013, 8:04 p.m., Xuefu Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12562/ --- (Updated July 17, 2013, 8:04 p.m.) Review request for hive. Bugs: HIVE-4858 https://issues.apache.org/jira/browse/HIVE-4858 Repository: hive-git Description --- Patch includes code changes and query output re-generation for a couple of test cases. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9883659 ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out 4262b7c ql/src/test/results/clientpositive/authorization_2.q.out c934a2a ql/src/test/results/clientpositive/authorization_6.q.out b8483ca Diff: https://reviews.apache.org/r/12562/diff/ Testing --- Performed the authorization test cases. Thanks, Xuefu Zhang
Re: Review Request 12562: HIVE-4858: Sort show grant result to improve usability and testability
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12562/ --- (Updated July 17, 2013, 8:04 p.m.) Review request for hive. Changes --- Patch is updated based on review comments. Bugs: HIVE-4858 https://issues.apache.org/jira/browse/HIVE-4858 Repository: hive-git Description --- Patch includes code changes and query output re-generation for a couple of test cases. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9883659 ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out 4262b7c ql/src/test/results/clientpositive/authorization_2.q.out c934a2a ql/src/test/results/clientpositive/authorization_6.q.out b8483ca Diff: https://reviews.apache.org/r/12562/diff/ Testing --- Performed the authorization test cases. Thanks, Xuefu Zhang
Re: Review Request 12562: HIVE-4858: Sort show grant result to improve usability and testability
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12562/#review23181 --- Looks good! I do think we should align the style with the predominant hive style though. ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java https://reviews.apache.org/r/12562/#comment47041 I think the spaces on the left and right hand side are style differences. Most of the code in hive I've seen does not have the additional spaces. Also the code nearby does not have those spaces. ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java https://reviews.apache.org/r/12562/#comment47039 trailing whitespace - Brock Noland On July 15, 2013, 10:28 p.m., Xuefu Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12562/ --- (Updated July 15, 2013, 10:28 p.m.) Review request for hive. Bugs: HIVE-4858 https://issues.apache.org/jira/browse/HIVE-4858 Repository: hive-git Description --- Patch includes code changes and query output re-generation for a couple of test cases. Diffs - ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9883659 ql/src/test/results/clientpositive/alter_rename_partition_authorization.q.out 4262b7c ql/src/test/results/clientpositive/authorization_2.q.out c934a2a ql/src/test/results/clientpositive/authorization_6.q.out b8483ca Diff: https://reviews.apache.org/r/12562/diff/ Testing --- Performed the authorization test cases. Thanks, Xuefu Zhang
