Re: Review Request 25716: Type coercion for union queries.

2014-09-19 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25716/
---

(Updated Sept. 19, 2014, 5:55 p.m.)


Review request for hive and John Pullokkaran.


Changes
---

updated per feedback


Bugs: HIVE-8150
https://issues.apache.org/jira/browse/HIVE-8150


Repository: hive-git


Description
---

Type coercion for union queries.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0d934ef 

Diff: https://reviews.apache.org/r/25716/diff/


Testing
---

union32.q


Thanks,

Ashutosh Chauhan



Re: Review Request 25716: Type coercion for union queries.

2014-09-19 Thread John Pullokkaran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25716/#review53979
---

Ship it!


Ship It!

- John Pullokkaran


On Sept. 19, 2014, 5:55 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25716/
 ---
 
 (Updated Sept. 19, 2014, 5:55 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-8150
 https://issues.apache.org/jira/browse/HIVE-8150
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Type coercion for union queries.
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0d934ef 
 
 Diff: https://reviews.apache.org/r/25716/diff/
 
 
 Testing
 ---
 
 union32.q
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Re: Review Request 25716: Type coercion for union queries.

2014-09-18 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25716/
---

(Updated Sept. 18, 2014, 11:11 p.m.)


Review request for hive and John Pullokkaran.


Changes
---

We can make it work by using Hive's type resolution, which is more valid 
anyways instead of using Optiq's type resolution in such cases.


Bugs: HIVE-8150
https://issues.apache.org/jira/browse/HIVE-8150


Repository: hive-git


Description
---

Type coercion for union queries.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 607e6d9 

Diff: https://reviews.apache.org/r/25716/diff/


Testing
---

union32.q


Thanks,

Ashutosh Chauhan



Re: Review Request 25716: Type coercion for union queries.

2014-09-18 Thread John Pullokkaran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25716/#review53905
---


- John Pullokkaran


On Sept. 18, 2014, 11:11 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25716/
 ---
 
 (Updated Sept. 18, 2014, 11:11 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-8150
 https://issues.apache.org/jira/browse/HIVE-8150
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Type coercion for union queries.
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 607e6d9 
 
 Diff: https://reviews.apache.org/r/25716/diff/
 
 
 Testing
 ---
 
 union32.q
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Re: Review Request 25716: Type coercion for union queries.

2014-09-18 Thread John Pullokkaran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25716/#review53907
---


- John Pullokkaran


On Sept. 18, 2014, 11:11 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25716/
 ---
 
 (Updated Sept. 18, 2014, 11:11 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-8150
 https://issues.apache.org/jira/browse/HIVE-8150
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Type coercion for union queries.
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 607e6d9 
 
 Diff: https://reviews.apache.org/r/25716/diff/
 
 
 Testing
 ---
 
 union32.q
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Re: Review Request 25716: Type coercion for union queries.

2014-09-18 Thread John Pullokkaran


 On Sept. 19, 2014, 12:19 a.m., John Pullokkaran wrote:
 

Union RR already has translated type; why not use them instead of translating 
from Optiq type back.


- John


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25716/#review53905
---


On Sept. 18, 2014, 11:11 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25716/
 ---
 
 (Updated Sept. 18, 2014, 11:11 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-8150
 https://issues.apache.org/jira/browse/HIVE-8150
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Type coercion for union queries.
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 607e6d9 
 
 Diff: https://reviews.apache.org/r/25716/diff/
 
 
 Testing
 ---
 
 union32.q
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Re: Review Request 25716: Type coercion for union queries.

2014-09-16 Thread John Pullokkaran

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25716/#review53614
---

Ship it!


Ship It!

- John Pullokkaran


On Sept. 16, 2014, 10:29 p.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/25716/
 ---
 
 (Updated Sept. 16, 2014, 10:29 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-8150
 https://issues.apache.org/jira/browse/HIVE-8150
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Type coercion for union queries.
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 395b5e6 
 
 Diff: https://reviews.apache.org/r/25716/diff/
 
 
 Testing
 ---
 
 union32.q
 
 
 Thanks,
 
 Ashutosh Chauhan