Re: Review Request 64490: HIVE-14498

2018-01-09 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64490/
---

(Updated Jan. 10, 2018, 7:23 a.m.)


Review request for hive, Ashutosh Chauhan and Eugene Koifman.


Bugs: HIVE-14498
https://issues.apache.org/jira/browse/HIVE-14498


Repository: hive-git


Description
---

HIVE-14498


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
6529da661184cd1603e91aa112ac4a9e143a651c 
  data/files/ssb/customer/0_0 PRE-CREATION 
  data/files/ssb/date/0_0 PRE-CREATION 
  data/files/ssb/lineorder/0_0 PRE-CREATION 
  data/files/ssb/part/0_0 PRE-CREATION 
  data/files/ssb/supplier/0_0 PRE-CREATION 
  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 eded92e1c16bd43bb665fd608c5262767c14ef8e 
  itests/hive-unit/src/main/java/org/hadoop/hive/jdbc/SSLTestUtils.java 
6cbcf8ca7cdea8b99736b50b38634c077895f5d8 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
 260c9473748b330399963ff25956e1b576793e33 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
 2bb06d582c0ae2902ab29d7ab8d9e25788389698 
  metastore/scripts/upgrade/derby/048-HIVE-14498.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 
ce25c0217fc6e2d2b51ff2d5ae21b21be560c318 
  metastore/scripts/upgrade/derby/hive-txn-schema-3.0.0.derby.sql 
52713df30c66b34a3d5b815ca2814e7dca1e45a6 
  metastore/scripts/upgrade/derby/upgrade-2.3.0-to-3.0.0.derby.sql 
75b0e73a390d3ab2455cfe07969f77605daf27d7 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 
59bef52b74723fc6ceafc10b7f62abb16c24cfec 
  metastore/scripts/upgrade/mssql/033-HIVE-14498.mssql.sql PRE-CREATION 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 
5ffcdbd3461fb77d91416f95bfb1dca482c258db 
  metastore/scripts/upgrade/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql 
79189bb806a2c42870ebba6f4c13c7c8f1b6b7e4 
  metastore/scripts/upgrade/mysql/048-HIVE-14498.mysql.sql PRE-CREATION 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 
dddf66a817098e488ea4cce0210d7a9e0a96a18c 
  metastore/scripts/upgrade/mysql/hive-txn-schema-3.0.0.mysql.sql 
1df32c4b3548d385e8861b9312042cc25bdf84d7 
  metastore/scripts/upgrade/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 
f38098bdf2ba934615d1ade5e9f311a5061d 
  metastore/scripts/upgrade/oracle/048-HIVE-14498.oracle.sql PRE-CREATION 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 
98a1437f0954955353afaa26d19810a0c7151ccb 
  metastore/scripts/upgrade/oracle/hive-txn-schema-3.0.0.oracle.sql 
12c24a5863e0b8382c643f0404700e0243585db0 
  metastore/scripts/upgrade/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 
8a8f2948618dda7d0e71efd51664926dc6148a4a 
  metastore/scripts/upgrade/postgres/047-HIVE-14498.postgres.sql PRE-CREATION 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
abe724383dff0c67b65ea2659c8f4a22fefcc923 
  metastore/scripts/upgrade/postgres/hive-txn-schema-3.0.0.postgres.sql 
1fa99aff5fcbbb96ed51b9c02850dfabcd6d3d76 
  metastore/scripts/upgrade/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql 
91de88fa73df864e5df34dc5fe61e0ee74cbea2f 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 
6d48783d48581fb96ea1b5ded23ce0d549dc80a6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
cf8386bac557526c162552a0abb068aa0e50469f 
  
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java
 a57e4c888b204388b393bb173e2eac91c867137a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
20d7593d8867e1dfcd43dff99c535119547c238f 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 2b1023a54d163cf0b084916c333cbfe17d6f6a0d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 
0debff669a5d64d87bedd1c11a856cf561e46590 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
28b4cfeaf77a980899bcfa72d6b74abb5704ec42 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
c413bc5126bc2e10d72021c78ca088f3fd221d4a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
5a88a96d72a83e4ce93430f47303ca4e9ed4a096 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
09aa82f1f0c1a90b08669b91615f26fb1f7cd649 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java 
33e30bf10fc048fdbe2bd4a78e5d6d94bd7b04d1 
  ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 
69b076a08a70fcea4f262ccbf9e063733ddd25f2 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 
bbd285d54aeae3073045b2cbbb5ac4c3f6cb6b2b 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite.q 
PRE-CREATION 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite_2.q
 PRE-CREATION 
  ql/src/test/quer

Re: Review Request 64490: HIVE-14498

2018-01-09 Thread Ashutosh Chauhan 


> On Dec. 22, 2017, 11:22 p.m., Ashutosh Chauhan wrote:
> > metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql
> > Lines 9-17 (patched)
> > 
> >
> > Instead of this strategy of backing up and restoring. How about 
> > following sequence:
> > 1. alter table COMPLETED_TXN_COMPONENTS add column CTC_TIMESTAMP 
> > timestamp default CURRENT_TIMETAMP
> > 2. update table COMPLETED_TXN_COMPONENTS where CTC_TIMESTAMP IS NULL 
> > set CTC_TIMETAMP = CURRENT_TIMESTAMP
> > 3. alter table COMPLETE_TXN_COMPONENTS add constraint CTC_TIMESTAMP NOT 
> > NULL
> > 
> > Advantage of this is COMPLETED_TXN_COMPONENTS table is always available.
> > 
> > Same comment applies to upgrade scripts of other DBs as well.
> 
> Jesús Camacho Rodríguez wrote:
> That is a good idea for CTC_TIMESTAMP, but the tricky one is the CTC_ID, 
> which is also a new column. Since it is autoincremented, the only option I 
> saw was to bulk insert from old table into the new one.

Lets delay the rename until data is loaded in that case.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64490/#review194384
---


On Jan. 6, 2018, 3:04 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64490/
> ---
> 
> (Updated Jan. 6, 2018, 3:04 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Eugene Koifman.
> 
> 
> Bugs: HIVE-14498
> https://issues.apache.org/jira/browse/HIVE-14498
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-14498
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1dc7501291691c333ddda741b8f0f461a69a9a65 
>   data/files/ssb/customer/0_0 PRE-CREATION 
>   data/files/ssb/date/0_0 PRE-CREATION 
>   data/files/ssb/lineorder/0_0 PRE-CREATION 
>   data/files/ssb/part/0_0 PRE-CREATION 
>   data/files/ssb/supplier/0_0 PRE-CREATION 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
>  eded92e1c16bd43bb665fd608c5262767c14ef8e 
>   itests/hive-unit/src/main/java/org/hadoop/hive/jdbc/SSLTestUtils.java 
> 6cbcf8ca7cdea8b99736b50b38634c077895f5d8 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
>  260c9473748b330399963ff25956e1b576793e33 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
>  2bb06d582c0ae2902ab29d7ab8d9e25788389698 
>   metastore/scripts/upgrade/derby/047-HIVE-14498.derby.sql PRE-CREATION 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 
> ea75082539d57c1b640a6bfa2bf072dfbd72999e 
>   metastore/scripts/upgrade/derby/hive-txn-schema-3.0.0.derby.sql 
> 52713df30c66b34a3d5b815ca2814e7dca1e45a6 
>   metastore/scripts/upgrade/derby/upgrade-2.3.0-to-3.0.0.derby.sql 
> 1f2647dfbf3263feda9afd98ab6767d7ea3d0557 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 
> 59bef52b74723fc6ceafc10b7f62abb16c24cfec 
>   metastore/scripts/upgrade/mssql/032-HIVE-14498.mssql.sql PRE-CREATION 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 
> 402dfce4dbf7498b14b501cdc813cbf65a4a2153 
>   metastore/scripts/upgrade/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql 
> 864a5e5bd5c06810cab9d2f09d3b968845059a7a 
>   metastore/scripts/upgrade/mysql/047-HIVE-14498.mysql.sql PRE-CREATION 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 
> f7312f037249dd64f5ef6207b2e50a5dea3e3f58 
>   metastore/scripts/upgrade/mysql/hive-txn-schema-3.0.0.mysql.sql 
> 1df32c4b3548d385e8861b9312042cc25bdf84d7 
>   metastore/scripts/upgrade/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 
> caa059d893635e6afadab867760cb035b3a111d4 
>   metastore/scripts/upgrade/oracle/047-HIVE-14498.oracle.sql PRE-CREATION 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 
> 1cfe768ff928af33b1fe61c9717df6c647735038 
>   metastore/scripts/upgrade/oracle/hive-txn-schema-3.0.0.oracle.sql 
> 12c24a5863e0b8382c643f0404700e0243585db0 
>   metastore/scripts/upgrade/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 
> 33174c8a9a9bc768919ddda406324eda05aaf313 
>   metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql PRE-CREATION 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> 2c2d3a14ded8c575c72df628f1d63480bf1ce4de 
>   metastore/scripts/upgrade/postgres/hive-txn-schema-3.0.0.postgres.sql 
> 1fa99aff5fcbbb96ed51b9c02850dfabcd6d3d76 
>   metastore/scripts/upgrade/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql 
> 01d359e5f4c632793ac8e3fb67aa6ea5492dac54 
>   ql/src/java/org/apache/hadoop/hive/ql/Context.java

Re: Review Request 64490: HIVE-14498

2018-01-05 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64490/
---

(Updated Jan. 6, 2018, 3:04 a.m.)


Review request for hive, Ashutosh Chauhan and Eugene Koifman.


Bugs: HIVE-14498
https://issues.apache.org/jira/browse/HIVE-14498


Repository: hive-git


Description
---

HIVE-14498


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
1dc7501291691c333ddda741b8f0f461a69a9a65 
  data/files/ssb/customer/0_0 PRE-CREATION 
  data/files/ssb/date/0_0 PRE-CREATION 
  data/files/ssb/lineorder/0_0 PRE-CREATION 
  data/files/ssb/part/0_0 PRE-CREATION 
  data/files/ssb/supplier/0_0 PRE-CREATION 
  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 eded92e1c16bd43bb665fd608c5262767c14ef8e 
  itests/hive-unit/src/main/java/org/hadoop/hive/jdbc/SSLTestUtils.java 
6cbcf8ca7cdea8b99736b50b38634c077895f5d8 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
 260c9473748b330399963ff25956e1b576793e33 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
 2bb06d582c0ae2902ab29d7ab8d9e25788389698 
  metastore/scripts/upgrade/derby/047-HIVE-14498.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 
ea75082539d57c1b640a6bfa2bf072dfbd72999e 
  metastore/scripts/upgrade/derby/hive-txn-schema-3.0.0.derby.sql 
52713df30c66b34a3d5b815ca2814e7dca1e45a6 
  metastore/scripts/upgrade/derby/upgrade-2.3.0-to-3.0.0.derby.sql 
1f2647dfbf3263feda9afd98ab6767d7ea3d0557 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 
59bef52b74723fc6ceafc10b7f62abb16c24cfec 
  metastore/scripts/upgrade/mssql/032-HIVE-14498.mssql.sql PRE-CREATION 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 
402dfce4dbf7498b14b501cdc813cbf65a4a2153 
  metastore/scripts/upgrade/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql 
864a5e5bd5c06810cab9d2f09d3b968845059a7a 
  metastore/scripts/upgrade/mysql/047-HIVE-14498.mysql.sql PRE-CREATION 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 
f7312f037249dd64f5ef6207b2e50a5dea3e3f58 
  metastore/scripts/upgrade/mysql/hive-txn-schema-3.0.0.mysql.sql 
1df32c4b3548d385e8861b9312042cc25bdf84d7 
  metastore/scripts/upgrade/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 
caa059d893635e6afadab867760cb035b3a111d4 
  metastore/scripts/upgrade/oracle/047-HIVE-14498.oracle.sql PRE-CREATION 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 
1cfe768ff928af33b1fe61c9717df6c647735038 
  metastore/scripts/upgrade/oracle/hive-txn-schema-3.0.0.oracle.sql 
12c24a5863e0b8382c643f0404700e0243585db0 
  metastore/scripts/upgrade/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 
33174c8a9a9bc768919ddda406324eda05aaf313 
  metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql PRE-CREATION 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
2c2d3a14ded8c575c72df628f1d63480bf1ce4de 
  metastore/scripts/upgrade/postgres/hive-txn-schema-3.0.0.postgres.sql 
1fa99aff5fcbbb96ed51b9c02850dfabcd6d3d76 
  metastore/scripts/upgrade/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql 
01d359e5f4c632793ac8e3fb67aa6ea5492dac54 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 
6d48783d48581fb96ea1b5ded23ce0d549dc80a6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
cf8386bac557526c162552a0abb068aa0e50469f 
  
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java
 a57e4c888b204388b393bb173e2eac91c867137a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
20d7593d8867e1dfcd43dff99c535119547c238f 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 2b1023a54d163cf0b084916c333cbfe17d6f6a0d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 
0debff669a5d64d87bedd1c11a856cf561e46590 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
28b4cfeaf77a980899bcfa72d6b74abb5704ec42 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
c413bc5126bc2e10d72021c78ca088f3fd221d4a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
5a88a96d72a83e4ce93430f47303ca4e9ed4a096 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
09aa82f1f0c1a90b08669b91615f26fb1f7cd649 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java 
33e30bf10fc048fdbe2bd4a78e5d6d94bd7b04d1 
  ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 
69b076a08a70fcea4f262ccbf9e063733ddd25f2 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 
bbd285d54aeae3073045b2cbbb5ac4c3f6cb6b2b 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite.q 
PRE-CREATION 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite_2.q
 PRE-CREATION 
  ql/src/test/queri

Re: Review Request 64490: HIVE-14498

2018-01-04 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64490/
---

(Updated Jan. 5, 2018, 12:47 a.m.)


Review request for hive, Ashutosh Chauhan and Eugene Koifman.


Bugs: HIVE-14498
https://issues.apache.org/jira/browse/HIVE-14498


Repository: hive-git


Description
---

HIVE-14498


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
841d0753d8d748a06b63c505eff8e8c727cb1c08 
  data/files/ssb/customer/0_0 PRE-CREATION 
  data/files/ssb/date/0_0 PRE-CREATION 
  data/files/ssb/lineorder/0_0 PRE-CREATION 
  data/files/ssb/part/0_0 PRE-CREATION 
  data/files/ssb/supplier/0_0 PRE-CREATION 
  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 6dc052db45e4705efe0cf502614c6eeaac8e9b10 
  itests/hive-unit/src/main/java/org/hadoop/hive/jdbc/SSLTestUtils.java 
6cbcf8ca7cdea8b99736b50b38634c077895f5d8 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
 260c9473748b330399963ff25956e1b576793e33 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
 2bb06d582c0ae2902ab29d7ab8d9e25788389698 
  metastore/scripts/upgrade/derby/047-HIVE-14498.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 
ea75082539d57c1b640a6bfa2bf072dfbd72999e 
  metastore/scripts/upgrade/derby/hive-txn-schema-3.0.0.derby.sql 
52713df30c66b34a3d5b815ca2814e7dca1e45a6 
  metastore/scripts/upgrade/derby/upgrade-2.3.0-to-3.0.0.derby.sql 
1f2647dfbf3263feda9afd98ab6767d7ea3d0557 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 
59bef52b74723fc6ceafc10b7f62abb16c24cfec 
  metastore/scripts/upgrade/mssql/032-HIVE-14498.mssql.sql PRE-CREATION 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 
402dfce4dbf7498b14b501cdc813cbf65a4a2153 
  metastore/scripts/upgrade/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql 
864a5e5bd5c06810cab9d2f09d3b968845059a7a 
  metastore/scripts/upgrade/mysql/047-HIVE-14498.mysql.sql PRE-CREATION 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 
f7312f037249dd64f5ef6207b2e50a5dea3e3f58 
  metastore/scripts/upgrade/mysql/hive-txn-schema-3.0.0.mysql.sql 
1df32c4b3548d385e8861b9312042cc25bdf84d7 
  metastore/scripts/upgrade/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 
caa059d893635e6afadab867760cb035b3a111d4 
  metastore/scripts/upgrade/oracle/047-HIVE-14498.oracle.sql PRE-CREATION 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 
1cfe768ff928af33b1fe61c9717df6c647735038 
  metastore/scripts/upgrade/oracle/hive-txn-schema-3.0.0.oracle.sql 
12c24a5863e0b8382c643f0404700e0243585db0 
  metastore/scripts/upgrade/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 
33174c8a9a9bc768919ddda406324eda05aaf313 
  metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql PRE-CREATION 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
2c2d3a14ded8c575c72df628f1d63480bf1ce4de 
  metastore/scripts/upgrade/postgres/hive-txn-schema-3.0.0.postgres.sql 
1fa99aff5fcbbb96ed51b9c02850dfabcd6d3d76 
  metastore/scripts/upgrade/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql 
01d359e5f4c632793ac8e3fb67aa6ea5492dac54 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 
6d48783d48581fb96ea1b5ded23ce0d549dc80a6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
b947ab1cb4f733a81c5c8c961ad580511cbbe2c5 
  
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java
 a57e4c888b204388b393bb173e2eac91c867137a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
022ba04fbe981848fc28a8521fe00f0fe2519025 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 2b1023a54d163cf0b084916c333cbfe17d6f6a0d 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 
0debff669a5d64d87bedd1c11a856cf561e46590 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
28b4cfeaf77a980899bcfa72d6b74abb5704ec42 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
a092d3d87896f6f2efc56ad01a90f6d954e5d10b 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
5a88a96d72a83e4ce93430f47303ca4e9ed4a096 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
09aa82f1f0c1a90b08669b91615f26fb1f7cd649 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java 
33e30bf10fc048fdbe2bd4a78e5d6d94bd7b04d1 
  ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 
69b076a08a70fcea4f262ccbf9e063733ddd25f2 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 
bbd285d54aeae3073045b2cbbb5ac4c3f6cb6b2b 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite.q 
PRE-CREATION 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite_2.q
 PRE-CREATION 
  ql/src/test/quer

Re: Review Request 64490: HIVE-14498

2018-01-04 Thread Jesús Camacho Rodríguez 


> On Dec. 22, 2017, 11:22 p.m., Ashutosh Chauhan wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Lines 1140 (patched)
> > 
> >
> > I think non 0 default will better suit users. Almost all DB systems 
> > have notion of staleness for materialized views, so users are aware that 
> > creating a materialized view may get them stale result set. So, we might as 
> > well give them perf benefits. 
> > Although, I am not sure what value shall we pick :) 
> > 24 hours?

I have doubts about this one... Multiple databases also do eager maintenance 
and keep MVs up-to-date by default, e.g., when an update happens on the table, 
the change is propagated automatically to the MV.

I think setting this value to other than zero by default, might create some 
confusion as user might start getting incorrect results (I am not even thinking 
about the typical BI case, but maybe even for ETL queries?). Since user will 
have to do some configuration to set up the rebuild of the MVs, i.e., setup a 
cron job that is executed for instance every evening, I would suggest we keep 
this as zero and in the documentation we describe the kind of configuration 
that needs to be done so MVs can always be used with a guarantee that they will 
be outdated by a maximum time window. What do you think?


> On Dec. 22, 2017, 11:22 p.m., Ashutosh Chauhan wrote:
> > metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql
> > Lines 9-17 (patched)
> > 
> >
> > Instead of this strategy of backing up and restoring. How about 
> > following sequence:
> > 1. alter table COMPLETED_TXN_COMPONENTS add column CTC_TIMESTAMP 
> > timestamp default CURRENT_TIMETAMP
> > 2. update table COMPLETED_TXN_COMPONENTS where CTC_TIMESTAMP IS NULL 
> > set CTC_TIMETAMP = CURRENT_TIMESTAMP
> > 3. alter table COMPLETE_TXN_COMPONENTS add constraint CTC_TIMESTAMP NOT 
> > NULL
> > 
> > Advantage of this is COMPLETED_TXN_COMPONENTS table is always available.
> > 
> > Same comment applies to upgrade scripts of other DBs as well.

That is a good idea for CTC_TIMESTAMP, but the tricky one is the CTC_ID, which 
is also a new column. Since it is autoincremented, the only option I saw was to 
bulk insert from old table into the new one.


> On Dec. 22, 2017, 11:22 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
> > Lines 5154 (patched)
> > 
> >
> > We can make metastore call outside of for loop to get all info in a 
> > single call.

I have changed the code to create a single call (observe that _names[0], 
names[1]_ was derived from _fullyQualifiedName_, thus now we need a second 
loop).


> On Dec. 22, 2017, 11:22 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java
> > Lines 80 (patched)
> > 
> >
> > Do we need to make a metastore call to determine if rewrite is enabled 
> > or not? I would assume createViewDesc() will contain that info.

For the createMV, you need it because of the interaction with stats info, which 
might be updated by the Stats task and hence the createViewDesc-based Table 
might be outdated (that is why the code was moved originally here).
For the alterMV, if you are enabling rewriting, you need it because you will 
add it to the cache and you do not have the Table object from the metastore.
For the alterMV, if you are disabling rewriting, you do not need the table 
object from metastore, thus I have changed it accordingly.


> On Dec. 22, 2017, 11:22 p.m., Ashutosh Chauhan wrote:
> > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationInvalidationInfo.java
> > Lines 56 (patched)
> > 
> >
> > You may get rid of this method altogether.

This is to prevent any undesired usage of method _setInvalidationTime_ in the 
future, since it should not be used when we have a 
_MaterializationInvalidationInfo_ instance (bad things could happen).


> On Dec. 22, 2017, 11:22 p.m., Ashutosh Chauhan wrote:
> > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java
> > Lines 104 (patched)
> > 
> >
> > Is intention here to load mvs from different dbs in parallel in 
> > different threads? Or just to load all MVs sequentially in a different 
> > thread.
> > Seems like 1st one would be better, but seems like thats not happening 
> > here.

It is the second. We load the invalidation info async so we do not block 
bringing up the metastore. While invalida

Re: Review Request 64490: HIVE-14498

2017-12-22 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64490/#review194384
---




common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 1140 (patched)


I think non 0 default will better suit users. Almost all DB systems have 
notion of staleness for materialized views, so users are aware that creating a 
materialized view may get them stale result set. So, we might as well give them 
perf benefits. 
Although, I am not sure what value shall we pick :) 
24 hours?



metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql
Lines 9-17 (patched)


Instead of this strategy of backing up and restoring. How about following 
sequence:
1. alter table COMPLETED_TXN_COMPONENTS add column CTC_TIMESTAMP timestamp 
default CURRENT_TIMETAMP
2. update table COMPLETED_TXN_COMPONENTS where CTC_TIMESTAMP IS NULL set 
CTC_TIMETAMP = CURRENT_TIMESTAMP
3. alter table COMPLETE_TXN_COMPONENTS add constraint CTC_TIMESTAMP NOT NULL

Advantage of this is COMPLETED_TXN_COMPONENTS table is always available.

Same comment applies to upgrade scripts of other DBs as well.



ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
Lines 5154 (patched)


We can make metastore call outside of for loop to get all info in a single 
call.



ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java
Lines 80 (patched)


Do we need to make a metastore call to determine if rewrite is enabled or 
not? I would assume createViewDesc() will contain that info.



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Line 1535 (original), 1552 (patched)


Better name: getValidMaterializedViews() ?



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Line 1557 (original), 1573 (patched)


LOG.debug()



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Lines 1588 (patched)


LOG.debug()



ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Lines 1624 (patched)


LOG.info()



ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
Lines 377 (patched)


comments:
create //view just created
load // already created view being loaded



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationInvalidationInfo.java
Lines 56 (patched)


You may get rid of this method altogether.



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java
Lines 104 (patched)


Is intention here to load mvs from different dbs in parallel in different 
threads? Or just to load all MVs sequentially in a different thread.
Seems like 1st one would be better, but seems like thats not happening here.



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java
Lines 198 (patched)


LOG.debug()



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java
Lines 267 (patched)


debug



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MaterializationsInvalidationCache.java
Lines 291 (patched)


ws



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 1384-1388 (patched)


Better to do directsql here.



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 1910 (patched)


json is verbose protocol. Since length of this field is not limited, we 
shall pick some compact protocol.



standalone-metastore/src/main/thrift/hive_metastore.thrift
Lines 859 (patched)


Can eliminate Basic from name.



standalone-metastore/src/main/thrift/hive_metastore.thrift
Lines 1380 (patched)


Better name: get_materialized_views()



standalone-metastore/src/main/thrift/hive_metastore.thrift
Lines 1789 (patched)


This call is made

Re: Review Request 64490: HIVE-14498

2017-12-15 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64490/
---

(Updated Dec. 16, 2017, 2:19 a.m.)


Review request for hive, Ashutosh Chauhan and Eugene Koifman.


Bugs: HIVE-14498
https://issues.apache.org/jira/browse/HIVE-14498


Repository: hive-git


Description
---

HIVE-14498


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
711dfbdc1f05a25ffc64d297c6b1b25853d99a57 
  data/files/ssb/customer/0_0 PRE-CREATION 
  data/files/ssb/date/0_0 PRE-CREATION 
  data/files/ssb/lineorder/0_0 PRE-CREATION 
  data/files/ssb/part/0_0 PRE-CREATION 
  data/files/ssb/supplier/0_0 PRE-CREATION 
  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 62c9172ef5d9ae74b158d1b4f1b8c5c0eca4e375 
  itests/hive-unit/src/main/java/org/hadoop/hive/jdbc/SSLTestUtils.java 
6cbcf8ca7cdea8b99736b50b38634c077895f5d8 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestMetaStoreEventListener.java
 e8031066c2dc9b1b40be570e9098ac0c55d997be 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
 55acd1df3697f1742c826f1cd9648634811b915f 
  metastore/scripts/upgrade/derby/047-HIVE-14498.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 
f93d0d1d127156732a523fb45c3c2635d3ee530e 
  metastore/scripts/upgrade/derby/hive-txn-schema-3.0.0.derby.sql 
52713df30c66b34a3d5b815ca2814e7dca1e45a6 
  metastore/scripts/upgrade/derby/upgrade-2.3.0-to-3.0.0.derby.sql 
1f2647dfbf3263feda9afd98ab6767d7ea3d0557 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 
75891017584f93f94c55abcae10c512ad6bcb525 
  metastore/scripts/upgrade/mssql/032-HIVE-14498.mssql.sql PRE-CREATION 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 
26c82af74c58cb097df8fa4d36a3b641602e1047 
  metastore/scripts/upgrade/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql 
864a5e5bd5c06810cab9d2f09d3b968845059a7a 
  metastore/scripts/upgrade/mysql/047-HIVE-14498.mysql.sql PRE-CREATION 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 
915af8bf4bb7864371f5b9ba8bfb8a71a064ec36 
  metastore/scripts/upgrade/mysql/hive-txn-schema-3.0.0.mysql.sql 
1df32c4b3548d385e8861b9312042cc25bdf84d7 
  metastore/scripts/upgrade/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 
caa059d893635e6afadab867760cb035b3a111d4 
  metastore/scripts/upgrade/oracle/047-HIVE-14498.oracle.sql PRE-CREATION 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 
65c72af87343d84fe6eb894c503bebfe54fe4618 
  metastore/scripts/upgrade/oracle/hive-txn-schema-3.0.0.oracle.sql 
12c24a5863e0b8382c643f0404700e0243585db0 
  metastore/scripts/upgrade/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 
33174c8a9a9bc768919ddda406324eda05aaf313 
  metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql PRE-CREATION 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
415b5e0189bee95a104e3e3d9cd5f25187260a5b 
  metastore/scripts/upgrade/postgres/hive-txn-schema-3.0.0.postgres.sql 
1fa99aff5fcbbb96ed51b9c02850dfabcd6d3d76 
  metastore/scripts/upgrade/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql 
01d359e5f4c632793ac8e3fb67aa6ea5492dac54 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 
6d48783d48581fb96ea1b5ded23ce0d549dc80a6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
55ef8de9a5c7144931d0a6ff13224765ee737fea 
  
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java
 a57e4c888b204388b393bb173e2eac91c867137a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
50bdce89a44a8dc87a97e394d00e5dadebbbd351 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 f8825a27caa1391c59ac7389fbc77af6590cc9bb 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 
0debff669a5d64d87bedd1c11a856cf561e46590 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
efd5f7af151b72dacd620ad6ce94a3a2f5885906 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
a09b7961c2dbc26b4d2fa912d0be7037885f63e4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
28e3621d3264f4f704da0d775b396f7b7764fdb6 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
09aa82f1f0c1a90b08669b91615f26fb1f7cd649 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java 
33e30bf10fc048fdbe2bd4a78e5d6d94bd7b04d1 
  ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 
69b076a08a70fcea4f262ccbf9e063733ddd25f2 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 
bbd285d54aeae3073045b2cbbb5ac4c3f6cb6b2b 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite.q 
PRE-CREATION 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite_2.q
 PRE-CREATION 
  ql/src/test/quer

Re: Review Request 64490: HIVE-14498

2017-12-14 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64490/
---

(Updated Dec. 15, 2017, 7:18 a.m.)


Review request for hive, Ashutosh Chauhan and Eugene Koifman.


Bugs: HIVE-14498
https://issues.apache.org/jira/browse/HIVE-14498


Repository: hive-git


Description
---

HIVE-14498


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
711dfbdc1f05a25ffc64d297c6b1b25853d99a57 
  data/files/ssb/customer/0_0 PRE-CREATION 
  data/files/ssb/date/0_0 PRE-CREATION 
  data/files/ssb/lineorder/0_0 PRE-CREATION 
  data/files/ssb/part/0_0 PRE-CREATION 
  data/files/ssb/supplier/0_0 PRE-CREATION 
  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 62c9172ef5d9ae74b158d1b4f1b8c5c0eca4e375 
  
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenarios.java
 55acd1df3697f1742c826f1cd9648634811b915f 
  metastore/scripts/upgrade/derby/047-HIVE-14498.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 
f93d0d1d127156732a523fb45c3c2635d3ee530e 
  metastore/scripts/upgrade/derby/hive-txn-schema-3.0.0.derby.sql 
52713df30c66b34a3d5b815ca2814e7dca1e45a6 
  metastore/scripts/upgrade/derby/upgrade-2.3.0-to-3.0.0.derby.sql 
1f2647dfbf3263feda9afd98ab6767d7ea3d0557 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 
75891017584f93f94c55abcae10c512ad6bcb525 
  metastore/scripts/upgrade/mssql/032-HIVE-14498.mssql.sql PRE-CREATION 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 
26c82af74c58cb097df8fa4d36a3b641602e1047 
  metastore/scripts/upgrade/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql 
864a5e5bd5c06810cab9d2f09d3b968845059a7a 
  metastore/scripts/upgrade/mysql/047-HIVE-14498.mysql.sql PRE-CREATION 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 
915af8bf4bb7864371f5b9ba8bfb8a71a064ec36 
  metastore/scripts/upgrade/mysql/hive-txn-schema-3.0.0.mysql.sql 
1df32c4b3548d385e8861b9312042cc25bdf84d7 
  metastore/scripts/upgrade/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 
caa059d893635e6afadab867760cb035b3a111d4 
  metastore/scripts/upgrade/oracle/047-HIVE-14498.oracle.sql PRE-CREATION 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 
65c72af87343d84fe6eb894c503bebfe54fe4618 
  metastore/scripts/upgrade/oracle/hive-txn-schema-3.0.0.oracle.sql 
12c24a5863e0b8382c643f0404700e0243585db0 
  metastore/scripts/upgrade/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 
33174c8a9a9bc768919ddda406324eda05aaf313 
  metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql PRE-CREATION 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
415b5e0189bee95a104e3e3d9cd5f25187260a5b 
  metastore/scripts/upgrade/postgres/hive-txn-schema-3.0.0.postgres.sql 
1fa99aff5fcbbb96ed51b9c02850dfabcd6d3d76 
  metastore/scripts/upgrade/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql 
01d359e5f4c632793ac8e3fb67aa6ea5492dac54 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 
6d48783d48581fb96ea1b5ded23ce0d549dc80a6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
55ef8de9a5c7144931d0a6ff13224765ee737fea 
  
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java
 a57e4c888b204388b393bb173e2eac91c867137a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
50bdce89a44a8dc87a97e394d00e5dadebbbd351 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 f8825a27caa1391c59ac7389fbc77af6590cc9bb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
efd5f7af151b72dacd620ad6ce94a3a2f5885906 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
a09b7961c2dbc26b4d2fa912d0be7037885f63e4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
28e3621d3264f4f704da0d775b396f7b7764fdb6 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
09aa82f1f0c1a90b08669b91615f26fb1f7cd649 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ImportTableDesc.java 
33e30bf10fc048fdbe2bd4a78e5d6d94bd7b04d1 
  ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 
69b076a08a70fcea4f262ccbf9e063733ddd25f2 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite.q 
PRE-CREATION 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite_2.q
 PRE-CREATION 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q 
761903fd583cbe8fce003990b8d2e9534e126f2f 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_2.q 
9983bae7a1f4a478b10e85b18163d34be3ded3b8 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_3.q 
6462d9a677e9662c60455a79aa8ef522cba5fe65 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q 
PRE-CREATION 
  
ql/src/test/queries/clientpositive/material

Re: Review Request 64490: HIVE-14498

2017-12-13 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64490/
---

(Updated Dec. 13, 2017, 5:23 p.m.)


Review request for hive, Ashutosh Chauhan and Eugene Koifman.


Bugs: HIVE-14498
https://issues.apache.org/jira/browse/HIVE-14498


Repository: hive-git


Description
---

HIVE-14498


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
7a81612faaa324ad9650d161c4864557e5088fa7 
  data/files/ssb/customer/0_0 PRE-CREATION 
  data/files/ssb/date/0_0 PRE-CREATION 
  data/files/ssb/lineorder/0_0 PRE-CREATION 
  data/files/ssb/part/0_0 PRE-CREATION 
  data/files/ssb/supplier/0_0 PRE-CREATION 
  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 62c9172ef5d9ae74b158d1b4f1b8c5c0eca4e375 
  metastore/scripts/upgrade/derby/047-HIVE-14498.derby.sql PRE-CREATION 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 
f93d0d1d127156732a523fb45c3c2635d3ee530e 
  metastore/scripts/upgrade/derby/hive-txn-schema-3.0.0.derby.sql 
52713df30c66b34a3d5b815ca2814e7dca1e45a6 
  metastore/scripts/upgrade/derby/upgrade-2.3.0-to-3.0.0.derby.sql 
1f2647dfbf3263feda9afd98ab6767d7ea3d0557 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql 
75891017584f93f94c55abcae10c512ad6bcb525 
  metastore/scripts/upgrade/mssql/032-HIVE-14498.mssql.sql PRE-CREATION 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 
26c82af74c58cb097df8fa4d36a3b641602e1047 
  metastore/scripts/upgrade/mssql/upgrade-2.3.0-to-3.0.0.mssql.sql 
864a5e5bd5c06810cab9d2f09d3b968845059a7a 
  metastore/scripts/upgrade/mysql/047-HIVE-14498.mysql.sql PRE-CREATION 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 
915af8bf4bb7864371f5b9ba8bfb8a71a064ec36 
  metastore/scripts/upgrade/mysql/hive-txn-schema-3.0.0.mysql.sql 
1df32c4b3548d385e8861b9312042cc25bdf84d7 
  metastore/scripts/upgrade/mysql/upgrade-2.3.0-to-3.0.0.mysql.sql 
caa059d893635e6afadab867760cb035b3a111d4 
  metastore/scripts/upgrade/oracle/047-HIVE-14498.oracle.sql PRE-CREATION 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 
65c72af87343d84fe6eb894c503bebfe54fe4618 
  metastore/scripts/upgrade/oracle/hive-txn-schema-3.0.0.oracle.sql 
12c24a5863e0b8382c643f0404700e0243585db0 
  metastore/scripts/upgrade/oracle/upgrade-2.3.0-to-3.0.0.oracle.sql 
33174c8a9a9bc768919ddda406324eda05aaf313 
  metastore/scripts/upgrade/postgres/046-HIVE-14498.postgres.sql PRE-CREATION 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
415b5e0189bee95a104e3e3d9cd5f25187260a5b 
  metastore/scripts/upgrade/postgres/hive-txn-schema-3.0.0.postgres.sql 
1fa99aff5fcbbb96ed51b9c02850dfabcd6d3d76 
  metastore/scripts/upgrade/postgres/upgrade-2.3.0-to-3.0.0.postgres.sql 
01d359e5f4c632793ac8e3fb67aa6ea5492dac54 
  ql/src/java/org/apache/hadoop/hive/ql/Context.java 
6d48783d48581fb96ea1b5ded23ce0d549dc80a6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 
55ef8de9a5c7144931d0a6ff13224765ee737fea 
  
ql/src/java/org/apache/hadoop/hive/ql/hooks/MaterializedViewRegistryUpdateHook.java
 a57e4c888b204388b393bb173e2eac91c867137a 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 
50bdce89a44a8dc87a97e394d00e5dadebbbd351 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java
 f8825a27caa1391c59ac7389fbc77af6590cc9bb 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
20386f14800f72fda08286cbfff050831c49bb07 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
a09b7961c2dbc26b4d2fa912d0be7037885f63e4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
28e3621d3264f4f704da0d775b396f7b7764fdb6 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
09aa82f1f0c1a90b08669b91615f26fb1f7cd649 
  ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java 
69b076a08a70fcea4f262ccbf9e063733ddd25f2 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite.q 
PRE-CREATION 
  
ql/src/test/queries/clientnegative/materialized_view_no_transactional_rewrite_2.q
 PRE-CREATION 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q 
761903fd583cbe8fce003990b8d2e9534e126f2f 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_2.q 
9983bae7a1f4a478b10e85b18163d34be3ded3b8 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_3.q 
6462d9a677e9662c60455a79aa8ef522cba5fe65 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q 
PRE-CREATION 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_multi_db.q 
e4cdc22e3b287bdfbfd05713ba9c6b851dcc3097 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_ssb.q 
00da517424445022ad1f7e624fbba18943801726 
  ql/src/test/queries/clientpositive/materialized_view_re