Re: Review Request: HIVE-2155 Improve error messages emitted during semantic analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/731/#review674 --- ql/src/test/results/clientnegative/clusterbydistributeby.q.out https://reviews.apache.org/r/731/#comment1344 * ql/src/test/results/clientnegative/clusterbysortby.q.out https://reviews.apache.org/r/731/#comment1343 * ql/src/test/results/clientnegative/fileformat_void_input.q.out https://reviews.apache.org/r/731/#comment1342 * ql/src/test/results/clientnegative/line_terminator.q.out https://reviews.apache.org/r/731/#comment1345 * ql/src/test/results/clientnegative/orderbysortby.q.out https://reviews.apache.org/r/731/#comment1346 * ql/src/test/results/clientnegative/strict_orderby.q.out https://reviews.apache.org/r/731/#comment1347 * ql/src/test/results/compiler/errors/invalid_list_index.q.out https://reviews.apache.org/r/731/#comment1348 * ql/src/test/results/compiler/errors/invalid_map_index.q.out https://reviews.apache.org/r/731/#comment1349 * ql/src/test/results/compiler/errors/nonkey_groupby.q.out https://reviews.apache.org/r/731/#comment1350 This is still incredibly fugly. ql/src/test/results/compiler/errors/wrong_distinct1.q.out https://reviews.apache.org/r/731/#comment1351 * - John On 2011-05-14 01:05:47, Syed Albiz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/731/ --- (Updated 2011-05-14 01:05:47) Review request for hive and John Sichi. Summary --- Attaches line/column number to the vast majority of SemanticExceptions thrown. In addition, the context strings for the error messages relating to UNION ALLs and GROUP BY keys have been changed to provide more meaningful context. This addresses bug HIVE-2155. https://issues.apache.org/jira/browse/HIVE-2155 Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd ql/src/test/queries/clientnegative/union3.q PRE-CREATION ql/src/test/results/clientnegative/analyze_view.q.out ef76106 ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 ql/src/test/results/clientnegative/clustern3.q.out da71016 ql/src/test/results/clientnegative/clustern4.q.out 1519e48 ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a ql/src/test/results/clientnegative/ctas.q.out a39fb7c ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c ql/src/test/results/clientnegative/dyn_part_merge.q.out cab97f7 ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 ql/src/test/results/clientnegative/input1.q.out 73f1657 ql/src/test/results/clientnegative/input2.q.out 0c460a6 ql/src/test/results/clientnegative/invalid_create_tbl1.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_alter1.q.out f7ae626 ql/src/test/results/clientnegative/invalid_t_alter2.q.out f7ae626 ql/src/test/results/clientnegative/invalid_t_create1.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_create2.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_create3.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_transform.q.out d091d8c ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 ql/src/test/results/clientnegative/joinneg.q.out d85d508 ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 ql/src/test/results/clientnegative/load_part_nospec.q.out 251c7e1 ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 ql/src/test/results/clientnegative/nopart_load.q.out 31376c8 ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 ql/src/test/results/clientnegative/regex_col_2.q.out f570010 ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 ql/src/test/results/clientnegative/semijoin1.q.out 739931f ql/src/test/results/clientnegative/semijoin2.q.out
Re: Review Request: HIVE-2155 Improve error messages emitted during semantic analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/731/ --- (Updated 2011-05-16 19:59:08.608664) Review request for hive and John Sichi. Changes --- Updated more existing testcases to use new generateErrorMessage function to display the Error encounted near token string. Regenerated the TestParseNegative testcases as those were not updated in the last patch. Summary --- Attaches line/column number to the vast majority of SemanticExceptions thrown. In addition, the context strings for the error messages relating to UNION ALLs and GROUP BY keys have been changed to provide more meaningful context. This addresses bug HIVE-2155. https://issues.apache.org/jira/browse/HIVE-2155 Diffs (updated) - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd ql/src/test/queries/clientnegative/union3.q PRE-CREATION ql/src/test/results/clientnegative/analyze_view.q.out ef76106 ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 ql/src/test/results/clientnegative/clustern3.q.out da71016 ql/src/test/results/clientnegative/clustern4.q.out 1519e48 ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a ql/src/test/results/clientnegative/ctas.q.out a39fb7c ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c ql/src/test/results/clientnegative/dyn_part_merge.q.out cab97f7 ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 ql/src/test/results/clientnegative/input1.q.out 73f1657 ql/src/test/results/clientnegative/input2.q.out 0c460a6 ql/src/test/results/clientnegative/invalid_create_tbl1.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_alter1.q.out f7ae626 ql/src/test/results/clientnegative/invalid_t_alter2.q.out f7ae626 ql/src/test/results/clientnegative/invalid_t_create1.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_create2.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_create3.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_transform.q.out d091d8c ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 ql/src/test/results/clientnegative/joinneg.q.out d85d508 ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 ql/src/test/results/clientnegative/load_part_nospec.q.out 251c7e1 ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 ql/src/test/results/clientnegative/nopart_load.q.out 31376c8 ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 ql/src/test/results/clientnegative/regex_col_2.q.out f570010 ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 ql/src/test/results/clientnegative/semijoin1.q.out 739931f ql/src/test/results/clientnegative/semijoin2.q.out 2b418de ql/src/test/results/clientnegative/semijoin3.q.out a803b50 ql/src/test/results/clientnegative/semijoin4.q.out 86a834b ql/src/test/results/clientnegative/split_sample_out_of_range.q.out 0761955 ql/src/test/results/clientnegative/split_sample_wrong_format.q.out 19b1417 ql/src/test/results/clientnegative/strict_orderby.q.out 2d3ba6b ql/src/test/results/clientnegative/subq_insert.q.out 8c3ce79 ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out d6b98b4 ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 7b8dca6 ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 75b9638 ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 126fa4e ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd62771 ql/src/test/results/clientnegative/udf_coalesce.q.out a5279f5 ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out 22a085a ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out fc83f23 ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 3bf97d9 ql/src/test/results/clientnegative/udf_field_wrong_type.q.out 2a2e944 ql/src/test/results/clientnegative/udf_if_not_bool.q.out a3c8902
Re: Review Request: HIVE-2155 Improve error messages emitted during semantic analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/731/ --- (Updated 2011-05-14 01:05:47.070322) Review request for hive and John Sichi. Changes --- Made the following changes: - Updated existing error messages to use the 'Error encountered near token' format - Added the period to the error message - Fixed the generation of GROUP BY context string to be less fugly (generate the context string off the AST token one level below the top of the stack that contains the invalid column reference instead of the table alias. Summary --- Attaches line/column number to the vast majority of SemanticExceptions thrown. In addition, the context strings for the error messages relating to UNION ALLs and GROUP BY keys have been changed to provide more meaningful context. This addresses bug HIVE-2155. https://issues.apache.org/jira/browse/HIVE-2155 Diffs (updated) - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd ql/src/test/queries/clientnegative/union3.q PRE-CREATION ql/src/test/results/clientnegative/analyze_view.q.out ef76106 ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 ql/src/test/results/clientnegative/clustern3.q.out da71016 ql/src/test/results/clientnegative/clustern4.q.out 1519e48 ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a ql/src/test/results/clientnegative/ctas.q.out a39fb7c ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c ql/src/test/results/clientnegative/dyn_part_merge.q.out cab97f7 ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 ql/src/test/results/clientnegative/input1.q.out 73f1657 ql/src/test/results/clientnegative/input2.q.out 0c460a6 ql/src/test/results/clientnegative/invalid_create_tbl1.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_alter1.q.out f7ae626 ql/src/test/results/clientnegative/invalid_t_alter2.q.out f7ae626 ql/src/test/results/clientnegative/invalid_t_create1.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_create2.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_create3.q.out d091d8c ql/src/test/results/clientnegative/invalid_t_transform.q.out d091d8c ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 ql/src/test/results/clientnegative/joinneg.q.out d85d508 ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 ql/src/test/results/clientnegative/load_part_nospec.q.out 251c7e1 ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 ql/src/test/results/clientnegative/nopart_load.q.out 31376c8 ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 ql/src/test/results/clientnegative/regex_col_2.q.out f570010 ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 ql/src/test/results/clientnegative/semijoin1.q.out 739931f ql/src/test/results/clientnegative/semijoin2.q.out 2b418de ql/src/test/results/clientnegative/semijoin3.q.out a803b50 ql/src/test/results/clientnegative/semijoin4.q.out 86a834b ql/src/test/results/clientnegative/split_sample_out_of_range.q.out 0761955 ql/src/test/results/clientnegative/split_sample_wrong_format.q.out 19b1417 ql/src/test/results/clientnegative/strict_orderby.q.out 2d3ba6b ql/src/test/results/clientnegative/subq_insert.q.out 8c3ce79 ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out d6b98b4 ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 7b8dca6 ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 75b9638 ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 126fa4e ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd62771 ql/src/test/results/clientnegative/udf_coalesce.q.out a5279f5 ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out 22a085a ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out fc83f23 ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 3bf97d9
Re: Review Request: HIVE-2155 Improve error messages emitted during semantic analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/731/#review669 --- ql/src/test/results/clientnegative/create_view_failure3.q.out https://reviews.apache.org/r/731/#comment1333 This is an example where an existing error should have been using the new Error encountered You can either take care of these now, or open a followup for that. ql/src/test/results/clientnegative/ddltime.q.out https://reviews.apache.org/r/731/#comment1332 Need a period before Error encountered That's true in general;. ql/src/test/results/clientnegative/groupby_key.q.out https://reviews.apache.org/r/731/#comment1331 This is kinda ugly... - John On 2011-05-12 23:44:48, Syed Albiz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/731/ --- (Updated 2011-05-12 23:44:48) Review request for hive and John Sichi. Summary --- Attaches line/column number to the vast majority of SemanticExceptions thrown. In addition, the context strings for the error messages relating to UNION ALLs and GROUP BY keys have been changed to provide more meaningful context. This addresses bug HIVE-2155. https://issues.apache.org/jira/browse/HIVE-2155 Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd ql/src/test/queries/clientnegative/union3.q PRE-CREATION ql/src/test/results/clientnegative/analyze_view.q.out ef76106 ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 ql/src/test/results/clientnegative/clustern3.q.out da71016 ql/src/test/results/clientnegative/clustern4.q.out 1519e48 ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 ql/src/test/results/clientnegative/input1.q.out 73f1657 ql/src/test/results/clientnegative/input2.q.out 0c460a6 ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 ql/src/test/results/clientnegative/joinneg.q.out d85d508 ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 ql/src/test/results/clientnegative/regex_col_2.q.out f570010 ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 ql/src/test/results/clientnegative/semijoin1.q.out 739931f ql/src/test/results/clientnegative/semijoin2.q.out 2b418de ql/src/test/results/clientnegative/semijoin3.q.out a803b50 ql/src/test/results/clientnegative/semijoin4.q.out 86a834b ql/src/test/results/clientnegative/split_sample_out_of_range.q.out 0761955 ql/src/test/results/clientnegative/split_sample_wrong_format.q.out 19b1417 ql/src/test/results/clientnegative/strict_orderby.q.out 2d3ba6b ql/src/test/results/clientnegative/subq_insert.q.out 8c3ce79 ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out d6b98b4 ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 7b8dca6 ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 75b9638 ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 126fa4e ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd62771 ql/src/test/results/clientnegative/udf_coalesce.q.out a5279f5 ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out 22a085a ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out fc83f23 ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 3bf97d9 ql/src/test/results/clientnegative/udf_field_wrong_type.q.out 2a2e944 ql/src/test/results/clientnegative/udf_if_not_bool.q.out a3c8902 ql/src/test/results/clientnegative/udf_if_wrong_args_len.q.out 89b23c8
Re: Review Request: HIVE-2155 Improve error messages emitted during semantic analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/731/ --- (Updated 2011-05-12 23:44:48.689718) Review request for hive and John Sichi. Changes --- Updated based on John's comments in the JIRA, instead of changing the overall structure, I decided to move the logic to print that context token into the new generateErrorMessage, which prevents breaking existing error messages which rely on that behavior. Summary --- Attaches line/column number to the vast majority of SemanticExceptions thrown. In addition, the context strings for the error messages relating to UNION ALLs and GROUP BY keys have been changed to provide more meaningful context. This addresses bug HIVE-2155. https://issues.apache.org/jira/browse/HIVE-2155 Diffs (updated) - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd ql/src/test/queries/clientnegative/union3.q PRE-CREATION ql/src/test/results/clientnegative/analyze_view.q.out ef76106 ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 ql/src/test/results/clientnegative/clustern3.q.out da71016 ql/src/test/results/clientnegative/clustern4.q.out 1519e48 ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 ql/src/test/results/clientnegative/input1.q.out 73f1657 ql/src/test/results/clientnegative/input2.q.out 0c460a6 ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 ql/src/test/results/clientnegative/joinneg.q.out d85d508 ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 ql/src/test/results/clientnegative/regex_col_2.q.out f570010 ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 ql/src/test/results/clientnegative/semijoin1.q.out 739931f ql/src/test/results/clientnegative/semijoin2.q.out 2b418de ql/src/test/results/clientnegative/semijoin3.q.out a803b50 ql/src/test/results/clientnegative/semijoin4.q.out 86a834b ql/src/test/results/clientnegative/split_sample_out_of_range.q.out 0761955 ql/src/test/results/clientnegative/split_sample_wrong_format.q.out 19b1417 ql/src/test/results/clientnegative/strict_orderby.q.out 2d3ba6b ql/src/test/results/clientnegative/subq_insert.q.out 8c3ce79 ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out d6b98b4 ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 7b8dca6 ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 75b9638 ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 126fa4e ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd62771 ql/src/test/results/clientnegative/udf_coalesce.q.out a5279f5 ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out 22a085a ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out fc83f23 ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 3bf97d9 ql/src/test/results/clientnegative/udf_field_wrong_type.q.out 2a2e944 ql/src/test/results/clientnegative/udf_if_not_bool.q.out a3c8902 ql/src/test/results/clientnegative/udf_if_wrong_args_len.q.out 89b23c8 ql/src/test/results/clientnegative/udf_in.q.out 50a6b98 ql/src/test/results/clientnegative/udf_instr_wrong_args_len.q.out 7f66db7 ql/src/test/results/clientnegative/udf_instr_wrong_type.q.out 89d8542 ql/src/test/results/clientnegative/udf_locate_wrong_args_len.q.out 46613e8 ql/src/test/results/clientnegative/udf_locate_wrong_type.q.out 42cc4b6 ql/src/test/results/clientnegative/udf_size_wrong_args_len.q.out b05731e ql/src/test/results/clientnegative/udf_size_wrong_type.q.out 0c91c8f ql/src/test/results/clientnegative/udf_when_type_wrong.q.out bec3725 ql/src/test/results/clientnegative/udf_when_type_wrong2.q.out 5b06467
Review Request: HIVE-2155 Improve error messages emitted during semantic analysis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/731/ --- Review request for hive and John Sichi. Summary --- Attaches line/column number to the vast majority of SemanticExceptions thrown. In addition, the context strings for the error messages relating to UNION ALLs and GROUP BY keys have been changed to provide more meaningful context. This addresses bug HIVE-2155. https://issues.apache.org/jira/browse/HIVE-2155 Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dc96a1f ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 2fe37b6 ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 4ddf5b9 ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9cb407c ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java bca37fd ql/src/test/queries/clientnegative/union3.q PRE-CREATION ql/src/test/results/clientnegative/analyze_view.q.out ef76106 ql/src/test/results/clientnegative/clusterbydistributeby.q.out 4c1ebfb ql/src/test/results/clientnegative/clusterbysortby.q.out f76d4a7 ql/src/test/results/clientnegative/clustern3.q.out da71016 ql/src/test/results/clientnegative/clustern4.q.out 1519e48 ql/src/test/results/clientnegative/create_view_failure3.q.out 70e365a ql/src/test/results/clientnegative/ddltime.q.out 11d00c3 ql/src/test/results/clientnegative/drop_partition_failure.q.out 1a0ac10 ql/src/test/results/clientnegative/dyn_part2.q.out cc0cd3c ql/src/test/results/clientnegative/fileformat_void_input.q.out 5a7a05a ql/src/test/results/clientnegative/groupby_key.q.out c6218a4 ql/src/test/results/clientnegative/input1.q.out 73f1657 ql/src/test/results/clientnegative/input2.q.out 0c460a6 ql/src/test/results/clientnegative/invalidate_view1.q.out 9f61228 ql/src/test/results/clientnegative/joinneg.q.out d85d508 ql/src/test/results/clientnegative/line_terminator.q.out b672bd8 ql/src/test/results/clientnegative/load_wrong_noof_part.q.out 4d8c8d8 ql/src/test/results/clientnegative/nopart_insert.q.out 42bca76 ql/src/test/results/clientnegative/notable_alias3.q.out d48d5e1 ql/src/test/results/clientnegative/orderbysortby.q.out 73b83a4 ql/src/test/results/clientnegative/regex_col_1.q.out 7547858 ql/src/test/results/clientnegative/regex_col_2.q.out f570010 ql/src/test/results/clientnegative/regex_col_groupby.q.out 8497718 ql/src/test/results/clientnegative/semijoin1.q.out 739931f ql/src/test/results/clientnegative/semijoin2.q.out 2b418de ql/src/test/results/clientnegative/semijoin3.q.out a803b50 ql/src/test/results/clientnegative/semijoin4.q.out 86a834b ql/src/test/results/clientnegative/split_sample_out_of_range.q.out 0761955 ql/src/test/results/clientnegative/split_sample_wrong_format.q.out 19b1417 ql/src/test/results/clientnegative/strict_orderby.q.out 2d3ba6b ql/src/test/results/clientnegative/subq_insert.q.out 8c3ce79 ql/src/test/results/clientnegative/udf_array_contains_wrong1.q.out d6b98b4 ql/src/test/results/clientnegative/udf_array_contains_wrong2.q.out 7b8dca6 ql/src/test/results/clientnegative/udf_case_type_wrong.q.out 75b9638 ql/src/test/results/clientnegative/udf_case_type_wrong2.q.out 126fa4e ql/src/test/results/clientnegative/udf_case_type_wrong3.q.out fd62771 ql/src/test/results/clientnegative/udf_coalesce.q.out a5279f5 ql/src/test/results/clientnegative/udf_elt_wrong_args_len.q.out 22a085a ql/src/test/results/clientnegative/udf_elt_wrong_type.q.out fc83f23 ql/src/test/results/clientnegative/udf_field_wrong_args_len.q.out 3bf97d9 ql/src/test/results/clientnegative/udf_field_wrong_type.q.out 2a2e944 ql/src/test/results/clientnegative/udf_if_not_bool.q.out a3c8902 ql/src/test/results/clientnegative/udf_if_wrong_args_len.q.out 89b23c8 ql/src/test/results/clientnegative/udf_in.q.out 50a6b98 ql/src/test/results/clientnegative/udf_instr_wrong_args_len.q.out 7f66db7 ql/src/test/results/clientnegative/udf_instr_wrong_type.q.out 89d8542 ql/src/test/results/clientnegative/udf_locate_wrong_args_len.q.out 46613e8 ql/src/test/results/clientnegative/udf_locate_wrong_type.q.out 42cc4b6 ql/src/test/results/clientnegative/udf_size_wrong_args_len.q.out b05731e ql/src/test/results/clientnegative/udf_size_wrong_type.q.out 0c91c8f ql/src/test/results/clientnegative/udf_when_type_wrong.q.out bec3725 ql/src/test/results/clientnegative/udf_when_type_wrong2.q.out 5b06467 ql/src/test/results/clientnegative/udf_when_type_wrong3.q.out 6974dd7 ql/src/test/results/clientnegative/udtf_not_supported1.q.out cc5f23b ql/src/test/results/clientnegative/udtf_not_supported2.q.out c8987ea ql/src/test/results/clientnegative/union.q.out 333230d ql/src/test/results/clientnegative/union2.q.out 1e6c782
