Re: Review Request: allow 't', 'T', '1', 'f', 'F', and '0' to be allowable true/false values for the boolean hive type

[Alexander Alten-Lorenz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7759/
---

(Updated Nov. 20, 2012, 7:11 a.m.)


Review request for hive.


Changes
---

indentation fixed


Description
---

interpret t as true and f as false for boolean types. PostgreSQL exports 
represent it that way


This addresses bug HIVE-3635.
https://issues.apache.org/jira/browse/HIVE-3635


Diffs (updated)
-

  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBoolean.java c741c3a 

Diff: https://reviews.apache.org/r/7759/diff/


Testing
---


Thanks,

Alexander Alten-Lorenz

Re: Review Request: allow 't', 'T', '1', 'f', 'F', and '0' to be allowable true/false values for the boolean hive type

[Carl Steinbach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7759/#review13463
---


This change needs a testcase. Please extend the sample boolean data set located 
in data/files/bool.txt and add a new qfile test that SELECTs from this table. 
See compute_stats_boolean.q for an example of how to load this file into a 
table.


serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBoolean.java


Please fix the indentation.


- Carl Steinbach


On Oct. 29, 2012, 7:11 a.m., Alexander Alten-Lorenz wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7759/
> ---
> 
> (Updated Oct. 29, 2012, 7:11 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Description
> ---
> 
> interpret t as true and f as false for boolean types. PostgreSQL exports 
> represent it that way
> 
> 
> This addresses bug HIVE-3635.
> https://issues.apache.org/jira/browse/HIVE-3635
> 
> 
> Diffs
> -
> 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBoolean.java c741c3a 
> 
> Diff: https://reviews.apache.org/r/7759/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Alten-Lorenz
> 
>

Review Request: allow 't', 'T', '1', 'f', 'F', and '0' to be allowable true/false values for the boolean hive type

[Alexander Alten-Lorenz]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7759/
---

Review request for hive.


Description
---

interpret t as true and f as false for boolean types. PostgreSQL exports 
represent it that way


This addresses bug HIVE-3635.
https://issues.apache.org/jira/browse/HIVE-3635


Diffs
-

  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBoolean.java c741c3a 

Diff: https://reviews.apache.org/r/7759/diff/


Testing
---


Thanks,

Alexander Alten-Lorenz