Re: Review Request 10180: HIVE-4171

2013-09-13 Thread Prasad Mujumdar

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10180/#review26073
---


LGTM

- Prasad Mujumdar


On Sept. 12, 2013, 3:08 a.m., Thejas Nair wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10180/
> ---
> 
> (Updated Sept. 12, 2013, 3:08 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan, Navis Ryu, and Prasad Mujumdar.
> 
> 
> Bugs: HIVE-4171
> https://issues.apache.org/jira/browse/HIVE-4171
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-4171
> 
> 
> Diffs
> -
> 
>   cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java aeced48 
>   cli/src/java/org/apache/hadoop/hive/cli/CliSessionState.java d11b873 
>   cli/src/test/org/apache/hadoop/hive/cli/TestCliSessionState.java a95e206 
>   
> hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
>  0e011e4 
>   
> hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
>  3740795 
>   
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
>  75837ef 
>   
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
>  c144135 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 0bc4425 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 9de7dcf 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4dcb260 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 344c9b1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 932ec66 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
> 3413f51 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 6d50109 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6888504 
>   ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java d318f71 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 9588061 
>   ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8b8c276 
>   ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 4ee5267 
>   ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java 
> 81a3396 
>   ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10180/diff/
> 
> 
> Testing
> ---
> 
> Manually tested, unit test to be added.
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>



Re: Review Request 10180: HIVE-4171

2013-09-11 Thread Thejas Nair

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10180/
---

(Updated Sept. 12, 2013, 3:08 a.m.)


Review request for hive, Ashutosh Chauhan, Navis Ryu, and Prasad Mujumdar.


Changes
---

HIVE-4171.6.patch - fixes unit test failures


Bugs: HIVE-4171
https://issues.apache.org/jira/browse/HIVE-4171


Repository: hive-git


Description
---

HIVE-4171


Diffs (updated)
-

  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java aeced48 
  cli/src/java/org/apache/hadoop/hive/cli/CliSessionState.java d11b873 
  cli/src/test/org/apache/hadoop/hive/cli/TestCliSessionState.java a95e206 
  
hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
 0e011e4 
  
hcatalog/core/src/main/java/org/apache/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
 3740795 
  
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzer.java
 75837ef 
  
hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/SemanticAnalysis/HCatSemanticAnalyzerBase.java
 c144135 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 0bc4425 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ColumnStatsTask.java 9de7dcf 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4dcb260 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 344c9b1 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 932ec66 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
3413f51 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 6d50109 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 6888504 
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java d318f71 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 9588061 
  ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java 8b8c276 
  ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 4ee5267 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java 
81a3396 
  ql/src/test/org/apache/hadoop/hive/ql/session/TestSessionState.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/10180/diff/


Testing
---

Manually tested, unit test to be added.


Thanks,

Thejas Nair