Re: Review Request 12100: Patch to fix HIVE-4789

2013-08-30 Thread Sean Busbey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12100/
---

(Updated Aug. 30, 2013, 1:46 p.m.)


Review request for hive, Ashutosh Chauhan, Jakob Homan, and Mark Wagner.


Changes
---

Per feedback, breaking MetaStoreUtils changes into another ticket.


Repository: hive


Description
---

HIVE-3953 fixed using partitioned avro tables for anything that used the 
MapOperator, but those that rely on FetchOperator still fail with the same 
error.
e.g.
  SELECT * FROM partitioned_avro LIMIT 5;
  SELECT * FROM partitioned_avro WHERE partition_col=value;


Diffs (updated)
-

  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1518830 
  trunk/ql/src/test/queries/clientpositive/avro_partitioned.q 1518830 
  trunk/ql/src/test/results/clientpositive/avro_partitioned.q.out 1518830 

Diff: https://reviews.apache.org/r/12100/diff/


Testing
---

reran avro partition unit tests and partition_wise_fileformat*.q


Thanks,

Sean Busbey



Re: Review Request 12100: Patch to fix HIVE-4789

2013-06-26 Thread Ben Spivey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12100/#review22403
---

Ship it!


Ship It!

- Ben Spivey


On June 26, 2013, 5:56 a.m., Sean Busbey wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/12100/
 ---
 
 (Updated June 26, 2013, 5:56 a.m.)
 
 
 Review request for hive, Ashutosh Chauhan, Jakob Homan, and Mark Wagner.
 
 
 Repository: hive
 
 
 Description
 ---
 
 HIVE-3953 fixed using partitioned avro tables for anything that used the 
 MapOperator, but those that rely on FetchOperator still fail with the same 
 error.
 e.g.
   SELECT * FROM partitioned_avro LIMIT 5;
   SELECT * FROM partitioned_avro WHERE partition_col=value;
 
 
 Diffs
 -
 
   
 trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 
 1496728 
   trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1496728 
   trunk/ql/src/test/queries/clientpositive/avro_partitioned.q 1496728 
   trunk/ql/src/test/results/clientpositive/avro_partitioned.q.out 1496728 
 
 Diff: https://reviews.apache.org/r/12100/diff/
 
 
 Testing
 ---
 
 reran avro partition unit tests and partition_wise_fileformat*.q
 
 
 Thanks,
 
 Sean Busbey
 




Re: Review Request 12100: Patch to fix HIVE-4789

2013-06-25 Thread Sean Busbey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12100/
---

(Updated June 26, 2013, 5:56 a.m.)


Review request for hive, Ashutosh Chauhan, Jakob Homan, and Mark Wagner.


Changes
---

wrong summary. long day. :/


Summary (updated)
-

Patch to fix HIVE-4789


Repository: hive


Description
---

HIVE-3953 fixed using partitioned avro tables for anything that used the 
MapOperator, but those that rely on FetchOperator still fail with the same 
error.
e.g.
  SELECT * FROM partitioned_avro LIMIT 5;
  SELECT * FROM partitioned_avro WHERE partition_col=value;


Diffs
-

  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 
1496728 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 1496728 
  trunk/ql/src/test/queries/clientpositive/avro_partitioned.q 1496728 
  trunk/ql/src/test/results/clientpositive/avro_partitioned.q.out 1496728 

Diff: https://reviews.apache.org/r/12100/diff/


Testing
---

reran avro partition unit tests and partition_wise_fileformat*.q


Thanks,

Sean Busbey