Re: Review Request 18162: HIVE-6434: Restrict function create/drop to admin roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18162/#review36395 --- Ship it! Ship It! - Thejas Nair On Feb. 26, 2014, 2:10 a.m., Jason Dere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18162/ --- (Updated Feb. 26, 2014, 2:10 a.m.) Review request for hive and Thejas Nair. Bugs: HIVE-6434 https://issues.apache.org/jira/browse/HIVE-6434 Repository: hive-git Description --- Add output entity of DB object to make sure only admin roles can add/drop functions/macros. Diffs - ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 68a25e0 ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java 0ae07e3 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java c43bcea ql/src/test/queries/clientnegative/authorization_create_func1.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_create_func2.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_create_macro1.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_create_func1.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_create_macro1.q PRE-CREATION ql/src/test/results/clientnegative/authorization_create_func1.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_create_func2.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_create_macro1.q.out PRE-CREATION ql/src/test/results/clientnegative/cluster_tasklog_retrieval.q.out 747aa6a ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 393a3e8 ql/src/test/results/clientnegative/create_function_nonexistent_db.q.out ebb069e ql/src/test/results/clientnegative/create_function_nonudf_class.q.out dd66afc ql/src/test/results/clientnegative/create_udaf_failure.q.out 3fc3d36 ql/src/test/results/clientnegative/create_unknown_genericudf.q.out af3d50b ql/src/test/results/clientnegative/create_unknown_udf_udaf.q.out e138fd0 ql/src/test/results/clientnegative/drop_native_udf.q.out 1913df9 ql/src/test/results/clientnegative/udf_function_does_not_implement_udf.q.out 9ea8668 ql/src/test/results/clientnegative/udf_local_resource.q.out b6ea77d ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out ad70d54 ql/src/test/results/clientnegative/udf_test_error.q.out a788a10 ql/src/test/results/clientnegative/udf_test_error_reduce.q.out 98b42e0 ql/src/test/results/clientpositive/authorization_create_func1.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_create_macro1.q.out PRE-CREATION ql/src/test/results/clientpositive/autogen_colalias.q.out a074b96 ql/src/test/results/clientpositive/compile_processor.q.out 7e9bb29 ql/src/test/results/clientpositive/create_func1.q.out 5a249c3 ql/src/test/results/clientpositive/create_genericudaf.q.out 96fe2fa ql/src/test/results/clientpositive/create_genericudf.q.out bf1f4ac ql/src/test/results/clientpositive/create_udaf.q.out 2e86a36 ql/src/test/results/clientpositive/create_view.q.out ecc7618 ql/src/test/results/clientpositive/drop_udf.q.out 422933a ql/src/test/results/clientpositive/macro.q.out c483029 ql/src/test/results/clientpositive/ptf_register_tblfn.q.out 11c9724 ql/src/test/results/clientpositive/udaf_sum_list.q.out b1922d9 ql/src/test/results/clientpositive/udf_compare_java_string.q.out 8e6e365 ql/src/test/results/clientpositive/udf_context_aware.q.out 10414fa ql/src/test/results/clientpositive/udf_logic_java_boolean.q.out 88c1984 ql/src/test/results/clientpositive/udf_testlength.q.out 4d75482 ql/src/test/results/clientpositive/udf_testlength2.q.out 8a1e03e ql/src/test/results/clientpositive/udf_using.q.out 69e5f3b ql/src/test/results/clientpositive/windowing_udaf2.q.out 5043a45 Diff: https://reviews.apache.org/r/18162/diff/ Testing --- positive/negative q files added Thanks, Jason Dere
Re: Review Request 18162: HIVE-6434: Restrict function create/drop to admin roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18162/ --- (Updated Feb. 26, 2014, 2:10 a.m.) Review request for hive and Thejas Nair. Changes --- Adds back the restricting of create temp function/macro to admin roles. This is only in effect if sql standard auth is enabled. Bugs: HIVE-6434 https://issues.apache.org/jira/browse/HIVE-6434 Repository: hive-git Description --- Add output entity of DB object to make sure only admin roles can add/drop functions/macros. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 68a25e0 ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java 0ae07e3 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java c43bcea ql/src/test/queries/clientnegative/authorization_create_func1.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_create_func2.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_create_macro1.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_create_func1.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_create_macro1.q PRE-CREATION ql/src/test/results/clientnegative/authorization_create_func1.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_create_func2.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_create_macro1.q.out PRE-CREATION ql/src/test/results/clientnegative/cluster_tasklog_retrieval.q.out 747aa6a ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 393a3e8 ql/src/test/results/clientnegative/create_function_nonexistent_db.q.out ebb069e ql/src/test/results/clientnegative/create_function_nonudf_class.q.out dd66afc ql/src/test/results/clientnegative/create_udaf_failure.q.out 3fc3d36 ql/src/test/results/clientnegative/create_unknown_genericudf.q.out af3d50b ql/src/test/results/clientnegative/create_unknown_udf_udaf.q.out e138fd0 ql/src/test/results/clientnegative/drop_native_udf.q.out 1913df9 ql/src/test/results/clientnegative/udf_function_does_not_implement_udf.q.out 9ea8668 ql/src/test/results/clientnegative/udf_local_resource.q.out b6ea77d ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out ad70d54 ql/src/test/results/clientnegative/udf_test_error.q.out a788a10 ql/src/test/results/clientnegative/udf_test_error_reduce.q.out 98b42e0 ql/src/test/results/clientpositive/authorization_create_func1.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_create_macro1.q.out PRE-CREATION ql/src/test/results/clientpositive/autogen_colalias.q.out a074b96 ql/src/test/results/clientpositive/compile_processor.q.out 7e9bb29 ql/src/test/results/clientpositive/create_func1.q.out 5a249c3 ql/src/test/results/clientpositive/create_genericudaf.q.out 96fe2fa ql/src/test/results/clientpositive/create_genericudf.q.out bf1f4ac ql/src/test/results/clientpositive/create_udaf.q.out 2e86a36 ql/src/test/results/clientpositive/create_view.q.out ecc7618 ql/src/test/results/clientpositive/drop_udf.q.out 422933a ql/src/test/results/clientpositive/macro.q.out c483029 ql/src/test/results/clientpositive/ptf_register_tblfn.q.out 11c9724 ql/src/test/results/clientpositive/udaf_sum_list.q.out b1922d9 ql/src/test/results/clientpositive/udf_compare_java_string.q.out 8e6e365 ql/src/test/results/clientpositive/udf_context_aware.q.out 10414fa ql/src/test/results/clientpositive/udf_logic_java_boolean.q.out 88c1984 ql/src/test/results/clientpositive/udf_testlength.q.out 4d75482 ql/src/test/results/clientpositive/udf_testlength2.q.out 8a1e03e ql/src/test/results/clientpositive/udf_using.q.out 69e5f3b ql/src/test/results/clientpositive/windowing_udaf2.q.out 5043a45 Diff: https://reviews.apache.org/r/18162/diff/ Testing --- positive/negative q files added Thanks, Jason Dere
Re: Review Request 18162: HIVE-6434: Restrict function create/drop to admin roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18162/ --- (Updated Feb. 22, 2014, 12:54 a.m.) Review request for hive and Thejas Nair. Changes --- Only restrict create/drop of metastore functions. temp functions/macros not affected. Bugs: HIVE-6434 https://issues.apache.org/jira/browse/HIVE-6434 Repository: hive-git Description --- Add output entity of DB object to make sure only admin roles can add/drop functions/macros. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java 68a25e0 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java 7dfd574 ql/src/test/queries/clientnegative/authorization_create_func1.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_create_func1.q PRE-CREATION ql/src/test/results/clientnegative/authorization_create_func1.q.out PRE-CREATION ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out 393a3e8 ql/src/test/results/clientnegative/create_function_nonexistent_db.q.out ebb069e ql/src/test/results/clientnegative/create_function_nonudf_class.q.out dd66afc ql/src/test/results/clientnegative/udf_local_resource.q.out b6ea77d ql/src/test/results/clientnegative/udf_nonexistent_resource.q.out ad70d54 ql/src/test/results/clientpositive/authorization_create_func1.q.out PRE-CREATION ql/src/test/results/clientpositive/create_func1.q.out 5a249c3 ql/src/test/results/clientpositive/udf_using.q.out 69e5f3b Diff: https://reviews.apache.org/r/18162/diff/ Testing --- positive/negative q files added Thanks, Jason Dere
Review Request 18162: HIVE-6434: Restrict function create/drop to admin roles
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18162/ --- Review request for hive and Thejas Nair. Bugs: HIVE-6434 https://issues.apache.org/jira/browse/HIVE-6434 Repository: hive-git Description --- Add output entity of DB object to make sure only admin roles can add/drop functions/macros. Diffs - ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java cc12f30 ql/src/java/org/apache/hadoop/hive/ql/parse/MacroSemanticAnalyzer.java 36f8f71 ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java fae6844 ql/src/test/queries/clientnegative/authorization_create_func1.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_create_func2.q PRE-CREATION ql/src/test/queries/clientnegative/authorization_create_macro1.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_create_func1.q PRE-CREATION ql/src/test/queries/clientpositive/authorization_create_macro1.q PRE-CREATION ql/src/test/results/clientnegative/authorization_create_func1.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_create_func2.q.out PRE-CREATION ql/src/test/results/clientnegative/authorization_create_macro1.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_create_func1.q.out PRE-CREATION ql/src/test/results/clientpositive/authorization_create_macro1.q.out PRE-CREATION Diff: https://reviews.apache.org/r/18162/diff/ Testing --- positive/negative q files added Thanks, Jason Dere
