Re: Review Request 20710: HIVE-6920 - Parquet Serde Simplification

2014-04-29 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20710/#review41781
---



pom.xml
https://reviews.apache.org/r/20710/#comment75374

Is this upgrade required by this patch? If not, we may want to have 
dedicated JIRA for that.



ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java
https://reviews.apache.org/r/20710/#comment75383

This is called by hive to show Serde stats. It's fine if a serde doesn't 
want to show any stats, but this is called by upper layer.


- Xuefu Zhang


On April 25, 2014, 2:46 p.m., justin coffey wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/20710/
 ---
 
 (Updated April 25, 2014, 2:46 p.m.)
 
 
 Review request for hive.
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Refactoring for simplification of the parquet-hive serde.
 
 
 Diffs
 -
 
   pom.xml 426dca8 
   
 ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java 
 b689336 
   ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 
 be518b9 
   
 ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java
  PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/20710/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 justin coffey
 




Review Request 20710: HIVE-6920 - Parquet Serde Simplification

2014-04-25 Thread justin coffey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20710/
---

Review request for hive.


Repository: hive-git


Description
---

Refactoring for simplification of the parquet-hive serde.


Diffs
-

  pom.xml 426dca8 
  ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetHiveSerDe.java 
b689336 
  ql/src/test/org/apache/hadoop/hive/ql/io/parquet/TestParquetSerDe.java 
be518b9 
  
ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetHiveSerDe.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/20710/diff/


Testing
---


Thanks,

justin coffey