Re: Review Request 20920: HIVE-6985 : sql std auth - privileges grants to public role not being honored

2014-04-30 Thread Thejas Nair

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20920/
---

(Updated April 30, 2014, 10:26 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
---

HIVE-6985.3.patch - really includes the test!


Bugs: HIVE-6985
https://issues.apache.org/jira/browse/HIVE-6985


Repository: hive-git


Description
---

When a privilege is granted to public role, the privilege is supposed to be 
applicable for all users.
However, the privilege check fails for users, even if the have public role in 
the list of current roles.

Note that the issue is only with public role. Grant of privileges of other role 
are not affected.


Diffs (updated)
-

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
5fc4af4 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 3ea87a0 
  ql/src/test/queries/clientpositive/authorization_grant_public_role.q 
PRE-CREATION 
  ql/src/test/results/clientpositive/authorization_grant_public_role.q.out 
PRE-CREATION 

Diff: https://reviews.apache.org/r/20920/diff/


Testing
---

New test included.


Thanks,

Thejas Nair



Review Request 20920: HIVE-6985 : sql std auth - privileges grants to public role not being honored

2014-04-30 Thread Thejas Nair

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20920/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-6985
https://issues.apache.org/jira/browse/HIVE-6985


Repository: hive-git


Description
---

When a privilege is granted to public role, the privilege is supposed to be 
applicable for all users.
However, the privilege check fails for users, even if the have public role in 
the list of current roles.

Note that the issue is only with public role. Grant of privileges of other role 
are not affected.


Diffs
-

  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
5fc4af4 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 3ea87a0 

Diff: https://reviews.apache.org/r/20920/diff/


Testing
---

New test included.


Thanks,

Thejas Nair