Re: Review Request 24085: HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables

2014-08-08 Thread Tom White

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24085/#review50049
---

Ship it!


Ship It!

- Tom White


On Aug. 8, 2014, midnight, Ashish Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24085/
> ---
> 
> (Updated Aug. 8, 2014, midnight)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7446
> https://issues.apache.org/jira/browse/HIVE-7446
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables
> 
> 
> Diffs
> -
> 
>   ql/src/test/queries/clientpositive/avro_add_column.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_add_column2.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_add_column3.q PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_add_column.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_add_column2.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_add_column3.q.out PRE-CREATION 
>   serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java 
> 915f01679183904d0d93b9b8a88dc1a64ac2af78 
>   serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java 
> 722bdf9f8452fe8632db7d9167182310e467281d 
>   serde/src/test/resources/avro-nested-struct.avsc 
> 785af83cd01fe91626741b3d7659d8f515854774 
>   serde/src/test/resources/avro-struct.avsc 
> 313c74f6140615d2737ef1a49a2777656f35f4e3 
> 
> Diff: https://reviews.apache.org/r/24085/diff/
> 
> 
> Testing
> ---
> 
> qTests
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>



Re: Review Request 24085: HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables

2014-08-07 Thread Ashish Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24085/
---

(Updated Aug. 8, 2014, midnight)


Review request for hive.


Changes
---

Add test to make sure special case found in HIVE-6835 is handled.


Bugs: HIVE-7446
https://issues.apache.org/jira/browse/HIVE-7446


Repository: hive-git


Description
---

HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables


Diffs (updated)
-

  ql/src/test/queries/clientpositive/avro_add_column.q PRE-CREATION 
  ql/src/test/queries/clientpositive/avro_add_column2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/avro_add_column3.q PRE-CREATION 
  ql/src/test/results/clientpositive/avro_add_column.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_add_column2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_add_column3.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java 
915f01679183904d0d93b9b8a88dc1a64ac2af78 
  serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java 
722bdf9f8452fe8632db7d9167182310e467281d 
  serde/src/test/resources/avro-nested-struct.avsc 
785af83cd01fe91626741b3d7659d8f515854774 
  serde/src/test/resources/avro-struct.avsc 
313c74f6140615d2737ef1a49a2777656f35f4e3 

Diff: https://reviews.apache.org/r/24085/diff/


Testing
---

qTests


Thanks,

Ashish Singh



Re: Review Request 24085: HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables

2014-08-07 Thread Ashish Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24085/
---

(Updated Aug. 7, 2014, 10:09 p.m.)


Review request for hive.


Changes
---

Add default values to avro schema elements.


Bugs: HIVE-7446
https://issues.apache.org/jira/browse/HIVE-7446


Repository: hive-git


Description
---

HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables


Diffs (updated)
-

  ql/src/test/queries/clientpositive/avro_add_column.q PRE-CREATION 
  ql/src/test/queries/clientpositive/avro_add_column2.q PRE-CREATION 
  ql/src/test/results/clientpositive/avro_add_column.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_add_column2.q.out PRE-CREATION 
  serde/src/java/org/apache/hadoop/hive/serde2/avro/TypeInfoToSchema.java 
915f01679183904d0d93b9b8a88dc1a64ac2af78 
  serde/src/test/org/apache/hadoop/hive/serde2/avro/TestTypeInfoToSchema.java 
722bdf9f8452fe8632db7d9167182310e467281d 
  serde/src/test/resources/avro-nested-struct.avsc 
785af83cd01fe91626741b3d7659d8f515854774 
  serde/src/test/resources/avro-struct.avsc 
313c74f6140615d2737ef1a49a2777656f35f4e3 

Diff: https://reviews.apache.org/r/24085/diff/


Testing
---

qTests


Thanks,

Ashish Singh



Re: Review Request 24085: HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables

2014-07-31 Thread Tom White

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24085/#review49224
---

Ship it!


Ship It!

- Tom White


On July 30, 2014, 2:33 a.m., Ashish Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24085/
> ---
> 
> (Updated July 30, 2014, 2:33 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-7446
> https://issues.apache.org/jira/browse/HIVE-7446
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables
> 
> 
> Diffs
> -
> 
>   ql/src/test/queries/clientpositive/avro_add_column.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/avro_add_column2.q PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_add_column.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_add_column2.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24085/diff/
> 
> 
> Testing
> ---
> 
> qTests
> 
> 
> Thanks,
> 
> Ashish Singh
> 
>



Review Request 24085: HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables

2014-07-29 Thread Ashish Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24085/
---

Review request for hive.


Bugs: HIVE-7446
https://issues.apache.org/jira/browse/HIVE-7446


Repository: hive-git


Description
---

HIVE-7446: Add support to ALTER TABLE .. ADD COLUMN to Avro backed tables


Diffs
-

  ql/src/test/queries/clientpositive/avro_add_column.q PRE-CREATION 
  ql/src/test/queries/clientpositive/avro_add_column2.q PRE-CREATION 
  ql/src/test/results/clientpositive/avro_add_column.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/avro_add_column2.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24085/diff/


Testing
---

qTests


Thanks,

Ashish Singh