Re: Review Request 24630: HIVE-7694 - SMB joins on tables differing by number of sorted by columns but same sort prefix and join keys fail

2014-09-09 Thread Amareshwari Sriramadasu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24630/#review52695
---

Ship it!


Ship It!

- Amareshwari Sriramadasu


On Sept. 8, 2014, 5:25 p.m., Suma Shivaprasad wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/24630/
 ---
 
 (Updated Sept. 8, 2014, 5:25 p.m.)
 
 
 Review request for hive, Amareshwari Sriramadasu, Brock Noland, Gunther 
 Hagleitner, and Navis Ryu.
 
 
 Bugs: HIVE-7694
 https://issues.apache.org/jira/browse/HIVE-7694
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 For eg: If two tables T1 sorted by (a, b, c) clustered by a and T2 sorted by 
 (a) and clustered by (a) are joined, an exception is seen as reported in 
 https://issues.apache.org/jira/browse/HIVE-7694
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
 0b7b1a3 
   ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q PRE-CREATION 
   ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/24630/diff/
 
 
 Testing
 ---
 
 sort_merge_join_desc_8.q added for testing the above cases
 
 
 Thanks,
 
 Suma Shivaprasad
 




Re: Review Request 24630: HIVE-7694 - SMB joins on tables differing by number of sorted by columns but same sort prefix and join keys fail

2014-09-08 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24630/
---

(Updated Sept. 8, 2014, 5:25 p.m.)


Review request for hive, Amareshwari Sriramadasu, Brock Noland, Gunther 
Hagleitner, and Navis Ryu.


Changes
---

Added another reviewer


Bugs: HIVE-7694
https://issues.apache.org/jira/browse/HIVE-7694


Repository: hive-git


Description
---

For eg: If two tables T1 sorted by (a, b, c) clustered by a and T2 sorted by 
(a) and clustered by (a) are joined, an exception is seen as reported in 
https://issues.apache.org/jira/browse/HIVE-7694


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
0b7b1a3 
  ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q PRE-CREATION 
  ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24630/diff/


Testing (updated)
---

sort_merge_join_desc_8.q added for testing the above cases


Thanks,

Suma Shivaprasad



Re: Review Request 24630: HIVE-7694 - SMB joins on tables differing by number of sorted by columns but same sort prefix and join keys fail

2014-08-23 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24630/
---

(Updated Aug. 23, 2014, 7:14 a.m.)


Review request for hive, Brock Noland, Gunther Hagleitner, and Navis Ryu.


Bugs: HIVE-7694
https://issues.apache.org/jira/browse/HIVE-7694


Repository: hive-git


Description
---

For eg: If two tables T1 sorted by (a, b, c) clustered by a and T2 sorted by 
(a) and clustered by (a) are joined, an exception is seen as reported in 
https://issues.apache.org/jira/browse/HIVE-7694


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
0b7b1a3 
  ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q PRE-CREATION 
  ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24630/diff/


Testing
---

sort_merge_join_desc_8.q added for testing the above cases


Thanks,

Suma Shivaprasad



Re: Review Request 24630: HIVE-7694 - SMB joins on tables differing by number of sorted by columns but same sort prefix and join keys fail

2014-08-14 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24630/
---

(Updated Aug. 15, 2014, 4:45 a.m.)


Review request for hive, Gunther Hagleitner and Navis Ryu.


Summary (updated)
-

HIVE-7694 - SMB joins on tables differing by number of sorted by columns but 
same sort prefix and join keys fail


Bugs: HIVE-7694
https://issues.apache.org/jira/browse/HIVE-7694


Repository: hive-git


Description
---

For eg: If two tables T1 sorted by (a, b, c) clustered by a and T2 sorted by 
(a) and clustered by (a) are joined, an exception is seen as reported in 
https://issues.apache.org/jira/browse/HIVE-7694


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
0b7b1a3 
  ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q PRE-CREATION 
  ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24630/diff/


Testing
---

sort_merge_join_desc_8.q added for testing the above cases


Thanks,

Suma Shivaprasad



Review Request 24630: HIve-7694 - SMB joins on tables differing by number of sorted by columns but same sort prefix and join keys fail

2014-08-12 Thread Suma Shivaprasad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24630/
---

Review request for hive.


Bugs: HIVE-7694
https://issues.apache.org/jira/browse/HIVE-7694


Repository: hive-git


Description
---

For eg: If two tables T1 sorted by (a, b, c) clustered by a and T2 sorted by 
(a) and clustered by (a) are joined, an exception is seen as reported in 
https://issues.apache.org/jira/browse/HIVE-7694


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
0b7b1a3 
  ql/src/test/queries/clientpositive/sort_merge_join_desc_8.q PRE-CREATION 
  ql/src/test/results/clientpositive/sort_merge_join_desc_8.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/24630/diff/


Testing
---

sort_merge_join_desc_8.q added for testing the above cases


Thanks,

Suma Shivaprasad