Re: Review Request 25288: HIVE-7941: add unit test case for line wrapping

[cheng xu]

> On Sept. 3, 2014, 7:30 a.m., Thejas Nair wrote:
> > beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java, line 45
> > 
> >
> > Thanks for adding the test case for truncation. Can you also add one 
> > for the line wrapping?
> 
> Thejas Nair wrote:
> I mean, when a long input line is printed across multiple lines.

I take a look at the codes and do not see the wrapping logics in beeline codes. 
I am wondering whether the wrapping work is done by the editor or the console 
other than hive beeline side. Am I right?


- cheng


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25288/#review52145
---


On Sept. 3, 2014, 5:48 a.m., cheng xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25288/
> ---
> 
> (Updated Sept. 3, 2014, 5:48 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-7941: add unit test case for line wrapping
> 
> 
> Diffs
> -
> 
>   beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25288/diff/
> 
> 
> Testing
> ---
> 
> UT
> 
> 
> Thanks,
> 
> cheng xu
> 
>

Re: Review Request 25288: HIVE-7941: add unit test case for line wrapping

[Thejas Nair]

> On Sept. 3, 2014, 7:30 a.m., Thejas Nair wrote:
> > beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java, line 45
> > 
> >
> > Thanks for adding the test case for truncation. Can you also add one 
> > for the line wrapping?

I mean, when a long input line is printed across multiple lines.


- Thejas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25288/#review52145
---


On Sept. 3, 2014, 5:48 a.m., cheng xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25288/
> ---
> 
> (Updated Sept. 3, 2014, 5:48 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-7941: add unit test case for line wrapping
> 
> 
> Diffs
> -
> 
>   beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25288/diff/
> 
> 
> Testing
> ---
> 
> UT
> 
> 
> Thanks,
> 
> cheng xu
> 
>

Re: Review Request 25288: HIVE-7941: add unit test case for line wrapping

[Thejas Nair]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25288/#review52145
---



beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java


Thanks for adding the test case for truncation. Can you also add one for 
the line wrapping?


- Thejas Nair


On Sept. 3, 2014, 5:48 a.m., cheng xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25288/
> ---
> 
> (Updated Sept. 3, 2014, 5:48 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-7941: add unit test case for line wrapping
> 
> 
> Diffs
> -
> 
>   beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/25288/diff/
> 
> 
> Testing
> ---
> 
> UT
> 
> 
> Thanks,
> 
> cheng xu
> 
>

Review Request 25288: HIVE-7941: add unit test case for line wrapping

[cheng xu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25288/
---

Review request for hive.


Repository: hive-git


Description
---

HIVE-7941: add unit test case for line wrapping


Diffs
-

  beeline/src/test/org/apache/hive/beeline/TestTableOutputFormat.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/25288/diff/


Testing
---

UT


Thanks,

cheng xu