Re: Review Request 25497: HIVE-7627, FSStatsPublisher does fit into Spark multi-thread task mode

2014-09-29 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25497/#review54837
---

Ship it!


Ship It!

- Xuefu Zhang


On Sept. 28, 2014, 9:50 a.m., chengxiang li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25497/
> ---
> 
> (Updated Sept. 28, 2014, 9:50 a.m.)
> 
> 
> Review request for hive, Brock Noland and Xuefu Zhang.
> 
> 
> Bugs: HIVE-7627
> https://issues.apache.org/jira/browse/HIVE-7627
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Hive table statistic failed on FSStatsPublisher mode because of missing 
> "mapred.task.patition" parameter.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 
> 1674d4b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunction.java 
> 0b8b7c9 
> 
> Diff: https://reviews.apache.org/r/25497/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> chengxiang li
> 
>



Re: Review Request 25497: HIVE-7627, FSStatsPublisher does fit into Spark multi-thread task mode

2014-09-28 Thread Xuefu Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25497/#review54777
---

Ship it!


Ship It!

- Xuefu Zhang


On Sept. 28, 2014, 9:50 a.m., chengxiang li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25497/
> ---
> 
> (Updated Sept. 28, 2014, 9:50 a.m.)
> 
> 
> Review request for hive, Brock Noland and Xuefu Zhang.
> 
> 
> Bugs: HIVE-7627
> https://issues.apache.org/jira/browse/HIVE-7627
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Hive table statistic failed on FSStatsPublisher mode because of missing 
> "mapred.task.patition" parameter.
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 
> 1674d4b 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunction.java 
> 0b8b7c9 
> 
> Diff: https://reviews.apache.org/r/25497/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> chengxiang li
> 
>



Re: Review Request 25497: HIVE-7627, FSStatsPublisher does fit into Spark multi-thread task mode

2014-09-28 Thread chengxiang li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25497/
---

(Updated Sept. 28, 2014, 9:50 a.m.)


Review request for hive, Brock Noland and Xuefu Zhang.


Bugs: HIVE-7627
https://issues.apache.org/jira/browse/HIVE-7627


Repository: hive-git


Description (updated)
---

Hive table statistic failed on FSStatsPublisher mode because of missing 
"mapred.task.patition" parameter.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 1674d4b 

Diff: https://reviews.apache.org/r/25497/diff/


Testing
---


Thanks,

chengxiang li



Re: Review Request 25497: HIVE-7627, FSStatsPublisher does fit into Spark multi-thread task mode

2014-09-28 Thread chengxiang li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25497/
---

(Updated Sept. 28, 2014, 9:50 a.m.)


Review request for hive, Brock Noland and Xuefu Zhang.


Bugs: HIVE-7627
https://issues.apache.org/jira/browse/HIVE-7627


Repository: hive-git


Description
---

Hive table statistic failed on FSStatsPublisher mode because of missing 
"mapred.task.patition" parameter.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 1674d4b 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveReduceFunction.java 
0b8b7c9 

Diff: https://reviews.apache.org/r/25497/diff/


Testing
---


Thanks,

chengxiang li



Re: Review Request 25497: HIVE-7627, FSStatsPublisher does fit into Spark multi-thread task mode

2014-09-28 Thread chengxiang li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25497/
---

(Updated Sept. 28, 2014, 7:59 a.m.)


Review request for hive, Brock Noland and Xuefu Zhang.


Bugs: HIVE-7627
https://issues.apache.org/jira/browse/HIVE-7627


Repository: hive-git


Description
---

make taskId field variable of FSStatPublisher would resolve this issue either, 
since SPARK-2895 is still under review, we could enable random generated taskId 
first.


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveMapFunction.java 1674d4b 

Diff: https://reviews.apache.org/r/25497/diff/


Testing
---


Thanks,

chengxiang li



Review Request 25497: HIVE-7627, FSStatsPublisher does fit into Spark multi-thread task mode

2014-09-10 Thread chengxiang li

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25497/
---

Review request for hive, Brock Noland and Xuefu Zhang.


Bugs: HIVE-7627
https://issues.apache.org/jira/browse/HIVE-7627


Repository: hive-git


Description
---

make taskId field variable of FSStatPublisher would resolve this issue either, 
since SPARK-2895 is still under review, we could enable random generated taskId 
first.


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java cb010fb 

Diff: https://reviews.apache.org/r/25497/diff/


Testing
---


Thanks,

chengxiang li