Re: Review Request 26299: HIVE-5536 - Incorrect Operation Name is passed to hookcontext
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26299/ --- (Updated Oct. 3, 2014, 5:24 p.m.) Review request for hive and Mohit Sabharwal. Changes --- Updated based on feedback. Repository: hive-git Description --- Add's operation name to Query Plan. Also tests to ensure it's correct. I updated the test a little as well since it was quite hard to debug a failure. Diffs (updated) - itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java 99026b0 itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 49b9994 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5b36f71 ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 85d599a ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 49c095a ql/src/test/org/apache/hadoop/hive/ql/parse/TestUpdateDeleteSemanticAnalyzer.java 01e3635 Diff: https://reviews.apache.org/r/26299/diff/ Testing --- Thanks, Brock Noland
Re: Review Request 26299: HIVE-5536 - Incorrect Operation Name is passed to hookcontext
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26299/#review55366 --- Ship it! Ship It! - Mohit Sabharwal On Oct. 3, 2014, 5:24 p.m., Brock Noland wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26299/ --- (Updated Oct. 3, 2014, 5:24 p.m.) Review request for hive and Mohit Sabharwal. Repository: hive-git Description --- Add's operation name to Query Plan. Also tests to ensure it's correct. I updated the test a little as well since it was quite hard to debug a failure. Diffs - itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java 99026b0 itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 49b9994 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5b36f71 ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 85d599a ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 49c095a ql/src/test/org/apache/hadoop/hive/ql/parse/TestUpdateDeleteSemanticAnalyzer.java 01e3635 Diff: https://reviews.apache.org/r/26299/diff/ Testing --- Thanks, Brock Noland
Review Request 26299: HIVE-5536 - Incorrect Operation Name is passed to hookcontext
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26299/ --- Review request for hive and Mohit Sabharwal. Repository: hive-git Description --- Add's operation name to Query Plan. Also tests to ensure it's correct. I updated the test a little as well since it was quite hard to debug a failure. Diffs - itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java 99026b0 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5b36f71 ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 85d599a ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 49c095a ql/src/test/org/apache/hadoop/hive/ql/parse/TestUpdateDeleteSemanticAnalyzer.java 01e3635 Diff: https://reviews.apache.org/r/26299/diff/ Testing --- Thanks, Brock Noland
Re: Review Request 26299: HIVE-5536 - Incorrect Operation Name is passed to hookcontext
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26299/#review55290 --- Ship it! LGTM. A comment on the unit test. Also, should we add this test to TestHs2Hooks as well ? itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java https://reviews.apache.org/r/26299/#comment95680 Could you please add a second statement with a different operation as well? Just to make sure we are capturing the latest operation (and not the first operation) in the session. - Mohit Sabharwal On Oct. 3, 2014, 12:02 a.m., Brock Noland wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26299/ --- (Updated Oct. 3, 2014, 12:02 a.m.) Review request for hive and Mohit Sabharwal. Repository: hive-git Description --- Add's operation name to Query Plan. Also tests to ensure it's correct. I updated the test a little as well since it was quite hard to debug a failure. Diffs - itests/hive-minikdc/src/test/java/org/apache/hive/minikdc/TestHs2HooksWithMiniKdc.java 99026b0 ql/src/java/org/apache/hadoop/hive/ql/Driver.java 5b36f71 ql/src/java/org/apache/hadoop/hive/ql/QueryPlan.java 85d599a ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java 49c095a ql/src/test/org/apache/hadoop/hive/ql/parse/TestUpdateDeleteSemanticAnalyzer.java 01e3635 Diff: https://reviews.apache.org/r/26299/diff/ Testing --- Thanks, Brock Noland
