Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/ --- Review request for hive. Repository: hive-git Description --- On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. Diffs - bin/ext/hiveserver2.cmd a5f3bb5 bin/hive.cmd c2e9853 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 Diff: https://reviews.apache.org/r/26321/diff/ Testing --- Thanks, XIAOBING ZHOU
Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/#review55378 --- bin/ext/hiveserver2.cmd https://reviews.apache.org/r/26321/#comment95742 I don't think the -hiveconf paramaters should be part of the cmd. I see that you are trying to override the default value of some of these, but I think it is more appropriate to do that at the admin level (i.e. whichever admin service is managing the startup of hive). common/src/java/org/apache/hadoop/hive/conf/HiveConf.java https://reviews.apache.org/r/26321/#comment95740 Can you add a description for this new param (for why this is required) ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java https://reviews.apache.org/r/26321/#comment95741 Can you add a comment here explaining the intent of using HIVE_HADOOP_CLASSPATH? - Vaibhav Gumashta On Oct. 3, 2014, 6:27 p.m., XIAOBING ZHOU wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/ --- (Updated Oct. 3, 2014, 6:27 p.m.) Review request for hive. Repository: hive-git Description --- On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. Diffs - bin/ext/hiveserver2.cmd a5f3bb5 bin/hive.cmd c2e9853 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 Diff: https://reviews.apache.org/r/26321/diff/ Testing --- Thanks, XIAOBING ZHOU
Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
On Oct. 3, 2014, 7:06 p.m., Vaibhav Gumashta wrote: bin/ext/hiveserver2.cmd, line 82 https://reviews.apache.org/r/26321/diff/1/?file=713542#file713542line82 I don't think the -hiveconf paramaters should be part of the cmd. I see that you are trying to override the default value of some of these, but I think it is more appropriate to do that at the admin level (i.e. whichever admin service is managing the startup of hive). Explained by Hari here: https://issues.apache.org/jira/browse/HIVE-8340?focusedCommentId=14158506page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14158506 - Vaibhav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/#review55378 --- On Oct. 3, 2014, 6:27 p.m., XIAOBING ZHOU wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/ --- (Updated Oct. 3, 2014, 6:27 p.m.) Review request for hive. Repository: hive-git Description --- On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. Diffs - bin/ext/hiveserver2.cmd a5f3bb5 bin/hive.cmd c2e9853 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 Diff: https://reviews.apache.org/r/26321/diff/ Testing --- Thanks, XIAOBING ZHOU
Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
On Oct. 3, 2014, 7:06 p.m., Vaibhav Gumashta wrote: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 1726 https://reviews.apache.org/r/26321/diff/1/?file=713544#file713544line1726 Can you add a description for this new param (for why this is required) For Windows OS, we need to pass HIVE_HADOOP_CLASSPATH java parameter while starting hiveserver2 using -hiveconf hive.hadoop.classpath=%HIVE_LIB%. This is where it's defined. On Oct. 3, 2014, 7:06 p.m., Vaibhav Gumashta wrote: ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java, line 241 https://reviews.apache.org/r/26321/diff/1/?file=713545#file713545line241 Can you add a comment here explaining the intent of using HIVE_HADOOP_CLASSPATH? For Windows OS, we need to pass HIVE_HADOOP_CLASSPATH java parameter while starting hiveserver2 using -hiveconf hive.hadoop.classpath=%HIVE_LIB%. This is how it's used. - XIAOBING --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/#review55378 --- On Oct. 3, 2014, 6:27 p.m., XIAOBING ZHOU wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/ --- (Updated Oct. 3, 2014, 6:27 p.m.) Review request for hive. Repository: hive-git Description --- On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. Diffs - bin/ext/hiveserver2.cmd a5f3bb5 bin/hive.cmd c2e9853 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 Diff: https://reviews.apache.org/r/26321/diff/ Testing --- Thanks, XIAOBING ZHOU
Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/ --- (Updated Oct. 4, 2014, 5:11 a.m.) Review request for hive. Repository: hive-git Description --- On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. Diffs (updated) - bin/ext/hiveserver2.cmd a5f3bb5 bin/hive.cmd c2e9853 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 Diff: https://reviews.apache.org/r/26321/diff/ Testing --- Thanks, XIAOBING ZHOU
Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/ --- (Updated Oct. 4, 2014, 5:20 a.m.) Review request for hive. Repository: hive-git Description --- On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. Diffs (updated) - bin/ext/hiveserver2.cmd a5f3bb5 bin/hive.cmd c2e9853 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 Diff: https://reviews.apache.org/r/26321/diff/ Testing --- Thanks, XIAOBING ZHOU
Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/ --- (Updated Oct. 4, 2014, 5:21 a.m.) Review request for hive. Repository: hive-git Description --- On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. Diffs (updated) - bin/ext/hiveserver2.cmd a5f3bb5 bin/hive.cmd c2e9853 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 Diff: https://reviews.apache.org/r/26321/diff/ Testing --- Thanks, XIAOBING ZHOU
Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/#review55425 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java https://reviews.apache.org/r/26321/#comment95785 Looks good, thanks for the fixes. - Lefty Leverenz On Oct. 4, 2014, 5:21 a.m., XIAOBING ZHOU wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26321/ --- (Updated Oct. 4, 2014, 5:21 a.m.) Review request for hive. Repository: hive-git Description --- On stopping the HS2 service from the services tab, it only kills the root process and does not kill the child java process. As a result resources are not freed and this throws an error on restarting from command line. Diffs - bin/ext/hiveserver2.cmd a5f3bb5 bin/hive.cmd c2e9853 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3fe67b2 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 79da5a0 Diff: https://reviews.apache.org/r/26321/diff/ Testing --- Thanks, XIAOBING ZHOU
