Re: Review Request 35899: HIVE-11104

2015-06-26 Thread j . prasanth . j

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35899/#review89523
---



ql/src/test/results/clientpositive/annotate_stats_select.q.out (line 1025)
https://reviews.apache.org/r/35899/#comment142153

Stats shouldn't be 0 right? Select stats annotation can handle constants 
AFAIK.



ql/src/test/results/clientpositive/input_part10.q.out (line 51)
https://reviews.apache.org/r/35899/#comment142154

Same issue here.



ql/src/test/results/clientpositive/insert_into5.q.out (line 45)
https://reviews.apache.org/r/35899/#comment142155

We seem to drop stats everywhere.


- Prasanth_J


On June 26, 2015, 12:19 a.m., Ashutosh Chauhan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35899/
 ---
 
 (Updated June 26, 2015, 12:19 a.m.)
 
 
 Review request for hive.
 
 
 Bugs: HIVE-11104
 https://issues.apache.org/jira/browse/HIVE-11104
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 Select operator doesn't propagate constants appearing in expressions
 
 
 Diffs
 -
 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java
  3c8c0d6 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
  f9df8e5 
   ql/src/test/queries/clientpositive/cp_sel.q PRE-CREATION 
   ql/src/test/results/clientpositive/annotate_stats_select.q.out 306b870 
   ql/src/test/results/clientpositive/auto_join8.q.out 5b02597 
   ql/src/test/results/clientpositive/cluster.q.out eff3399 
   ql/src/test/results/clientpositive/cp_sel.q.out PRE-CREATION 
   ql/src/test/results/clientpositive/dynpart_sort_optimization_acid.q.out 
 bcc03cf 
   ql/src/test/results/clientpositive/input7.q.out 3abfabb 
   ql/src/test/results/clientpositive/input_part10.q.out 4f8a07f 
   ql/src/test/results/clientpositive/insert_into5.q.out 490f737 
   ql/src/test/results/clientpositive/join8.q.out 71792c1 
   ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out be83963 
   ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out a3641d6 
   ql/src/test/results/clientpositive/list_bucket_dml_12.q.java1.7.out 0b518e4 
   ql/src/test/results/clientpositive/list_bucket_dml_13.q.java1.7.out f834787 
   ql/src/test/results/clientpositive/load_dyn_part14.q.out 5af8490 
   ql/src/test/results/clientpositive/ppd_udf_case.q.out 0c53532 
   ql/src/test/results/clientpositive/ppd_union_view.q.out f0f6614 
   ql/src/test/results/clientpositive/spark/auto_join8.q.out e77817a 
   ql/src/test/results/clientpositive/spark/join8.q.out e3fac82 
   ql/src/test/results/clientpositive/spark/join_cond_pushdown_1.q.out ddfdc66 
   ql/src/test/results/clientpositive/spark/join_cond_pushdown_3.q.out d9ad78d 
   ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out 4df5e49 
   ql/src/test/results/clientpositive/spark/union_remove_12.q.out 62d9d7d 
   ql/src/test/results/clientpositive/spark/union_remove_14.q.out b28bb75 
   ql/src/test/results/clientpositive/spark/union_top_level.q.out dede1ef 
   ql/src/test/results/clientpositive/tez/tez_union_dynamic_partition.q.out 
 68a7531 
   ql/src/test/results/clientpositive/tez/vector_coalesce.q.out 1e01ab5 
   ql/src/test/results/clientpositive/tez/vector_decimal_2.q.out bbdd75f 
   ql/src/test/results/clientpositive/tez/vector_decimal_round_2.q.out 103fd8a 
   ql/src/test/results/clientpositive/tez/vector_interval_1.q.out 1cc7cb6 
   ql/src/test/results/clientpositive/union_remove_12.q.out 3ac1d44 
   ql/src/test/results/clientpositive/union_remove_14.q.out 94f2ff5 
   ql/src/test/results/clientpositive/union_top_level.q.out c64e792 
   ql/src/test/results/clientpositive/vector_coalesce.q.out eb5f204 
   ql/src/test/results/clientpositive/vector_decimal_2.q.out c0112a9 
   ql/src/test/results/clientpositive/vector_decimal_round_2.q.out 6947059 
   ql/src/test/results/clientpositive/vector_interval_1.q.out 5015916 
 
 Diff: https://reviews.apache.org/r/35899/diff/
 
 
 Testing
 ---
 
 Added new test  pre-existing ones.
 
 
 Thanks,
 
 Ashutosh Chauhan
 




Review Request 35899: HIVE-11104

2015-06-25 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35899/
---

Review request for hive.


Bugs: HIVE-11104
https://issues.apache.org/jira/browse/HIVE-11104


Repository: hive-git


Description
---

Select operator doesn't propagate constants appearing in expressions


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java
 3c8c0d6 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java
 f9df8e5 
  ql/src/test/queries/clientpositive/cp_sel.q PRE-CREATION 
  ql/src/test/results/clientpositive/annotate_stats_select.q.out 306b870 
  ql/src/test/results/clientpositive/auto_join8.q.out 5b02597 
  ql/src/test/results/clientpositive/cluster.q.out eff3399 
  ql/src/test/results/clientpositive/cp_sel.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/dynpart_sort_optimization_acid.q.out 
bcc03cf 
  ql/src/test/results/clientpositive/input7.q.out 3abfabb 
  ql/src/test/results/clientpositive/input_part10.q.out 4f8a07f 
  ql/src/test/results/clientpositive/insert_into5.q.out 490f737 
  ql/src/test/results/clientpositive/join8.q.out 71792c1 
  ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out be83963 
  ql/src/test/results/clientpositive/join_cond_pushdown_3.q.out a3641d6 
  ql/src/test/results/clientpositive/list_bucket_dml_12.q.java1.7.out 0b518e4 
  ql/src/test/results/clientpositive/list_bucket_dml_13.q.java1.7.out f834787 
  ql/src/test/results/clientpositive/load_dyn_part14.q.out 5af8490 
  ql/src/test/results/clientpositive/ppd_udf_case.q.out 0c53532 
  ql/src/test/results/clientpositive/ppd_union_view.q.out f0f6614 
  ql/src/test/results/clientpositive/spark/auto_join8.q.out e77817a 
  ql/src/test/results/clientpositive/spark/join8.q.out e3fac82 
  ql/src/test/results/clientpositive/spark/join_cond_pushdown_1.q.out ddfdc66 
  ql/src/test/results/clientpositive/spark/join_cond_pushdown_3.q.out d9ad78d 
  ql/src/test/results/clientpositive/spark/load_dyn_part14.q.out 4df5e49 
  ql/src/test/results/clientpositive/spark/union_remove_12.q.out 62d9d7d 
  ql/src/test/results/clientpositive/spark/union_remove_14.q.out b28bb75 
  ql/src/test/results/clientpositive/spark/union_top_level.q.out dede1ef 
  ql/src/test/results/clientpositive/tez/tez_union_dynamic_partition.q.out 
68a7531 
  ql/src/test/results/clientpositive/tez/vector_coalesce.q.out 1e01ab5 
  ql/src/test/results/clientpositive/tez/vector_decimal_2.q.out bbdd75f 
  ql/src/test/results/clientpositive/tez/vector_decimal_round_2.q.out 103fd8a 
  ql/src/test/results/clientpositive/tez/vector_interval_1.q.out 1cc7cb6 
  ql/src/test/results/clientpositive/union_remove_12.q.out 3ac1d44 
  ql/src/test/results/clientpositive/union_remove_14.q.out 94f2ff5 
  ql/src/test/results/clientpositive/union_top_level.q.out c64e792 
  ql/src/test/results/clientpositive/vector_coalesce.q.out eb5f204 
  ql/src/test/results/clientpositive/vector_decimal_2.q.out c0112a9 
  ql/src/test/results/clientpositive/vector_decimal_round_2.q.out 6947059 
  ql/src/test/results/clientpositive/vector_interval_1.q.out 5015916 

Diff: https://reviews.apache.org/r/35899/diff/


Testing
---

Added new test  pre-existing ones.


Thanks,

Ashutosh Chauhan