Re: Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/ --- (Updated July 9, 2015, 3:07 p.m.) Review request for hive and Xuefu Zhang. Changes --- Summary for V2: 1. Add the fields of conf in beelineOpts which is used to parsing client side configuration 2. Add new API to update the configuration in client side Bugs: HIVE-11191 https://issues.apache.org/jira/browse/HIVE-11191 Repository: hive-git Description --- Summary: 1. Add option update stage after connection established in CLI mode 2. Update the getHiveConf API Diffs (updated) - beeline/src/java/org/apache/hive/beeline/BeeLine.java c4dbcd4 beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a beeline/src/java/org/apache/hive/beeline/Commands.java d490273 beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 Diff: https://reviews.apache.org/r/36300/diff/ Testing --- Partial UT passed and local cluster test passed. Thanks, cheng xu
Re: Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/#review91240 --- Ship it! Ship It! - Xuefu Zhang On July 9, 2015, 7:07 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/ --- (Updated July 9, 2015, 7:07 a.m.) Review request for hive and Xuefu Zhang. Bugs: HIVE-11191 https://issues.apache.org/jira/browse/HIVE-11191 Repository: hive-git Description --- Summary: 1. Add option update stage after connection established in CLI mode 2. Update the getHiveConf API Diffs - beeline/src/java/org/apache/hive/beeline/BeeLine.java c4dbcd4 beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a beeline/src/java/org/apache/hive/beeline/Commands.java d490273 beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 Diff: https://reviews.apache.org/r/36300/diff/ Testing --- Partial UT passed and local cluster test passed. Thanks, cheng xu
Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/ --- Review request for hive and Xuefu Zhang. Bugs: HIVE-11191 https://issues.apache.org/jira/browse/HIVE-11191 Repository: hive-git Description --- Summary: 1. Add option update stage after connection established in CLI mode 2. Update the getHiveConf API Diffs - beeline/src/java/org/apache/hive/beeline/BeeLine.java 1d468eb beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a beeline/src/java/org/apache/hive/beeline/Commands.java d490273 beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 Diff: https://reviews.apache.org/r/36300/diff/ Testing --- Partial UT passed and local cluster test passed. Thanks, cheng xu
Re: Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/#review90889 --- beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java (line 228) https://reviews.apache.org/r/36300/#comment144056 Since we are getting configurations when connection is first made, we should probably store them for later use so that we don't need to make another again. beeline/src/java/org/apache/hive/beeline/Commands.java (line 759) https://reviews.apache.org/r/36300/#comment144054 Why do we provide two way to do the same thing? When do we choose to use one or the other? - Xuefu Zhang On July 8, 2015, 8:44 a.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/ --- (Updated July 8, 2015, 8:44 a.m.) Review request for hive and Xuefu Zhang. Bugs: HIVE-11191 https://issues.apache.org/jira/browse/HIVE-11191 Repository: hive-git Description --- Summary: 1. Add option update stage after connection established in CLI mode 2. Update the getHiveConf API Diffs - beeline/src/java/org/apache/hive/beeline/BeeLine.java 1d468eb beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a beeline/src/java/org/apache/hive/beeline/Commands.java d490273 beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 Diff: https://reviews.apache.org/r/36300/diff/ Testing --- Partial UT passed and local cluster test passed. Thanks, cheng xu
Re: Review Request 36300: HIVE-11191 Beeline-cli: support hive.cli.errors.ignore in new CLI
On July 8, 2015, 9:27 p.m., Xuefu Zhang wrote: beeline/src/java/org/apache/hive/beeline/Commands.java, line 759 https://reviews.apache.org/r/36300/diff/1/?file=1002091#file1002091line759 Why do we provide two way to do the same thing? When do we choose to use one or the other? This part of code is very tricky and blocked me quite some time. If you use the call method, seems data is not synchronized with the server side. And if you use the sql method, it will override the console of the beeline. I referred the code logic from executeInternal method. To be honest, I am not quite follow the original purpose of this code logic but it works. - cheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/#review90889 --- On July 8, 2015, 4:44 p.m., cheng xu wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36300/ --- (Updated July 8, 2015, 4:44 p.m.) Review request for hive and Xuefu Zhang. Bugs: HIVE-11191 https://issues.apache.org/jira/browse/HIVE-11191 Repository: hive-git Description --- Summary: 1. Add option update stage after connection established in CLI mode 2. Update the getHiveConf API Diffs - beeline/src/java/org/apache/hive/beeline/BeeLine.java 1d468eb beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java c1ec82a beeline/src/java/org/apache/hive/beeline/Commands.java d490273 beeline/src/test/org/apache/hive/beeline/cli/TestHiveCli.java ff8ab17 Diff: https://reviews.apache.org/r/36300/diff/ Testing --- Partial UT passed and local cluster test passed. Thanks, cheng xu
