Re: Review Request 42521: HIVE-12867 : Semantic Exception Error Msg should be with in the range of "10000 to 19999"

2016-01-21 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42521/#review115755
---

Ship it!


Ship It!

- John Pullokkaran


On Jan. 21, 2016, 11:08 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42521/
> ---
> 
> (Updated Jan. 21, 2016, 11:08 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Semantic Exception Error Msg should be with in the range of "1 to 1"
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 6a62592 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 8a9411a 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 141c2e6 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 179f9c2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java 
> ff385d0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
> 88c4b95 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 
> 
> Diff: https://reviews.apache.org/r/42521/diff/
> 
> 
> Testing
> ---
> 
> Precommit build runs
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 42521: HIVE-12867 : Semantic Exception Error Msg should be with in the range of "10000 to 19999"

2016-01-21 Thread Hari Sankar Sivarama Subramaniyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42521/
---

(Updated Jan. 21, 2016, 11:08 p.m.)


Review request for hive and John Pullokkaran.


Repository: hive-git


Description
---

Semantic Exception Error Msg should be with in the range of "1 to 1"


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 6a62592 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 8a9411a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 141c2e6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 179f9c2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java 
ff385d0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
88c4b95 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 

Diff: https://reviews.apache.org/r/42521/diff/


Testing
---

Precommit build runs


Thanks,

Hari Sankar Sivarama Subramaniyan

Re: Review Request 42521: HIVE-12867 : Semantic Exception Error Msg should be with in the range of "10000 to 19999"

2016-01-19 Thread Hari Sankar Sivarama Subramaniyan 


> On Jan. 19, 2016, 9:16 p.m., John Pullokkaran wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java, line 445
> > 
> >
> > May be change this to "Semantic error"
> > Also why do we need a generic error

Thanks for the review, John. Will change to Semantic error in the next patch. 

Generic Error is still required when we throw HiveExceptions from DDLTask, e.g. 
DDLTask::showTables() where we use MetaDataFormatter to retrieve the resultset. 
In short, Generic Error message is used in places other than SemanticException 
such as HiveException and cannot be totally removed.


- Hari Sankar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42521/#review115235
---


On Jan. 19, 2016, 9:03 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42521/
> ---
> 
> (Updated Jan. 19, 2016, 9:03 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Semantic Exception Error Msg should be with in the range of "1 to 1"
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 6a62592 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 8a9411a 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 5e6b606 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 179f9c2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java 
> ff385d0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
> 88c4b95 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 
> 
> Diff: https://reviews.apache.org/r/42521/diff/
> 
> 
> Testing
> ---
> 
> Precommit build runs
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 42521: HIVE-12867 : Semantic Exception Error Msg should be with in the range of "10000 to 19999"

2016-01-19 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42521/#review115235
---



ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java (line 445)


May be change this to "Semantic error"
Also why do we need a generic error


- John Pullokkaran


On Jan. 19, 2016, 9:03 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42521/
> ---
> 
> (Updated Jan. 19, 2016, 9:03 p.m.)
> 
> 
> Review request for hive and John Pullokkaran.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Semantic Exception Error Msg should be with in the range of "1 to 1"
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 6a62592 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 8a9411a 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 5e6b606 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 179f9c2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java 
> ff385d0 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
> 88c4b95 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 
> 
> Diff: https://reviews.apache.org/r/42521/diff/
> 
> 
> Testing
> ---
> 
> Precommit build runs
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Review Request 42521: HIVE-12867 : Semantic Exception Error Msg should be with in the range of "10000 to 19999"

2016-01-19 Thread Hari Sankar Sivarama Subramaniyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42521/
---

Review request for hive and John Pullokkaran.


Repository: hive-git


Description
---

Semantic Exception Error Msg should be with in the range of "1 to 1"


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 6a62592 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 8a9411a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 5e6b606 
  ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 179f9c2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java 
ff385d0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java 
88c4b95 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java a8f9f50 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java 3f38f74 

Diff: https://reviews.apache.org/r/42521/diff/


Testing
---

Precommit build runs


Thanks,

Hari Sankar Sivarama Subramaniyan