Re: Review Request 46913: HIVE-13351 : Support drop Primary Key/Foreign Key constraints

2016-05-03 Thread Hari Sankar Sivarama Subramaniyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46913/
---

(Updated May 3, 2016, 7:14 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
---

Incorporated Ashutosh's comments


Repository: hive-git


Description
---

Support drop Primary Key/Foreign Key constraints


Diffs (updated)
-

  metastore/if/hive_metastore.thrift acebf7a 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
4ada9c1 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
7d37d07 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
c900a2d 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f651a13 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 100c396 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
d4e5da4 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
 86e7bea 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
 5b32f00 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9887d77 
  ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 515f8b2 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 26c458c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 04e2a41 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6531b03 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
fb8a33c 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 4ba51ec 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 188cd6f 
  ql/src/test/queries/clientnegative/drop_invalid_constraint1.q PRE-CREATION 
  ql/src/test/queries/clientnegative/drop_invalid_constraint2.q PRE-CREATION 
  ql/src/test/queries/clientnegative/drop_invalid_constraint3.q PRE-CREATION 
  ql/src/test/queries/clientnegative/drop_invalid_constraint4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 
  ql/src/test/results/clientnegative/drop_invalid_constraint1.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/drop_invalid_constraint2.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/drop_invalid_constraint3.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/drop_invalid_constraint4.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 
  service/src/gen/thrift/gen-py/__init__.py e69de29 

Diff: https://reviews.apache.org/r/46913/diff/


Testing
---


Thanks,

Hari Sankar Sivarama Subramaniyan

Re: Review Request 46913: HIVE-13351 : Support drop Primary Key/Foreign Key constraints

2016-05-02 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46913/#review131436
---




metastore/if/hive_metastore.thrift (lines 996 - 997)


Can you follow request/response pattern for this? Ensures forward 
compatibility.



ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 3298)


Caller does db.alterTable() so, passing in Hive object to do 
db.dropConstraint() is confusing, as db.alterTable() will get executed which 
doesn't serve any purpose.
Cleaner will be caller calls different function than this which avoids 
alterTable() in caller.



ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java (line 118)


Privileges on input should be defined. ALTER_METADATA ?



ql/src/test/queries/clientpositive/create_with_constraints.q (line 16)


Can you add test for dbName.TableName ?


- Ashutosh Chauhan


On May 2, 2016, 10:23 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46913/
> ---
> 
> (Updated May 2, 2016, 10:23 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Support drop Primary Key/Foreign Key constraints
> 
> 
> Diffs
> -
> 
>   metastore/if/hive_metastore.thrift acebf7a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> 4ada9c1 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> 7d37d07 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> c900a2d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
> 744512f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> f651a13 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 100c396 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
> d4e5da4 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  86e7bea 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  5b32f00 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 515f8b2 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 04e2a41 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6531b03 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
> fb8a33c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 4ba51ec 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 188cd6f 
>   ql/src/test/queries/clientnegative/drop_invalid_constraint1.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/drop_invalid_constraint2.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/drop_invalid_constraint3.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/drop_invalid_constraint4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 
>   ql/src/test/results/clientnegative/drop_invalid_constraint1.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/drop_invalid_constraint2.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/drop_invalid_constraint3.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/drop_invalid_constraint4.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 
>   service/src/gen/thrift/gen-py/__init__.py e69de29 
> 
> Diff: https://reviews.apache.org/r/46913/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Re: Review Request 46913: HIVE-13351 : Support drop Primary Key/Foreign Key constraints

2016-05-02 Thread Hari Sankar Sivarama Subramaniyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46913/#review131402
---




metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
(line 1822)


Please discard all the diffs in MetaStoreDirectSql.java. The change was 
added  by mistake and is not part of this jira.


- Hari Sankar Sivarama Subramaniyan


On May 2, 2016, 10:23 p.m., Hari Sankar Sivarama Subramaniyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46913/
> ---
> 
> (Updated May 2, 2016, 10:23 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Support drop Primary Key/Foreign Key constraints
> 
> 
> Diffs
> -
> 
>   metastore/if/hive_metastore.thrift acebf7a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> 4ada9c1 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
> 7d37d07 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
> c900a2d 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
> 744512f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> f651a13 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 100c396 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
> d4e5da4 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  86e7bea 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  5b32f00 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc 
>   ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 515f8b2 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 04e2a41 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6531b03 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
> fb8a33c 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 4ba51ec 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 188cd6f 
>   ql/src/test/queries/clientnegative/drop_invalid_constraint1.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/drop_invalid_constraint2.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/drop_invalid_constraint3.q PRE-CREATION 
>   ql/src/test/queries/clientnegative/drop_invalid_constraint4.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 
>   ql/src/test/results/clientnegative/drop_invalid_constraint1.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/drop_invalid_constraint2.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/drop_invalid_constraint3.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientnegative/drop_invalid_constraint4.q.out 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 
>   service/src/gen/thrift/gen-py/__init__.py e69de29 
> 
> Diff: https://reviews.apache.org/r/46913/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Hari Sankar Sivarama Subramaniyan
> 
>

Review Request 46913: HIVE-13351 : Support drop Primary Key/Foreign Key constraints

2016-05-02 Thread Hari Sankar Sivarama Subramaniyan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46913/
---

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
---

Support drop Primary Key/Foreign Key constraints


Diffs
-

  metastore/if/hive_metastore.thrift acebf7a 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
4ada9c1 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
7d37d07 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
c900a2d 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java 
744512f 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java f651a13 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 100c396 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
d4e5da4 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
 86e7bea 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
 5b32f00 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 39a1efc 
  ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 515f8b2 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 4d9c3d2 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 04e2a41 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 6531b03 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
fb8a33c 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 4ba51ec 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 188cd6f 
  ql/src/test/queries/clientnegative/drop_invalid_constraint1.q PRE-CREATION 
  ql/src/test/queries/clientnegative/drop_invalid_constraint2.q PRE-CREATION 
  ql/src/test/queries/clientnegative/drop_invalid_constraint3.q PRE-CREATION 
  ql/src/test/queries/clientnegative/drop_invalid_constraint4.q PRE-CREATION 
  ql/src/test/queries/clientpositive/create_with_constraints.q eef0c64 
  ql/src/test/results/clientnegative/drop_invalid_constraint1.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/drop_invalid_constraint2.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/drop_invalid_constraint3.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/drop_invalid_constraint4.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/create_with_constraints.q.out 5cf8d83 
  service/src/gen/thrift/gen-py/__init__.py e69de29 

Diff: https://reviews.apache.org/r/46913/diff/


Testing
---


Thanks,

Hari Sankar Sivarama Subramaniyan