Re: Review Request 47196: HIVE-13350: Support Alter commands for Rely/NoRely novalidate for PK/FK constraints

2016-05-10 Thread Hari Sankar Sivarama Subramaniyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47196/
---

(Updated May 11, 2016, 3:04 a.m.)


Review request for hive and Ashutosh Chauhan.


Changes
---

Added -ve test cases.


Repository: hive-git


Description
---

Support Alter commands for Rely/NoRely novalidate for PK/FK constraints


Diffs (updated)
-

  metastore/if/hive_metastore.thrift 2eac836 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
8d4e8f3 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
3a63551 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
68972fb 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java fea4fc5 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 07d8119 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
e97d4a9 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
 7f4b77e 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
 25ccced 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 0204fcd 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 981b961 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 7fcbd6a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0a892e8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 685ab6a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
23a7f6e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 38d8d5a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java c6044b9 
  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java
 810da48 
  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java
 3f138fb 
  ql/src/test/queries/clientnegative/alter_table_constraint_duplicate_pk.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/alter_table_constraint_invalid_fk_col1.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/alter_table_constraint_invalid_fk_col2.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/alter_table_constraint_invalid_fk_tbl1.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/alter_table_constraint_invalid_fk_tbl2.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/alter_table_constraint_invalid_pk_col.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/alter_table_constraint_invalid_pk_tbl.q 
PRE-CREATION 
  ql/src/test/queries/clientpositive/create_with_constraints.q 7aabf74 
  ql/src/test/results/clientnegative/alter_table_constraint_duplicate_pk.q.out 
PRE-CREATION 
  
ql/src/test/results/clientnegative/alter_table_constraint_invalid_fk_col1.q.out 
PRE-CREATION 
  
ql/src/test/results/clientnegative/alter_table_constraint_invalid_fk_col2.q.out 
PRE-CREATION 
  
ql/src/test/results/clientnegative/alter_table_constraint_invalid_fk_tbl1.q.out 
PRE-CREATION 
  
ql/src/test/results/clientnegative/alter_table_constraint_invalid_fk_tbl2.q.out 
PRE-CREATION 
  
ql/src/test/results/clientnegative/alter_table_constraint_invalid_pk_col.q.out 
PRE-CREATION 
  
ql/src/test/results/clientnegative/alter_table_constraint_invalid_pk_tbl.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/create_with_constraints.q.out 34dac30 

Diff: https://reviews.apache.org/r/47196/diff/


Testing
---

Local testing done.


Thanks,

Hari Sankar Sivarama Subramaniyan



Review Request 47196: HIVE-13350: Support Alter commands for Rely/NoRely novalidate for PK/FK constraints

2016-05-10 Thread Hari Sankar Sivarama Subramaniyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47196/
---

Review request for hive and Ashutosh Chauhan.


Repository: hive-git


Description
---

Support Alter commands for Rely/NoRely novalidate for PK/FK constraints


Diffs
-

  metastore/if/hive_metastore.thrift 2eac836 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
8d4e8f3 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 
3a63551 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
68972fb 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java fea4fc5 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 07d8119 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 
e97d4a9 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
 7f4b77e 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
 25ccced 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 0204fcd 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 981b961 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 7fcbd6a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0a892e8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 685ab6a 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 
23a7f6e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterTableDesc.java 38d8d5a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java c6044b9 
  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveOperationType.java
 810da48 
  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/Operation2Privilege.java
 3f138fb 
  ql/src/test/queries/clientpositive/create_with_constraints.q 7aabf74 
  ql/src/test/results/clientpositive/create_with_constraints.q.out 34dac30 

Diff: https://reviews.apache.org/r/47196/diff/


Testing
---

Local testing done.


Thanks,

Hari Sankar Sivarama Subramaniyan