Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Sergio Pena]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/#review183136
---


Ship it!




Ship It!

- Sergio Pena


On Aug. 17, 2017, 7:56 a.m., Barna Zsombor Klara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60085/
> ---
> 
> (Updated Aug. 17, 2017, 7:56 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.
> 
> 
> Bugs: HIVE-14747
> https://issues.apache.org/jira/browse/HIVE-14747
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
> 
> 
> Diffs
> -
> 
>   testutils/ptest2/conf/server-env.properties.example PRE-CREATION 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
>  2f96ad03023e9f51d44d203f34edd04183605a22 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
>  b2c61f03c5bf5f170894141848c89fc26129115a 
>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
> 1cdfdb309acd8282e593abd7ed10c87721926c60 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
>  14984bafdd18fb7636e729cc7fbbfa349b0f043e 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java
>  35ddd44accf34be1f5957c6df31802ee8c8022b5 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
>  e584f9c105fa134e3e267d6c6817d441b4c6b249 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java
>  a243774e52f3f5fda4a082bb99387cf5808c307b 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java
>  b97b890dfe855539de2696788327ba9b4a841ff3 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java
>  PRE-CREATION 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
>  848faf27af1ed8945d7013b6562bab544605e4bc 
> 
> 
> Diff: https://reviews.apache.org/r/60085/diff/6/
> 
> 
> Testing
> ---
> 
> Added unit tests for the Context class.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Barna Zsombor Klara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/
---

(Updated Aug. 17, 2017, 7:56 a.m.)


Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.


Changes
---

Added server-env.properties.example.


Bugs: HIVE-14747
https://issues.apache.org/jira/browse/HIVE-14747


Repository: hive-git


Description
---

HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client


Diffs (updated)
-

  testutils/ptest2/conf/server-env.properties.example PRE-CREATION 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
 2f96ad03023e9f51d44d203f34edd04183605a22 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
 b2c61f03c5bf5f170894141848c89fc26129115a 
  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
1cdfdb309acd8282e593abd7ed10c87721926c60 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
 14984bafdd18fb7636e729cc7fbbfa349b0f043e 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java
 35ddd44accf34be1f5957c6df31802ee8c8022b5 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
 e584f9c105fa134e3e267d6c6817d441b4c6b249 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java
 a243774e52f3f5fda4a082bb99387cf5808c307b 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java
 b97b890dfe855539de2696788327ba9b4a841ff3 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java
 PRE-CREATION 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
 848faf27af1ed8945d7013b6562bab544605e4bc 


Diff: https://reviews.apache.org/r/60085/diff/6/

Changes: https://reviews.apache.org/r/60085/diff/5-6/


Testing
---

Added unit tests for the Context class.


Thanks,

Barna Zsombor Klara

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Sergio Pena]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/#review183060
---



Thanks Zsombor, just two more comments:
- There is an example for the cloudhost.properties file on 
hive/testutils/ptest2/conf/cloudhost.properties.example. Can we provide an 
example for the server properties as well? 
- How is the ptest server configured to pass the server properties? I'm trying 
to figure it out from the code (I see that using command line parameters and 
another place as an environment variable). Could you give an example?

- Sergio Pena


On Aug. 8, 2017, 12:50 p.m., Barna Zsombor Klara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60085/
> ---
> 
> (Updated Aug. 8, 2017, 12:50 p.m.)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.
> 
> 
> Bugs: HIVE-14747
> https://issues.apache.org/jira/browse/HIVE-14747
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
> 
> 
> Diffs
> -
> 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
>  2f96ad03023e9f51d44d203f34edd04183605a22 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
>  b2c61f03c5bf5f170894141848c89fc26129115a 
>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
> 1cdfdb309acd8282e593abd7ed10c87721926c60 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
>  14984bafdd18fb7636e729cc7fbbfa349b0f043e 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java
>  35ddd44accf34be1f5957c6df31802ee8c8022b5 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
>  e584f9c105fa134e3e267d6c6817d441b4c6b249 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java
>  a243774e52f3f5fda4a082bb99387cf5808c307b 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java
>  b97b890dfe855539de2696788327ba9b4a841ff3 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java
>  PRE-CREATION 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
>  848faf27af1ed8945d7013b6562bab544605e4bc 
> 
> 
> Diff: https://reviews.apache.org/r/60085/diff/5/
> 
> 
> Testing
> ---
> 
> Added unit tests for the Context class.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Barna Zsombor Klara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/
---

(Updated Aug. 8, 2017, 12:50 p.m.)


Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.


Changes
---

Addressed comments from Sergio Pena. Thank you for the review!


Bugs: HIVE-14747
https://issues.apache.org/jira/browse/HIVE-14747


Repository: hive-git


Description
---

HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client


Diffs (updated)
-

  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
 2f96ad03023e9f51d44d203f34edd04183605a22 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
 b2c61f03c5bf5f170894141848c89fc26129115a 
  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
1cdfdb309acd8282e593abd7ed10c87721926c60 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
 14984bafdd18fb7636e729cc7fbbfa349b0f043e 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java
 35ddd44accf34be1f5957c6df31802ee8c8022b5 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
 e584f9c105fa134e3e267d6c6817d441b4c6b249 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java
 a243774e52f3f5fda4a082bb99387cf5808c307b 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java
 b97b890dfe855539de2696788327ba9b4a841ff3 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java
 PRE-CREATION 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
 848faf27af1ed8945d7013b6562bab544605e4bc 


Diff: https://reviews.apache.org/r/60085/diff/4/

Changes: https://reviews.apache.org/r/60085/diff/3-4/


Testing
---

Added unit tests for the Context class.


Thanks,

Barna Zsombor Klara

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Sergio Pena]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/#review182271
---



How are we getting the Java variable information from the new code? I see we 
initialize a couple of classes with a specific context that may have a server 
environment file context, but how are we getting Java info from such context?

- Sergio Pena


On July 31, 2017, 8:05 a.m., Barna Zsombor Klara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60085/
> ---
> 
> (Updated July 31, 2017, 8:05 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
> 
> 
> Diffs
> -
> 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
>  2f96ad03023e9f51d44d203f34edd04183605a22 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
>  b2c61f03c5bf5f170894141848c89fc26129115a 
>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
> 1cdfdb309acd8282e593abd7ed10c87721926c60 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
>  14984bafdd18fb7636e729cc7fbbfa349b0f043e 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java
>  35ddd44accf34be1f5957c6df31802ee8c8022b5 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
>  e584f9c105fa134e3e267d6c6817d441b4c6b249 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java
>  a243774e52f3f5fda4a082bb99387cf5808c307b 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java
>  b97b890dfe855539de2696788327ba9b4a841ff3 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java
>  PRE-CREATION 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
>  848faf27af1ed8945d7013b6562bab544605e4bc 
> 
> 
> Diff: https://reviews.apache.org/r/60085/diff/3/
> 
> 
> Testing
> ---
> 
> Added unit tests for the Context class.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Sergio Pena]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/#review182270
---




testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
Lines 120 (patched)


is there another wayt to get the file instead of the system environment 
variables?

How do we get the cloud execution properties file?



testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
Lines 266 (patched)


Can you add javadoc to all the new public methods and ContextBuilder?


- Sergio Pena


On July 31, 2017, 8:05 a.m., Barna Zsombor Klara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60085/
> ---
> 
> (Updated July 31, 2017, 8:05 a.m.)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
> 
> 
> Diffs
> -
> 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
>  2f96ad03023e9f51d44d203f34edd04183605a22 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
>  b2c61f03c5bf5f170894141848c89fc26129115a 
>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
> 1cdfdb309acd8282e593abd7ed10c87721926c60 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
>  14984bafdd18fb7636e729cc7fbbfa349b0f043e 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java
>  35ddd44accf34be1f5957c6df31802ee8c8022b5 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
>  e584f9c105fa134e3e267d6c6817d441b4c6b249 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java
>  a243774e52f3f5fda4a082bb99387cf5808c307b 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java
>  b97b890dfe855539de2696788327ba9b4a841ff3 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java
>  PRE-CREATION 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
>  848faf27af1ed8945d7013b6562bab544605e4bc 
> 
> 
> Diff: https://reviews.apache.org/r/60085/diff/3/
> 
> 
> Testing
> ---
> 
> Added unit tests for the Context class.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Barna Zsombor Klara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/
---

(Updated July 31, 2017, 8:05 a.m.)


Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.


Changes
---

Refactored based on offline comments from Sergio Pena.


Repository: hive-git


Description
---

HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client


Diffs (updated)
-

  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/ExecutionController.java
 2f96ad03023e9f51d44d203f34edd04183605a22 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
 b2c61f03c5bf5f170894141848c89fc26129115a 
  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
1cdfdb309acd8282e593abd7ed10c87721926c60 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/Context.java
 14984bafdd18fb7636e729cc7fbbfa349b0f043e 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/ExecutionContextConfiguration.java
 35ddd44accf34be1f5957c6df31802ee8c8022b5 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
 e584f9c105fa134e3e267d6c6817d441b4c6b249 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestParser.java
 a243774e52f3f5fda4a082bb99387cf5808c307b 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/TestJIRAService.java
 b97b890dfe855539de2696788327ba9b4a841ff3 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestContext.java
 PRE-CREATION 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
 848faf27af1ed8945d7013b6562bab544605e4bc 


Diff: https://reviews.apache.org/r/60085/diff/3/

Changes: https://reviews.apache.org/r/60085/diff/2-3/


Testing (updated)
---

Added unit tests for the Context class.


Thanks,

Barna Zsombor Klara

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Peter Vary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/#review180194
---


Ship it!




Ship It!

- Peter Vary


On June 14, 2017, 2:38 p.m., Barna Zsombor Klara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60085/
> ---
> 
> (Updated June 14, 2017, 2:38 p.m.)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
> 
> 
> Diffs
> -
> 
>   testutils/ptest2/conf/deployed/master-mr2.properties 
> 05c040599172caf9d67c4e27affce12a335dab4b 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
>  8e2604d372ac29b94445b269f08423b058308efe 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java
>  8deed52ae0307d4fc075654a4d75e6cb09a5d9db 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
>  b2c61f03c5bf5f170894141848c89fc26129115a 
>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
> 1cdfdb309acd8282e593abd7ed10c87721926c60 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
>  e584f9c105fa134e3e267d6c6817d441b4c6b249 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
>  848faf27af1ed8945d7013b6562bab544605e4bc 
> 
> 
> Diff: https://reviews.apache.org/r/60085/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested PTestClient.
> Updated unit tests for the code in TestConfiguration.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Barna Zsombor Klara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/
---

(Updated June 14, 2017, 2:38 p.m.)


Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.


Changes
---

Updated comments and javadoc.


Repository: hive-git


Description
---

HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client


Diffs (updated)
-

  testutils/ptest2/conf/deployed/master-mr2.properties 
05c040599172caf9d67c4e27affce12a335dab4b 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
 8e2604d372ac29b94445b269f08423b058308efe 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java
 8deed52ae0307d4fc075654a4d75e6cb09a5d9db 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
 b2c61f03c5bf5f170894141848c89fc26129115a 
  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
1cdfdb309acd8282e593abd7ed10c87721926c60 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
 e584f9c105fa134e3e267d6c6817d441b4c6b249 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
 848faf27af1ed8945d7013b6562bab544605e4bc 


Diff: https://reviews.apache.org/r/60085/diff/2/

Changes: https://reviews.apache.org/r/60085/diff/1-2/


Testing
---

Manually tested PTestClient.
Updated unit tests for the code in TestConfiguration.


Thanks,

Barna Zsombor Klara

Re: Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Peter Vary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/#review177889
---



Thanks Zsombor for the patch.

Overall looks good to me, just one comment.

Thanks,
Peter


testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
Lines 38-39 (patched)


Would be nice to have a usage comment somewhere


- Peter Vary


On June 14, 2017, 2:04 p.m., Barna Zsombor Klara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60085/
> ---
> 
> (Updated June 14, 2017, 2:04 p.m.)
> 
> 
> Review request for hive, Marta Kuczora, Peter Vary, and Sergio Pena.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client
> 
> 
> Diffs
> -
> 
>   testutils/ptest2/conf/deployed/master-mr2.properties 
> 05c040599172caf9d67c4e27affce12a335dab4b 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
>  8e2604d372ac29b94445b269f08423b058308efe 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java
>  8deed52ae0307d4fc075654a4d75e6cb09a5d9db 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
>  b2c61f03c5bf5f170894141848c89fc26129115a 
>   testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
> 1cdfdb309acd8282e593abd7ed10c87721926c60 
>   
> testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
>  e584f9c105fa134e3e267d6c6817d441b4c6b249 
>   
> testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
>  848faf27af1ed8945d7013b6562bab544605e4bc 
> 
> 
> Diff: https://reviews.apache.org/r/60085/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested PTestClient.
> Updated unit tests for the code in TestConfiguration.
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Review Request 60085: HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client

[Barna Zsombor Klara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60085/
---

Review request for hive, Peter Vary and Sergio Pena.


Repository: hive-git


Description
---

HIVE-14747: Remove JAVA paths from profiles by sending them from ptest-client


Diffs
-

  testutils/ptest2/conf/deployed/master-mr2.properties 
05c040599172caf9d67c4e27affce12a335dab4b 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/client/PTestClient.java
 8e2604d372ac29b94445b269f08423b058308efe 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/request/TestStartRequest.java
 8deed52ae0307d4fc075654a4d75e6cb09a5d9db 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/api/server/TestExecutor.java
 b2c61f03c5bf5f170894141848c89fc26129115a 
  testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/PTest.java 
1cdfdb309acd8282e593abd7ed10c87721926c60 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/conf/TestConfiguration.java
 e584f9c105fa134e3e267d6c6817d441b4c6b249 
  
testutils/ptest2/src/test/java/org/apache/hive/ptest/execution/conf/TestTestConfiguration.java
 848faf27af1ed8945d7013b6562bab544605e4bc 


Diff: https://reviews.apache.org/r/60085/diff/1/


Testing
---

Manually tested PTestClient.
Updated unit tests for the code in TestConfiguration.


Thanks,

Barna Zsombor Klara