Re: Review Request 61712: HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml

[Barna Zsombor Klara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61712/
---

(Updated Aug. 21, 2017, 12:59 p.m.)


Review request for hive, Eugene Koifman, Peter Vary, and Thejas Nair.


Changes
---

Patch has been rebased and HiveConf variables substituted with MetastoreConf.


Bugs: HIVE-17319
https://issues.apache.org/jira/browse/HIVE-17319


Repository: hive-git


Description
---

HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
8724930b77da9f8ae81053000d24e386b5a581c8 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
b87811502beac1143fbc0ba1e8daf2079562e7b3 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProvider.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/package-info.java
 PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 
f3968e45c4bef2676c2000c17b3e8e6ea5761017 
  
metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61712/diff/3/

Changes: https://reviews.apache.org/r/61712/diff/2-3/


Testing
---


Thanks,

Barna Zsombor Klara

Re: Review Request 61712: HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml

[Peter Vary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61712/#review183235
---


Ship it!




Ship It!

- Peter Vary


On Aug. 18, 2017, 2:37 p.m., Barna Zsombor Klara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61712/
> ---
> 
> (Updated Aug. 18, 2017, 2:37 p.m.)
> 
> 
> Review request for hive, Eugene Koifman, Peter Vary, and Thejas Nair.
> 
> 
> Bugs: HIVE-17319
> https://issues.apache.org/jira/browse/HIVE-17319
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml
> 
> 
> Diffs
> -
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> 897fc4efd4c541ee2da30516c933647f5d4a0af4 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java
>  PRE-CREATION 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProvider.java
>  PRE-CREATION 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java
>  PRE-CREATION 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/package-info.java
>  PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 
> b722af6ceb8375c76c3a393cee79ed2387555b69 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61712/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Re: Review Request 61712: HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml

[Barna Zsombor Klara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61712/
---

(Updated Aug. 18, 2017, 2:37 p.m.)


Review request for hive, Eugene Koifman, Peter Vary, and Thejas Nair.


Changes
---

Updated the patch based on the review and Yetus report. Thank you for the 
review Peter.


Bugs: HIVE-17319
https://issues.apache.org/jira/browse/HIVE-17319


Repository: hive-git


Description
---

HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml


Diffs (updated)
-

  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
897fc4efd4c541ee2da30516c933647f5d4a0af4 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProvider.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/package-info.java
 PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 
b722af6ceb8375c76c3a393cee79ed2387555b69 
  
metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61712/diff/2/

Changes: https://reviews.apache.org/r/61712/diff/1-2/


Testing
---


Thanks,

Barna Zsombor Klara

Re: Review Request 61712: HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml

[Peter Vary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61712/#review183137
---



It is a bigger patch, you might want to run yetus to see if it has any comments 
:)

Otherwise I like your approach.
One question below.

Thanks,
Peter


metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 550 (patched)


Why not use the HashMap(Map m) constructor to use 
the defaults?


- Peter Vary


On Aug. 17, 2017, 2:27 p.m., Barna Zsombor Klara wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61712/
> ---
> 
> (Updated Aug. 17, 2017, 2:27 p.m.)
> 
> 
> Review request for hive, Eugene Koifman, Peter Vary, and Thejas Nair.
> 
> 
> Bugs: HIVE-17319
> https://issues.apache.org/jira/browse/HIVE-17319
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml
> 
> 
> Diffs
> -
> 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
> 897fc4efd4c541ee2da30516c933647f5d4a0af4 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java
>  PRE-CREATION 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProvider.java
>  PRE-CREATION 
>   
> metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java
>  PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 
> b722af6ceb8375c76c3a393cee79ed2387555b69 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61712/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Barna Zsombor Klara
> 
>

Review Request 61712: HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml

[Barna Zsombor Klara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61712/
---

Review request for hive, Eugene Koifman, Peter Vary, and Thejas Nair.


Bugs: HIVE-17319
https://issues.apache.org/jira/browse/HIVE-17319


Repository: hive-git


Description
---

HIVE-17319: Make BoneCp configurable using hive properties in hive-site.xml


Diffs
-

  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 
897fc4efd4c541ee2da30516c933647f5d4a0af4 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/BoneCPDataSourceProvider.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProvider.java
 PRE-CREATION 
  
metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java
 PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java 
b722af6ceb8375c76c3a393cee79ed2387555b69 
  
metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/61712/diff/1/


Testing
---


Thanks,

Barna Zsombor Klara