Re: Review Request 61976: HIVE-17409 refactor LLAP ZK registry to make the ZK-registry part reusable

2017-08-31 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61976/
---

(Updated Sept. 1, 2017, 3:16 a.m.)


Review request for hive and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/LlapServiceInstanceSet.java
 PRE-CREATION 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java 
70515c4ad3 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceSet.java
 cc124e76ee 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceStateChangeListener.java
 92eb8bdd13 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceRegistry.java 
5739d72994 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/InactiveServiceInstance.java
 9f2f3b4c3b 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
 ebc32a155c 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
 76fc9c73a2 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java
 ad17144177 
  
llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClient.java 
ace94759ac 
  llap-client/src/java/org/apache/hadoop/hive/registry/ServiceInstance.java 
PRE-CREATION 
  
llap-client/src/java/org/apache/hadoop/hive/registry/impl/ServiceInstanceBase.java
 PRE-CREATION 
  llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java 
PRE-CREATION 
  llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZookeeperUtils.java 
PRE-CREATION 
  llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java 
201f5fa555 
  
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java
 1b57e38b05 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java
 ebc3437245 
  
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
 ff00aba110 
  
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
 6bedccbd18 
  
llap-tez/src/test/org/apache/hadoop/hive/llap/tezplugins/TestLlapTaskSchedulerService.java
 339f513eb4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/Utils.java 2b57d906a2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java
 a5ed308da1 


Diff: https://reviews.apache.org/r/61976/diff/2/

Changes: https://reviews.apache.org/r/61976/diff/1-2/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 61976: HIVE-17409 refactor LLAP ZK registry to make the ZK-registry part reusable

2017-08-31 Thread Sergey Shelukhin 


> On Sept. 1, 2017, 12:29 a.m., Prasanth_J wrote:
> > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java
> > Lines 488 (patched)
> > 
> >
> > This can be untied. InstanceStateChangeListener can live outside of 
> > registry and can be default listener. Consumers of registry can register 
> > its own listener.

This listener translates the raw ZK events into logical instance events. I 
think it should be inside the registry.


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61976/#review184328
---


On Aug. 29, 2017, 7:45 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61976/
> ---
> 
> (Updated Aug. 29, 2017, 7:45 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/LlapServiceInstanceSet.java
>  PRE-CREATION 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java
>  70515c4ad3 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceSet.java
>  cc124e76ee 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceStateChangeListener.java
>  92eb8bdd13 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceRegistry.java
>  5739d72994 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/InactiveServiceInstance.java
>  9f2f3b4c3b 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
>  ebc32a155c 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
>  76fc9c73a2 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java
>  ad17144177 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClient.java
>  ace94759ac 
>   llap-client/src/java/org/apache/hadoop/hive/registry/ServiceInstance.java 
> PRE-CREATION 
>   
> llap-client/src/java/org/apache/hadoop/hive/registry/impl/ServiceInstanceBase.java
>  PRE-CREATION 
>   
> llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java 
> PRE-CREATION 
>   
> llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java 
> 201f5fa555 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java
>  1b57e38b05 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java
>  ebc3437245 
>   
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
>  ff00aba110 
>   
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
>  6bedccbd18 
>   
> llap-tez/src/test/org/apache/hadoop/hive/llap/tezplugins/TestLlapTaskSchedulerService.java
>  339f513eb4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/Utils.java 2b57d906a2 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java
>  a5ed308da1 
> 
> 
> Diff: https://reviews.apache.org/r/61976/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 61976: HIVE-17409 refactor LLAP ZK registry to make the ZK-registry part reusable

2017-08-31 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61976/#review184328
---




llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java
Lines 220 (patched)


nit: can be moved to util class for reuse.



llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java
Lines 244 (patched)


Does it have to be llap zk user? Can this config be renamed generically?



llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java
Lines 488 (patched)


This can be untied. InstanceStateChangeListener can live outside of 
registry and can be default listener. Consumers of registry can register its 
own listener.



llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java
Lines 595 (patched)


This can be separate class too outside of registry for reuse.


- Prasanth_J


On Aug. 29, 2017, 7:45 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61976/
> ---
> 
> (Updated Aug. 29, 2017, 7:45 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/LlapServiceInstanceSet.java
>  PRE-CREATION 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java
>  70515c4ad3 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceSet.java
>  cc124e76ee 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceStateChangeListener.java
>  92eb8bdd13 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceRegistry.java
>  5739d72994 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/InactiveServiceInstance.java
>  9f2f3b4c3b 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
>  ebc32a155c 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
>  76fc9c73a2 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java
>  ad17144177 
>   
> llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClient.java
>  ace94759ac 
>   llap-client/src/java/org/apache/hadoop/hive/registry/ServiceInstance.java 
> PRE-CREATION 
>   
> llap-client/src/java/org/apache/hadoop/hive/registry/impl/ServiceInstanceBase.java
>  PRE-CREATION 
>   
> llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java 
> PRE-CREATION 
>   
> llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java 
> 201f5fa555 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java
>  1b57e38b05 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java
>  ebc3437245 
>   
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
>  ff00aba110 
>   
> llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
>  6bedccbd18 
>   
> llap-tez/src/test/org/apache/hadoop/hive/llap/tezplugins/TestLlapTaskSchedulerService.java
>  339f513eb4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/Utils.java 2b57d906a2 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java
>  a5ed308da1 
> 
> 
> Diff: https://reviews.apache.org/r/61976/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Review Request 61976: HIVE-17409 refactor LLAP ZK registry to make the ZK-registry part reusable

2017-08-29 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61976/
---

Review request for hive and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs
-

  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/LlapServiceInstanceSet.java
 PRE-CREATION 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstance.java 
70515c4ad3 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceSet.java
 cc124e76ee 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceInstanceStateChangeListener.java
 92eb8bdd13 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/ServiceRegistry.java 
5739d72994 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/InactiveServiceInstance.java
 9f2f3b4c3b 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java
 ebc32a155c 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java
 76fc9c73a2 
  
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java
 ad17144177 
  
llap-client/src/java/org/apache/hadoop/hive/llap/security/LlapTokenClient.java 
ace94759ac 
  llap-client/src/java/org/apache/hadoop/hive/registry/ServiceInstance.java 
PRE-CREATION 
  
llap-client/src/java/org/apache/hadoop/hive/registry/impl/ServiceInstanceBase.java
 PRE-CREATION 
  llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java 
PRE-CREATION 
  llap-ext-client/src/java/org/apache/hadoop/hive/llap/LlapBaseInputFormat.java 
201f5fa555 
  
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapStatusServiceDriver.java
 1b57e38b05 
  
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java
 ebc3437245 
  
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
 ff00aba110 
  
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
 6bedccbd18 
  
llap-tez/src/test/org/apache/hadoop/hive/llap/tezplugins/TestLlapTaskSchedulerService.java
 339f513eb4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/Utils.java 2b57d906a2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapClusterStateForCompile.java
 a5ed308da1 


Diff: https://reviews.apache.org/r/61976/diff/1/


Testing
---


Thanks,

Sergey Shelukhin