Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-08 Thread Harish Jaiprakash 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review190432
---


Ship it!




Ship It!

- Harish Jaiprakash


On Nov. 8, 2017, 2:25 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Nov. 8, 2017, 2:25 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a26ea2115f 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
>  996c0052cf 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
>  012361a186 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql f9b0765916 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 054978e3e4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql a13d976e37 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 1ceb7239eb 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 03ee4cfd64 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 06648540f0 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql a13d976e37 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql a94985a63e 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql e80e6124fc 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> be1bb1eee0 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
> f29a20d44b 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  4df7c97795 
>   
> metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  a41e5a083c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 826ae565c1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
> 9954c249d4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> 169991c639 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 3415a23dec 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8708f2a0b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> 04c9e4413d 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 0347e914bc 
>   ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2f314a6a8d 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 300ba7281d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  7334a0c9fa 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
>  4fe70a35e1 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
>  43d72e4cc9 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
>  f8ebc124c4 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java
>  0c1e7866c0 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  27a1bd8f25 
>   standalone-metastore/src/main/resources/package.jdo b271e026e9 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 9f92bf6be2 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/11/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-07 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Nov. 7, 2017, 8:55 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a26ea2115f 
  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 996c0052cf 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
 012361a186 
  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql f9b0765916 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 054978e3e4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql a13d976e37 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 1ceb7239eb 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 03ee4cfd64 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 06648540f0 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql a13d976e37 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql a94985a63e 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql e80e6124fc 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql be1bb1eee0 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
f29a20d44b 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
 4df7c97795 
  
metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
 a41e5a083c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 826ae565c1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
9954c249d4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
169991c639 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
3415a23dec 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8708f2a0b4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
04c9e4413d 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
0347e914bc 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 2f314a6a8d 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 300ba7281d 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 7334a0c9fa 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
 4fe70a35e1 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
 43d72e4cc9 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 f8ebc124c4 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java
 0c1e7866c0 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 27a1bd8f25 
  standalone-metastore/src/main/resources/package.jdo b271e026e9 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 9f92bf6be2 


Diff: https://reviews.apache.org/r/63346/diff/11/

Changes: https://reviews.apache.org/r/63346/diff/10-11/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-07 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review190361
---




standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 9471 (patched)


Atleast this should be documented in the config description. Launching 4 
AMs and not using them is also wasteful. On poorly configured cluster this can 
have adverse effects (default AMs taking up space of LLAP daemons). IMHO for 
better OOTB experience making it configurable is better option. We can ship 
with default 4 but if someone thinks 4 is wasteful then they have option of 
using default pool and less resources.


- Prasanth_J


On Nov. 7, 2017, 3:09 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Nov. 7, 2017, 3:09 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 305e9dc2ed 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
>  012361a186 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql f9b0765916 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 054978e3e4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql a13d976e37 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 1ceb7239eb 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 03ee4cfd64 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 06648540f0 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql a13d976e37 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql a94985a63e 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql e80e6124fc 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> be1bb1eee0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 826ae565c1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
> 9954c249d4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> 169991c639 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 3415a23dec 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8708f2a0b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> 04c9e4413d 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 0347e914bc 
>   ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2f314a6a8d 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 300ba7281d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  7334a0c9fa 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
>  f8ebc124c4 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java
>  0c1e7866c0 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  27a1bd8f25 
>   standalone-metastore/src/main/resources/package.jdo b271e026e9 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 9f92bf6be2 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/10/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-07 Thread Sergey Shelukhin 


> On Nov. 7, 2017, 5:13 p.m., Prasanth_J wrote:
> > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
> > Lines 9471 (patched)
> > 
> >
> > Why query parallelism is set to 4 here?

hmm... what should it be set to? I didn't want to make it configurable, because 
if you modify configs for this you might as well change the pool instead.
1 may create poor out of the box experience in an unobvious manner (one query 
at a time for unknown reason), at least with 4 if something is wrong (4 is too 
much) it's more obvious.


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review190340
---


On Nov. 7, 2017, 3:09 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Nov. 7, 2017, 3:09 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 305e9dc2ed 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
>  012361a186 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql f9b0765916 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 054978e3e4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql a13d976e37 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 1ceb7239eb 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 03ee4cfd64 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 06648540f0 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql a13d976e37 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql a94985a63e 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql e80e6124fc 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> be1bb1eee0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 826ae565c1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
> 9954c249d4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> 169991c639 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 3415a23dec 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8708f2a0b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> 04c9e4413d 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 0347e914bc 
>   ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2f314a6a8d 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 300ba7281d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  7334a0c9fa 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
>  f8ebc124c4 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java
>  0c1e7866c0 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  27a1bd8f25 
>   standalone-metastore/src/main/resources/package.jdo b271e026e9 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 9f92bf6be2 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/10/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-07 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review190340
---




metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql
Line 115 (original), 115 (patched)


I think Harish mentioned about POOL_ID to be BIGINT. RP_ID should also be 
BIGINT



ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java
Lines 49 (patched)


follow up jira?



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 9471 (patched)


Why query parallelism is set to 4 here?


- Prasanth_J


On Nov. 7, 2017, 3:09 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Nov. 7, 2017, 3:09 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 305e9dc2ed 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
>  012361a186 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql f9b0765916 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 054978e3e4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql a13d976e37 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 1ceb7239eb 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 03ee4cfd64 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 06648540f0 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql a13d976e37 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql a94985a63e 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql e80e6124fc 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> be1bb1eee0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 826ae565c1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
> 9954c249d4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> 169991c639 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 3415a23dec 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8708f2a0b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> 04c9e4413d 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 0347e914bc 
>   ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2f314a6a8d 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 300ba7281d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  7334a0c9fa 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
>  f8ebc124c4 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java
>  0c1e7866c0 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  27a1bd8f25 
>   standalone-metastore/src/main/resources/package.jdo b271e026e9 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 9f92bf6be2 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/10/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-07 Thread Harish Jaiprakash 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review190280
---




metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql
Line 115 (original), 115 (patched)


POOL_ID here should also become BIGINT.


- Harish Jaiprakash


On Nov. 7, 2017, 8:39 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Nov. 7, 2017, 8:39 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 305e9dc2ed 
>   
> itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
>  012361a186 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql f9b0765916 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 054978e3e4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql a13d976e37 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 1ceb7239eb 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 03ee4cfd64 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 06648540f0 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql a13d976e37 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql a94985a63e 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql e80e6124fc 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> be1bb1eee0 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 826ae565c1 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
> 9954c249d4 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> 169991c639 
>   
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
> PRE-CREATION 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> 3415a23dec 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8708f2a0b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> 04c9e4413d 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 0347e914bc 
>   ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2f314a6a8d 
>   service/src/java/org/apache/hive/service/server/HiveServer2.java 300ba7281d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  7334a0c9fa 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
>  f8ebc124c4 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java
>  0c1e7866c0 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  27a1bd8f25 
>   standalone-metastore/src/main/resources/package.jdo b271e026e9 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 9f92bf6be2 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/10/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-06 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Nov. 7, 2017, 3:09 a.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 305e9dc2ed 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
 012361a186 
  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql f9b0765916 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 054978e3e4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql a13d976e37 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 1ceb7239eb 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 03ee4cfd64 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 06648540f0 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql a13d976e37 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql a94985a63e 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql e80e6124fc 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql be1bb1eee0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 826ae565c1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
9954c249d4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
169991c639 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
3415a23dec 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 8708f2a0b4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
04c9e4413d 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
0347e914bc 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 2f314a6a8d 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 300ba7281d 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 7334a0c9fa 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 f8ebc124c4 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMPool.java
 0c1e7866c0 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 27a1bd8f25 
  standalone-metastore/src/main/resources/package.jdo b271e026e9 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 9f92bf6be2 


Diff: https://reviews.apache.org/r/63346/diff/10/

Changes: https://reviews.apache.org/r/63346/diff/9-10/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-03 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Nov. 3, 2017, 11:09 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cbe4de509b 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
 0ec7e85f5c 
  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 591be49af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
96dc7d3c98 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
b0c6d583f0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
6a2ff75c84 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 306559c722 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
94f42ddae0 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 5cdfc9de3e 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 2c4fe7fc2b 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 62801c5385 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
 f8ebc124c4 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 27a1bd8f25 
  standalone-metastore/src/main/resources/package.jdo 296e273ec8 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 60531457b7 


Diff: https://reviews.apache.org/r/63346/diff/9/

Changes: https://reviews.apache.org/r/63346/diff/8-9/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-03 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Nov. 3, 2017, 11:08 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cbe4de509b 
  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
 0ec7e85f5c 
  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  metastore/src/gen/thrift/gen-py/__init__.py e69de29bb2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 591be49af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
96dc7d3c98 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
b0c6d583f0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
6a2ff75c84 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 306559c722 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
94f42ddae0 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 5cdfc9de3e 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 2c4fe7fc2b 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h a46127bb09 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 
6090fc2888 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1e5bc0800f 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMAlterResourcePlanRequest.java
 fa694f0cec 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMAlterResourcePlanResponse.java
 73fc638672 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMAlterTriggerRequest.java
 d9938dc20e 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMAlterTriggerResponse.java
 d66aeaaa69 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMCreateResourcePlanRequest.java
 c5fb10b85f 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMCreateResourcePlanResponse.java
 c6769f85dc 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMCreateTriggerRequest.java
 be72429401 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMCreateTriggerResponse.java
 53e0082a67 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMDropResourcePlanRequest.java
 2f8d7d29ff 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMDropResourcePlanResponse.java
 9e58fa0638 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMDropTriggerRequest.java
 05f9c43f6b 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMDropTriggerResponse.java
 363018e5d2 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanRequest.java
 bdb6e0f982 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanResponse.java
 9fba8a1f28

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-11-02 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Nov. 2, 2017, 8:43 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersWorkloadManager.java
 0ec7e85f5c 
  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 591be49af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java a1b7cfb158 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
96dc7d3c98 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
b0c6d583f0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManagerFederation.java 
PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
6a2ff75c84 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 306559c722 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
94f42ddae0 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 5cdfc9de3e 
  service/src/java/org/apache/hive/service/server/HiveServer2.java 2c4fe7fc2b 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 62801c5385 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 27a1bd8f25 
  standalone-metastore/src/main/resources/package.jdo 296e273ec8 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 60531457b7 


Diff: https://reviews.apache.org/r/63346/diff/7/

Changes: https://reviews.apache.org/r/63346/diff/6-7/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-31 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Nov. 1, 2017, 1:15 a.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 591be49af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
81d6b859a6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
6a2ff75c84 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 306559c722 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 5cdfc9de3e 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 62801c5385 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 27a1bd8f25 
  standalone-metastore/src/main/resources/package.jdo 296e273ec8 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 60531457b7 


Diff: https://reviews.apache.org/r/63346/diff/6/

Changes: https://reviews.apache.org/r/63346/diff/5-6/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-30 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Oct. 30, 2017, 10:04 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Changes
---

please ignore iterations 3 & 4


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 591be49af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
81d6b859a6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
6a2ff75c84 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 306559c722 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 5cdfc9de3e 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 62801c5385 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 27a1bd8f25 
  standalone-metastore/src/main/resources/package.jdo 296e273ec8 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 60531457b7 


Diff: https://reviews.apache.org/r/63346/diff/5/

Changes: https://reviews.apache.org/r/63346/diff/4-5/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-30 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Oct. 30, 2017, 10:03 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  metastore/src/gen/thrift/gen-py/__init__.py e69de29bb2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 591be49af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
81d6b859a6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
6a2ff75c84 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 306559c722 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 5cdfc9de3e 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h a46127bb09 
  standalone-metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp 
6090fc2888 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1e5bc0800f 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMAlterResourcePlanRequest.java
 fa694f0cec 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMAlterResourcePlanResponse.java
 73fc638672 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMAlterTriggerRequest.java
 d9938dc20e 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMAlterTriggerResponse.java
 d66aeaaa69 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMCreateResourcePlanRequest.java
 c5fb10b85f 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMCreateResourcePlanResponse.java
 c6769f85dc 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMCreateTriggerRequest.java
 be72429401 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMCreateTriggerResponse.java
 53e0082a67 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMDropResourcePlanRequest.java
 2f8d7d29ff 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMDropResourcePlanResponse.java
 9e58fa0638 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMDropTriggerRequest.java
 05f9c43f6b 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMDropTriggerResponse.java
 363018e5d2 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanRequest.java
 bdb6e0f982 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetAllResourcePlanResponse.java
 9fba8a1f28 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetResourcePlanRequest.java
 c4948aba58 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetResourcePlanResponse.java
 4b88a2230f 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanRequest.java
 a9daf439ca 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMGetTriggersForResourePlanResponse.java
 c7f62ad0c4 
  
standalone-metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/WMMapping.java
 cbf4f3867b

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-30 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Oct. 30, 2017, 9:59 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql c1578fcda9 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 591be49af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
81d6b859a6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
6a2ff75c84 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 0263df0d04 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 306559c722 
  ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 69a1d63f93 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/queries/clientpositive/resourceplan.q f1be695cb8 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 5cdfc9de3e 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 62801c5385 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 27a1bd8f25 
  standalone-metastore/src/main/resources/package.jdo 296e273ec8 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 60531457b7 


Diff: https://reviews.apache.org/r/63346/diff/3/

Changes: https://reviews.apache.org/r/63346/diff/2-3/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-28 Thread Harish Jaiprakash 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189514
---


Ship it!




Ship It!

- Harish Jaiprakash


On Oct. 28, 2017, 2:55 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Oct. 28, 2017, 2:55 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> 5c770e2659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
> 81d6b859a6 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> dc29b122c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> f0658a665e 
>   ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  3deef0ee96 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  3ff924fe00 
>   standalone-metastore/src/main/resources/package.jdo 296e273ec8 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-27 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189486
---


Ship it!




Ship It!

- Prasanth_J


On Oct. 27, 2017, 9:25 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Oct. 27, 2017, 9:25 p.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> 5c770e2659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
> 81d6b859a6 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> dc29b122c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> f0658a665e 
>   ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  3deef0ee96 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  3ff924fe00 
>   standalone-metastore/src/main/resources/package.jdo 296e273ec8 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-27 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

(Updated Oct. 27, 2017, 9:25 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/UserPoolMapping.java 
81d6b859a6 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
dc29b122c9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 3deef0ee96 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 3ff924fe00 
  standalone-metastore/src/main/resources/package.jdo 296e273ec8 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 


Diff: https://reviews.apache.org/r/63346/diff/2/

Changes: https://reviews.apache.org/r/63346/diff/1-2/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-27 Thread Sergey Shelukhin 


> On Oct. 27, 2017, 1:10 a.m., Prasanth_J wrote:
> > metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql
> > Lines 7 (patched)
> > 
> >
> > is this NON NULL by default?

I think it's null by default, based on other tables/cols in mssql schema


> On Oct. 27, 2017, 1:10 a.m., Prasanth_J wrote:
> > metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql
> > Line 66 (original), 67 (patched)
> > 
> >
> > if this is NULL, will it use DEFAULT_POOL_ID?

No, it means unmanaged pool. Default pool is if the mapping doesn't exist; we 
want the default if nothing is set up to be WM/LLAP


- Sergey


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189384
---


On Oct. 27, 2017, 12:48 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Oct. 27, 2017, 12:48 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> 5c770e2659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> dc29b122c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> f0658a665e 
>   ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  3deef0ee96 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  3ff924fe00 
>   standalone-metastore/src/main/resources/package.jdo 296e273ec8 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-26 Thread Harish Jaiprakash 


> On Oct. 27, 2017, 11:27 a.m., Harish Jaiprakash wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
> > Lines 878 (patched)
> > 
> >
> > Desc is overwritten in the loop, so only the last alter statement will 
> > take into effect.

Sorry about this. I went through the code, it works fine.


- Harish


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189399
---


On Oct. 27, 2017, 6:18 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Oct. 27, 2017, 6:18 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> 5c770e2659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> dc29b122c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> f0658a665e 
>   ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  3deef0ee96 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  3ff924fe00 
>   standalone-metastore/src/main/resources/package.jdo 296e273ec8 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-26 Thread Harish Jaiprakash 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189399
---




ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
Lines 878 (patched)


Desc is overwritten in the loop, so only the last alter statement will take 
into effect.



ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java
Lines 63 (patched)


Should this be called defaultPoolPath, we should only use pool path 
everywhere right?



standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
Lines 9608 (patched)


We should filter this by rp_id too.



standalone-metastore/src/main/thrift/hive_metastore.thrift
Line 1050 (original), 1051 (patched)


I made a mistake here, it should be called poolPath, not pool name. We do 
not need parentPoolName and poolName when we have poolPath.


- Harish Jaiprakash


On Oct. 27, 2017, 6:18 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Oct. 27, 2017, 6:18 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> 5c770e2659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> dc29b122c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> f0658a665e 
>   ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  3deef0ee96 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  3ff924fe00 
>   standalone-metastore/src/main/resources/package.jdo 296e273ec8 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-26 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/#review189384
---




metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql
Lines 954 (patched)


Is this DEFAULT_POOL_NAME or default RP name (IIUC there is only one active 
RP and hence no need for default)? If later why do we need a default RP name?



metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql
Lines 7 (patched)


is this NON NULL by default?



metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql
Line 66 (original), 67 (patched)


if this is NULL, will it use DEFAULT_POOL_ID?


- Prasanth_J


On Oct. 27, 2017, 12:48 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63346/
> ---
> 
> (Updated Oct. 27, 2017, 12:48 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
>   metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
>   metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
>   metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
>   metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
>   metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
>   metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
>   metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
>   metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
>   metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
>   metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 
> 5c770e2659 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
>  f1258bab17 
>   
> ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
>  9df1b82d62 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> dc29b122c9 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> f0658a665e 
>   ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  3deef0ee96 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
>  3ff924fe00 
>   standalone-metastore/src/main/resources/package.jdo 296e273ec8 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 
> 
> 
> Diff: https://reviews.apache.org/r/63346/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

2017-10-26 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63346/
---

Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs
-

  metastore/scripts/upgrade/derby/046-HIVE-17566.derby.sql 16190dc0a1 
  metastore/scripts/upgrade/derby/hive-schema-3.0.0.derby.sql 4c35380af4 
  metastore/scripts/upgrade/hive/hive-schema-3.0.0.hive.sql ca7af06e7a 
  metastore/scripts/upgrade/mssql/031-HIVE-17566.mssql.sql 0ee0f758f1 
  metastore/scripts/upgrade/mssql/hive-schema-3.0.0.mssql.sql 86f3e5c4a9 
  metastore/scripts/upgrade/mysql/046-HIVE-17566.mysql.sql 1affa7a119 
  metastore/scripts/upgrade/mysql/hive-schema-3.0.0.mysql.sql 2453bb92c6 
  metastore/scripts/upgrade/oracle/046-HIVE-17566.oracle.sql 0ee0f758f1 
  metastore/scripts/upgrade/oracle/hive-schema-3.0.0.oracle.sql 47bfc5ae08 
  metastore/scripts/upgrade/postgres/045-HIVE-17566.postgres.sql aa27a6486b 
  metastore/scripts/upgrade/postgres/hive-schema-3.0.0.postgres.sql 5c770e2659 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 87f6e1d64e 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/JsonMetaDataFormatter.java
 f1258bab17 
  
ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/TextMetaDataFormatter.java
 9df1b82d62 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
dc29b122c9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 99ed71a5fa 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 053393ce51 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
f0658a665e 
  ql/src/test/queries/clientpositive/resourceplan.q 586491dc91 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 2231bb566d 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 3deef0ee96 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMResourcePlan.java
 3ff924fe00 
  standalone-metastore/src/main/resources/package.jdo 296e273ec8 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 1d455463a6 


Diff: https://reviews.apache.org/r/63346/diff/1/


Testing
---


Thanks,

Sergey Shelukhin