Re: Review Request 63486: HIVE-17953 Metrics should move to destination atomically

2017-11-02 Thread Barna Zsombor Klara

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63486/#review189889
---


Ship it!




Ship It!

- Barna Zsombor Klara


On nov. 1, 2017, 11:25 du, Alexander Kolbasov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63486/
> ---
> 
> (Updated nov. 1, 2017, 11:25 du)
> 
> 
> Review request for hive, Sahil Takiar and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-17953
> https://issues.apache.org/jira/browse/HIVE-17953
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-17953 Metrics should move to destination atomically
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  b9be8bd18285df42a82385f7ce73d9e1924fee4c 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java
>  04a5f02a91b76ed3775f7c1c8e0122a135564c70 
> 
> 
> Diff: https://reviews.apache.org/r/63486/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>



Review Request 63486: HIVE-17953 Metrics should move to destination atomically

2017-11-01 Thread Alexander Kolbasov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63486/
---

Review request for hive, Sahil Takiar and Vihang Karajgaonkar.


Bugs: HIVE-17953
https://issues.apache.org/jira/browse/HIVE-17953


Repository: hive-git


Description
---

HIVE-17953 Metrics should move to destination atomically


Diffs
-

  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
 b9be8bd18285df42a82385f7ce73d9e1924fee4c 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/metrics/JsonReporter.java
 04a5f02a91b76ed3775f7c1c8e0122a135564c70 


Diff: https://reviews.apache.org/r/63486/diff/1/


Testing
---


Thanks,

Alexander Kolbasov