Re: Review Request 64356: HIVE-18078 WM getSession needs some retry logic

2017-12-15 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64356/
---

(Updated Dec. 15, 2017, 7:07 p.m.)


Review request for hive and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
f0481fcf25 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
98f5c58ab8 


Diff: https://reviews.apache.org/r/64356/diff/2/

Changes: https://reviews.apache.org/r/64356/diff/1-2/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 64356: HIVE-18078 WM getSession needs some retry logic

2017-12-05 Thread j . prasanth . j 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64356/#review192968
---




ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java
Lines 1816 (patched)


nit: use try..catch..finally instead of isOk?


- Prasanth_J


On Dec. 5, 2017, 11:38 p.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64356/
> ---
> 
> (Updated Dec. 5, 2017, 11:38 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> ecdcf1251002e47bf4d31ec3a4b80c4404865be4 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 78df962a3af8c57d7bbefea1a301c9ddbe281ac9 
> 
> 
> Diff: https://reviews.apache.org/r/64356/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Review Request 64356: HIVE-18078 WM getSession needs some retry logic

2017-12-05 Thread Sergey Shelukhin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64356/
---

Review request for hive and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
ecdcf1251002e47bf4d31ec3a4b80c4404865be4 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
78df962a3af8c57d7bbefea1a301c9ddbe281ac9 


Diff: https://reviews.apache.org/r/64356/diff/1/


Testing
---


Thanks,

Sergey Shelukhin