Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

[Harish Jaiprakash]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64595/#review194053
---


Ship it!




Ship It!

- Harish Jaiprakash


On Dec. 16, 2017, 4:51 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64595/
> ---
> 
> (Updated Dec. 16, 2017, 4:51 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> f0481fcf25 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> a09b7961c2 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> 98f5c58ab8 
>   ql/src/test/queries/clientpositive/resourceplan.q fc924a2f95 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 7f3e784457 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  2c92bb2056 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
>  cde34bcf42 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a 
> 
> 
> Diff: https://reviews.apache.org/r/64595/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

[Sergey Shelukhin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64595/
---

(Updated Dec. 15, 2017, 11:21 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Changes
---

please ignore iteration 2


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
f0481fcf25 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
a09b7961c2 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
98f5c58ab8 
  ql/src/test/queries/clientpositive/resourceplan.q fc924a2f95 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 7f3e784457 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 2c92bb2056 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
 cde34bcf42 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a 


Diff: https://reviews.apache.org/r/64595/diff/3/

Changes: https://reviews.apache.org/r/64595/diff/2-3/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

[Sergey Shelukhin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64595/
---

(Updated Dec. 15, 2017, 11:20 p.m.)


Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties 2bf64dcfbd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
f0481fcf25 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupKeyHelper.java 
02b0e5c0f6 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
a09b7961c2 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
98f5c58ab8 
  ql/src/test/queries/clientpositive/resourceplan.q fc924a2f95 
  ql/src/test/queries/clientpositive/vector_reduce_groupby_duplicate_cols.q 
c82c960ce6 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 7f3e784457 
  
ql/src/test/results/clientpositive/llap/vector_reduce_groupby_duplicate_cols.q.out
 afca3df14c 
  ql/src/test/results/clientpositive/vector_reduce_groupby_duplicate_cols.q.out 
eaa4031291 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 2c92bb2056 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java
 cde34bcf42 
  standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a 
  
testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java
 e80656385e 


Diff: https://reviews.apache.org/r/64595/diff/2/

Changes: https://reviews.apache.org/r/64595/diff/1-2/


Testing
---


Thanks,

Sergey Shelukhin

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

[Harish Jaiprakash]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64595/#review193773
---




ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
Lines 1112 (patched)


We can use the API to add an invalid policy. Should we have this validation 
in the ObjectStore? Maybe the enum could be moved into the data classes like 
the resource plan status.


- Harish Jaiprakash


On Dec. 14, 2017, 9:09 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64595/
> ---
> 
> (Updated Dec. 14, 2017, 9:09 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
> dbdbbf25db 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> a09b7961c2 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
> c58e4507f2 
>   ql/src/test/queries/clientpositive/resourceplan.q fc924a2f95 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 7f3e784457 
> 
> 
> Diff: https://reviews.apache.org/r/64595/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

[Sergey Shelukhin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64595/
---

Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java 
dbdbbf25db 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
a09b7961c2 
  ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 
c58e4507f2 
  ql/src/test/queries/clientpositive/resourceplan.q fc924a2f95 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 7f3e784457 


Diff: https://reviews.apache.org/r/64595/diff/1/


Testing
---


Thanks,

Sergey Shelukhin