Re: Review Request 65206: HIVE-18438 WM RP: it's impossible to unset things

2018-01-18 Thread Harish Jaiprakash

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65206/#review195699
---


Ship it!




Ship It!

- Harish Jaiprakash


On Jan. 18, 2018, 9:58 a.m., Sergey Shelukhin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65206/
> ---
> 
> (Updated Jan. 18, 2018, 9:58 a.m.)
> 
> 
> Review request for hive, Harish Jaiprakash and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> see jira
> 
> 
> Diffs
> -
> 
>   
> itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
>  bc9ef62cb8 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 81e1dd96da 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1a2b3c1f6c 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
> db86320420 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ResourcePlanParser.g b47f7b39ed 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
> 73395207eb 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateOrAlterWMPoolDesc.java 
> 73806c507f 
>   ql/src/test/queries/clientpositive/resourceplan.q b46c1ee2d6 
>   ql/src/test/results/clientpositive/llap/resourceplan.q.out 72a78b1b4a 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
>  53a866929c 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
>  3261405ec5 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
>  b9fecc7044 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
>  e5092baccd 
>   
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
>  e28e44a0a5 
>   standalone-metastore/src/main/thrift/hive_metastore.thrift ff7636f9f9 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
>  877899cf48 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
>  6aa5d95a8a 
> 
> 
> Diff: https://reviews.apache.org/r/65206/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>



Review Request 65206: HIVE-18438 WM RP: it's impossible to unset things

2018-01-17 Thread Sergey Shelukhin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65206/
---

Review request for hive, Harish Jaiprakash and Prasanth_J.


Repository: hive-git


Description
---

see jira


Diffs
-

  
itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/DummyRawStoreFailEvent.java
 bc9ef62cb8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 81e1dd96da 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1a2b3c1f6c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
db86320420 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ResourcePlanParser.g b47f7b39ed 
  ql/src/java/org/apache/hadoop/hive/ql/plan/AlterResourcePlanDesc.java 
73395207eb 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateOrAlterWMPoolDesc.java 
73806c507f 
  ql/src/test/queries/clientpositive/resourceplan.q b46c1ee2d6 
  ql/src/test/results/clientpositive/llap/resourceplan.q.out 72a78b1b4a 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 53a866929c 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java
 3261405ec5 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java
 b9fecc7044 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/RawStore.java
 e5092baccd 
  
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java
 e28e44a0a5 
  standalone-metastore/src/main/thrift/hive_metastore.thrift ff7636f9f9 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java
 877899cf48 
  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java
 6aa5d95a8a 


Diff: https://reviews.apache.org/r/65206/diff/1/


Testing
---


Thanks,

Sergey Shelukhin