Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65240/
---

(Updated Jan. 24, 2018, 4:06 p.m.)


Review request for hive, Peter Vary and Adam Szita.


Changes
---

Fixed some checkstyle issues.


Bugs: HIVE-18498
https://issues.apache.org/jira/browse/HIVE-18498


Repository: hive-git


Description
---

The following methods of IMetaStoreClient are covered by this test.
- Index getIndex(String, String, String)
- List listIndexes(String, String, short)
- List listIndexNames(String, String, short)

The test covers not just the happy pathes, but the edge cases as well.


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65240/diff/3/

Changes: https://reviews.apache.org/r/65240/diff/2-3/


Testing
---

Run the tests


Thanks,

Marta Kuczora

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

[Marta Kuczora via Review Board]

> On Jan. 22, 2018, 1:48 p.m., Peter Vary wrote:
> > Nice job, looks good to me, one minor question

Thanks a lot Peter for the review.


> On Jan. 22, 2018, 1:48 p.m., Peter Vary wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
> > Lines 172 (patched)
> > 
> >
> > Is it possible to have a set of indexes in most of the cases, and use 
> > that?

Sure, I created a set of indexes in the setup and used these in the tests.


- Marta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65240/#review195898
---


On Jan. 24, 2018, 1:46 p.m., Marta Kuczora wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65240/
> ---
> 
> (Updated Jan. 24, 2018, 1:46 p.m.)
> 
> 
> Review request for hive, Peter Vary and Adam Szita.
> 
> 
> Bugs: HIVE-18498
> https://issues.apache.org/jira/browse/HIVE-18498
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following methods of IMetaStoreClient are covered by this test.
> - Index getIndex(String, String, String)
> - List listIndexes(String, String, short)
> - List listIndexNames(String, String, short)
> 
> The test covers not just the happy pathes, but the edge cases as well.
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65240/diff/2/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

[Marta Kuczora via Review Board]

> On Jan. 22, 2018, 12:35 p.m., Adam Szita wrote:
> > This change looks good! I only spotted some small code-duplications that we 
> > may want to clean up.

Thanks a lot Adam for the review.


> On Jan. 22, 2018, 12:35 p.m., Adam Szita wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
> > Lines 312-329 (patched)
> > 
> >
> > We may want to separate the common code parts into helper/checker 
> > methods here and then call with that with different num values.

Thanks for the hint, I fixed it.


- Marta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65240/#review195891
---


On Jan. 24, 2018, 1:46 p.m., Marta Kuczora wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65240/
> ---
> 
> (Updated Jan. 24, 2018, 1:46 p.m.)
> 
> 
> Review request for hive, Peter Vary and Adam Szita.
> 
> 
> Bugs: HIVE-18498
> https://issues.apache.org/jira/browse/HIVE-18498
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following methods of IMetaStoreClient are covered by this test.
> - Index getIndex(String, String, String)
> - List listIndexes(String, String, short)
> - List listIndexNames(String, String, short)
> 
> The test covers not just the happy pathes, but the edge cases as well.
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65240/diff/2/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65240/
---

(Updated Jan. 24, 2018, 1:46 p.m.)


Review request for hive, Peter Vary and Adam Szita.


Changes
---

Addressed the review findings. 
- Eliminated code duplication
- Create a list of indexes in the setup and used them in the tests. Also some 
refactoring was needed due to this change.


Bugs: HIVE-18498
https://issues.apache.org/jira/browse/HIVE-18498


Repository: hive-git


Description
---

The following methods of IMetaStoreClient are covered by this test.
- Index getIndex(String, String, String)
- List listIndexes(String, String, short)
- List listIndexNames(String, String, short)

The test covers not just the happy pathes, but the edge cases as well.


Diffs (updated)
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65240/diff/2/

Changes: https://reviews.apache.org/r/65240/diff/1-2/


Testing
---

Run the tests


Thanks,

Marta Kuczora

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

[Peter Vary via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65240/#review195898
---



Nice job, looks good to me, one minor question


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
Lines 172 (patched)


Is it possible to have a set of indexes in most of the cases, and use that?


- Peter Vary


On Jan. 19, 2018, 3:05 p.m., Marta Kuczora wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65240/
> ---
> 
> (Updated Jan. 19, 2018, 3:05 p.m.)
> 
> 
> Review request for hive, Peter Vary and Adam Szita.
> 
> 
> Bugs: HIVE-18498
> https://issues.apache.org/jira/browse/HIVE-18498
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following methods of IMetaStoreClient are covered by this test.
> - Index getIndex(String, String, String)
> - List listIndexes(String, String, short)
> - List listIndexNames(String, String, short)
> 
> The test covers not just the happy pathes, but the edge cases as well.
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65240/diff/1/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

[Adam Szita via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65240/#review195891
---



This change looks good! I only spotted some small code-duplications that we may 
want to clean up.


standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
Lines 312-329 (patched)


We may want to separate the common code parts into helper/checker methods 
here and then call with that with different num values.



standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
Lines 463-481 (patched)


Same remark here relating code duplication


- Adam Szita


On Jan. 19, 2018, 3:05 p.m., Marta Kuczora wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65240/
> ---
> 
> (Updated Jan. 19, 2018, 3:05 p.m.)
> 
> 
> Review request for hive, Peter Vary and Adam Szita.
> 
> 
> Bugs: HIVE-18498
> https://issues.apache.org/jira/browse/HIVE-18498
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> The following methods of IMetaStoreClient are covered by this test.
> - Index getIndex(String, String, String)
> - List listIndexes(String, String, short)
> - List listIndexNames(String, String, short)
> 
> The test covers not just the happy pathes, but the edge cases as well.
> 
> 
> Diffs
> -
> 
>   
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/65240/diff/1/
> 
> 
> Testing
> ---
> 
> Run the tests
> 
> 
> Thanks,
> 
> Marta Kuczora
> 
>

Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

[Marta Kuczora via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65240/
---

Review request for hive, Peter Vary and Adam Szita.


Bugs: HIVE-18498
https://issues.apache.org/jira/browse/HIVE-18498


Repository: hive-git


Description
---

The following methods of IMetaStoreClient are covered by this test.
- Index getIndex(String, String, String)
- List listIndexes(String, String, short)
- List listIndexNames(String, String, short)

The test covers not just the happy pathes, but the edge cases as well.


Diffs
-

  
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/65240/diff/1/


Testing
---

Run the tests


Thanks,

Marta Kuczora