Re: Review Request 69256: HIVE-20822

2018-12-14 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69256/
---

(Updated Dec. 14, 2018, 10:33 p.m.)


Review request for hive, Daniel Dai and Thejas Nair.


Bugs: HIVE-20822
https://issues.apache.org/jira/browse/HIVE-20822


Repository: hive-git


Description (updated)
---

HIVE-20822
HIVE-21046


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties 
01cad2a79326fb726a57263442dc9591b5bd01b6 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveBetween.java
 ffc705f381d35f689276f9de1663e0a8197c98df 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/jdbc/HiveJdbcConverter.java
 382060243e6d253e7ca88d50b067f75ddf340ede 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/jdbc/JdbcHiveTableScan.java
 5b9a63527066eba1a71d9296fd483b108434bae3 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
 531e769b10dcda0169ff8b79d7eac53dc940dc71 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCAggregationPushDownRule.java
 8f96288aa72fd236bb1bcdd8f774a25848e7fd8b 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCExpandExpressionsRule.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCProjectPushDownRule.java
 5c03f87361e67ef18165c3c55903648c9408b214 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCSortPushDownRule.java
 33dc280d4d751d786ae91125fd440e01fa53deab 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/package-info.java
 08a17aa188d99c629fd30ed49b7fef930d7cc8a0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
aef1d4ab2a7d5a640a552270bd307ac31e58739c 
  ql/src/test/queries/clientpositive/external_jdbc_table2.q 
28a21802fe5aaafb795acbfb75c191869d704300 
  ql/src/test/queries/clientpositive/external_jdbc_table_perf.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/external_jdbc_table2.q.out 
a1635772e1658fc39aa73669e8cb2819a82e7fe8 
  ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/69256/diff/4/

Changes: https://reviews.apache.org/r/69256/diff/3-4/


Testing
---


Thanks,

Jesús Camacho Rodríguez



Re: Review Request 69256: HIVE-20822

2018-11-28 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69256/
---

(Updated Nov. 28, 2018, 11:48 p.m.)


Review request for hive, Daniel Dai and Thejas Nair.


Bugs: HIVE-20822
https://issues.apache.org/jira/browse/HIVE-20822


Repository: hive-git


Description (updated)
---

HIVE-20822


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties 
5aadf2c8ddd5edbf007aa9ea075454970883f888 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveBetween.java
 ffc705f381d35f689276f9de1663e0a8197c98df 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/jdbc/HiveJdbcConverter.java
 382060243e6d253e7ca88d50b067f75ddf340ede 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/jdbc/JdbcHiveTableScan.java
 5b9a63527066eba1a71d9296fd483b108434bae3 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
 531e769b10dcda0169ff8b79d7eac53dc940dc71 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCProjectPushDownRule.java
 5c03f87361e67ef18165c3c55903648c9408b214 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForASTConv.java
 d00c5103dcc73e3a1874b2edbca732b143a714db 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
aef1d4ab2a7d5a640a552270bd307ac31e58739c 
  ql/src/test/queries/clientpositive/external_jdbc_table_perf.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/external_jdbc_table.q.out 
8db779c4272decb31afb8007f654d099d9e7fd7e 
  ql/src/test/results/clientpositive/llap/external_jdbc_table2.q.out 
13c049fc75825fdf14112723542571eec9692331 
  ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/69256/diff/3/

Changes: https://reviews.apache.org/r/69256/diff/2-3/


Testing
---


Thanks,

Jesús Camacho Rodríguez



Re: Review Request 69256: HIVE-20822

2018-11-14 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69256/
---

(Updated Nov. 14, 2018, 6:39 p.m.)


Review request for hive and Daniel Dai.


Bugs: HIVE-20822
https://issues.apache.org/jira/browse/HIVE-20822


Repository: hive-git


Description (updated)
---

HIVE-20822 (2)


Diffs (updated)
-

  itests/src/test/resources/testconfiguration.properties 
fb50588fe7ce06df6bf41775dbef42143d3d8bb9 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveBetween.java
 ffc705f381d35f689276f9de1663e0a8197c98df 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/jdbc/HiveJdbcConverter.java
 382060243e6d253e7ca88d50b067f75ddf340ede 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/jdbc/JdbcHiveTableScan.java
 5b9a63527066eba1a71d9296fd483b108434bae3 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
 531e769b10dcda0169ff8b79d7eac53dc940dc71 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCProjectPushDownRule.java
 5c03f87361e67ef18165c3c55903648c9408b214 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/PlanModifierForASTConv.java
 d00c5103dcc73e3a1874b2edbca732b143a714db 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
6e9c68b86e5de6f0162c0b52d4659fe17020 
  ql/src/test/queries/clientpositive/external_jdbc_table_perf.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/external_jdbc_table.q.out 
8db779c4272decb31afb8007f654d099d9e7fd7e 
  ql/src/test/results/clientpositive/llap/external_jdbc_table2.q.out 
9bfee47b89ed165b23571e459eaeece1dad7d012 
  ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/69256/diff/2/

Changes: https://reviews.apache.org/r/69256/diff/1-2/


Testing
---


Thanks,

Jesús Camacho Rodríguez



Review Request 69256: HIVE-20822

2018-11-05 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69256/
---

Review request for hive and Daniel Dai.


Bugs: HIVE-20822
https://issues.apache.org/jira/browse/HIVE-20822


Repository: hive-git


Description
---

HIVE-20822


Diffs
-

  itests/src/test/resources/testconfiguration.properties 
da2091ac5d2b6b70e232bce3d489188ac40f43d5 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveBetween.java
 ffc705f381d35f689276f9de1663e0a8197c98df 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/jdbc/HiveJdbcConverter.java
 382060243e6d253e7ca88d50b067f75ddf340ede 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
 531e769b10dcda0169ff8b79d7eac53dc940dc71 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/JDBCProjectPushDownRule.java
 5c03f87361e67ef18165c3c55903648c9408b214 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
ab63ce2bc34cc5fc2f44d65c9371b2a59593c9a2 
  ql/src/test/queries/clientpositive/external_jdbc_table_perf.q PRE-CREATION 
  ql/src/test/results/clientpositive/llap/external_jdbc_table.q.out 
1bb41dd42746864612c68219489a3a056922cbe8 
  ql/src/test/results/clientpositive/llap/external_jdbc_table2.q.out 
9bfee47b89ed165b23571e459eaeece1dad7d012 
  ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out 
PRE-CREATION 


Diff: https://reviews.apache.org/r/69256/diff/1/


Testing
---


Thanks,

Jesús Camacho Rodríguez