Re: Review Request 69294: HIVE-20826 Enhance HiveSemiJoin rule to convert join + group by on left side to Left Semi Join

2018-11-09 Thread Vineet Garg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69294/
---

(Updated Nov. 9, 2018, 10:45 p.m.)


Review request for hive, Ashutosh Chauhan and Zoltan Haindrich.


Changes
---

Fixed failing tests + checkstyle fixes


Bugs: HIVE-20826
https://issues.apache.org/jira/browse/HIVE-20826


Repository: hive-git


Description
---

See jira


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSemiJoinRule.java
 7799090d43 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 11c8f5f02c 
  ql/src/test/queries/clientpositive/semijoin.q 144069bbe6 
  ql/src/test/results/clientpositive/llap/explainuser_1.q.out a87890f89e 
  ql/src/test/results/clientpositive/llap/optimize_join_ptp.q.out af55d4d5f3 
  ql/src/test/results/clientpositive/llap/semijoin.q.out 531ef46c78 
  ql/src/test/results/clientpositive/llap/subquery_in.q.out 3222e2f616 
  ql/src/test/results/clientpositive/llap/subquery_views.q.out 4c723dce6b 
  ql/src/test/results/clientpositive/llap/vector_mapjoin_reduce.q.out 
ad57fcd666 
  ql/src/test/results/clientpositive/perf/tez/cbo_query14.q.out 9bb4f2e7f2 
  ql/src/test/results/clientpositive/perf/tez/query14.q.out c078c271ec 
  ql/src/test/results/clientpositive/spark/semijoin.q.out a787bce4b4 
  ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out 0bdc44be8f 
  ql/src/test/results/clientpositive/spark/subquery_in.q.out 7063a794cb 
  ql/src/test/results/clientpositive/spark/subquery_views.q.out 15400893b2 
  ql/src/test/results/clientpositive/spark/vector_mapjoin_reduce.q.out 
6634a047f6 


Diff: https://reviews.apache.org/r/69294/diff/2/

Changes: https://reviews.apache.org/r/69294/diff/1-2/


Testing
---


Thanks,

Vineet Garg



Review Request 69294: HIVE-20826 Enhance HiveSemiJoin rule to convert join + group by on left side to Left Semi Join

2018-11-08 Thread Vineet Garg

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69294/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-20826
https://issues.apache.org/jira/browse/HIVE-20826


Repository: hive-git


Description
---

See jira


Diffs
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveSemiJoinRule.java
 7799090d43 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 11c8f5f02c 
  ql/src/test/queries/clientpositive/semijoin.q 144069bbe6 
  ql/src/test/results/clientpositive/llap/semijoin.q.out 531ef46c78 
  ql/src/test/results/clientpositive/perf/tez/cbo_query14.q.out 9bb4f2e7f2 
  ql/src/test/results/clientpositive/perf/tez/query14.q.out c078c271ec 
  ql/src/test/results/clientpositive/spark/semijoin.q.out a787bce4b4 


Diff: https://reviews.apache.org/r/69294/diff/1/


Testing
---


Thanks,

Vineet Garg