Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69562/
---

(Updated Dec. 21, 2018, 8:30 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-16957
https://issues.apache.org/jira/browse/HIVE-16957


Repository: hive-git


Description
---

HIVE-16957


Diffs (updated)
-

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 
d26af3b08130ce26006cc57c53e68efca1d01166 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/LimitPushdownOptimizer.java 
859c18f3c2059a8e0d4e3fd7f62a521a72e691fd 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
3a51d9795b0384356daa0a8ab576374fb05c3378 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 
11ccff44588e20d6acc47af31bfa05e3beba7e2e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 
9aff0069fd0170cfec877caf481e8b6653435b81 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
5126a7915ddac7b2073356ac2f993470db2f0a94 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
f0f7b18d192f85b489ccde4e8a80e92dc11a0494 
  ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q 
00c19c74ad45fc13e0a2cf74af3f0fb33b73a1a3 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q 
9735e61598520469f176719bc51b4437204fd522 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_2.q 
3f695d1ee212902a0415ac2912a4f15d521cd380 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_3.q 
eb668a90acb546504cffb994ce25a1ab03c5b0c0 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q 
f21db8a8d87fe47eb22a3c43d0856dd5463a1671 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q 
3026d9093eddbf53611a79df5fbe1ee55884273a 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q 
8c9da8ae69967d1e11a333a46fddc51957cd5f31 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_multi_db.q 
85d926f9eb8c40d01bee6dab87baf5bf29790278 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q
 72e3d65117c0712929bb217e3a5e769101b27ebd 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window.q
 4cdb715d2873b726561979a5b6d93c086467cd3d 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window_2.q
 6873673a55580b3d94f2af4b7c7c0b20f191d879 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_1.q 
18b9f7d418eff200d551ce4f95a399741dfca3f8 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_10.q 
95427923164a28b1b0ef73f03fa69544daa5ff1c 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_2.q 
3a447fc1873bf98d748fb9fd09278d60b7c9ac55 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_3.q 
0823f59394dd00d9d02b0ae517454c035b21baed 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_4.q 
6724cec7710f981d094576f6befccd2491ebe936 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_5.q 
d87928c07363f6bd0ba4ae8f1986f5f53f513731 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_6.q 
23fc3c14ce5a0c43483824de9ac0835453f74c44 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_7.q 
3d1cedc4f56a1bceecba390292fcd26ad6ce1863 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_8.q 
cfcfddce506d80ad55ac4d61dc0c8069b354c5cd 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_9.q 
18d5cec8f98fdc7c44d3a358c765ab111019941d 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_empty.q 
9ae1d4e81b033a07cf38bb4900cb819d34bf3d3f 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_no_join_opt.q 
8de9c7087a80b0bd5a5a68a46f336390b02a33ff 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_no_join_opt_2.q 
a1372301feb27e0845a6dd8e260ba18bd91f03fd 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_part_1.q 
e6980c07f130a44ae4ade0a36e5591d75999eb6f 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_part_2.q 
b2e6ebd6956c945b454a8646e32688374522326c 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_ssb.q 
aed5bdbffdd225ee3d462b407d289205ff9775c8 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_ssb_2.q 
0982b66ad7841272f234608a88cbe8e255cb3bfd 
  ql/src/test/results/clientnegative/masking_mv.q.out 
54e984321209b4893f0178d49bdc66aebc38ff44 
  ql/src/test/results/clientpositive/alter_table_update_status.q.out 
ec8a64cd65c77592fae39c1b251d4d65837043a8 
  
ql/src/test/results/clientpositive/alter_table_update_status_disable_bitvector.q.out
 1b787af0a884ff4f27415b8fc5cc1593c29e7190 
  ql/src/test/results/clientpositive/autoColumnStats_4.q.out 
83ee0f76da409f525c00aa932e40cf8d5d5630be

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez 


> On Dec. 21, 2018, 5:12 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java
> > Lines 110 (patched)
> > 
> >
> > It will be good to add a comment here stating why we need to use table 
> > values here.

Done!


> On Dec. 21, 2018, 5:12 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
> > Lines 7719 (patched)
> > 
> >
> > Now that we support partitioned CTAS, need to pass in partSpec here and 
> > handle it.

Since CTAS does not allow static partition values, we pass null for partSpec 
(at that moment, partSpec map would only contain the static partition values). 
Then, _insertTableValuesAnalyzePipeline_ is responsible to introduce 
column_partition_name=null in the partSpec for each partition column, similar 
to the logic used for INSERT or INSERT OVERWRITE statements. Those column 
partition values will be bounded dynamically at CTAS execution time.


> On Dec. 21, 2018, 5:12 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java
> > Lines 415 (patched)
> > 
> >
> > will be good to add a comment for this.

Done!


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69562/#review211502
---


On Dec. 13, 2018, 4:50 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69562/
> ---
> 
> (Updated Dec. 13, 2018, 4:50 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-16957
> https://issues.apache.org/jira/browse/HIVE-16957
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16957
> 
> 
> Diffs
> -
> 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 
> d26af3b08130ce26006cc57c53e68efca1d01166 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/LimitPushdownOptimizer.java 
> 859c18f3c2059a8e0d4e3fd7f62a521a72e691fd 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 3a51d9795b0384356daa0a8ab576374fb05c3378 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 
> 11ccff44588e20d6acc47af31bfa05e3beba7e2e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 
> 9aff0069fd0170cfec877caf481e8b6653435b81 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> b330d710a185aa44c4a89088bb025ecb28ba8856 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
> f0f7b18d192f85b489ccde4e8a80e92dc11a0494 
>   ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q 
> 00c19c74ad45fc13e0a2cf74af3f0fb33b73a1a3 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q 
> 9735e61598520469f176719bc51b4437204fd522 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_2.q 
> 3f695d1ee212902a0415ac2912a4f15d521cd380 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_3.q 
> eb668a90acb546504cffb994ce25a1ab03c5b0c0 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q 
> f21db8a8d87fe47eb22a3c43d0856dd5463a1671 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q 
> 3026d9093eddbf53611a79df5fbe1ee55884273a 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q 
> 8c9da8ae69967d1e11a333a46fddc51957cd5f31 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_multi_db.q
>  85d926f9eb8c40d01bee6dab87baf5bf29790278 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q
>  72e3d65117c0712929bb217e3a5e769101b27ebd 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window.q
>  4cdb715d2873b726561979a5b6d93c086467cd3d 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window_2.q
>  6873673a55580b3d94f2af4b7c7c0b20f191d879 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_1.q 
> 18b9f7d418eff200d551ce4f95a399741dfca3f8 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_10.q 
> 95427923164a28b1b0ef73f03fa69544daa5ff1c 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_2.q 
> 3a447fc1873bf98d748fb9fd09278d60b7c9ac55 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_3.q 
> 0823f59394dd00d9d02b0ae517454c035b21baed 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_4.q 
>

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69562/#review211502
---




ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java
Lines 110 (patched)


It will be good to add a comment here stating why we need to use table 
values here.



ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Lines 7719 (patched)


Now that we support partitioned CTAS, need to pass in partSpec here and 
handle it.



ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java
Lines 415 (patched)


will be good to add a comment for this.


- Ashutosh Chauhan


On Dec. 13, 2018, 4:50 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69562/
> ---
> 
> (Updated Dec. 13, 2018, 4:50 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-16957
> https://issues.apache.org/jira/browse/HIVE-16957
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16957
> 
> 
> Diffs
> -
> 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 
> d26af3b08130ce26006cc57c53e68efca1d01166 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/LimitPushdownOptimizer.java 
> 859c18f3c2059a8e0d4e3fd7f62a521a72e691fd 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 3a51d9795b0384356daa0a8ab576374fb05c3378 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 
> 11ccff44588e20d6acc47af31bfa05e3beba7e2e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 
> 9aff0069fd0170cfec877caf481e8b6653435b81 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> b330d710a185aa44c4a89088bb025ecb28ba8856 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
> f0f7b18d192f85b489ccde4e8a80e92dc11a0494 
>   ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q 
> 00c19c74ad45fc13e0a2cf74af3f0fb33b73a1a3 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q 
> 9735e61598520469f176719bc51b4437204fd522 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_2.q 
> 3f695d1ee212902a0415ac2912a4f15d521cd380 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_3.q 
> eb668a90acb546504cffb994ce25a1ab03c5b0c0 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q 
> f21db8a8d87fe47eb22a3c43d0856dd5463a1671 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q 
> 3026d9093eddbf53611a79df5fbe1ee55884273a 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q 
> 8c9da8ae69967d1e11a333a46fddc51957cd5f31 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_multi_db.q
>  85d926f9eb8c40d01bee6dab87baf5bf29790278 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q
>  72e3d65117c0712929bb217e3a5e769101b27ebd 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window.q
>  4cdb715d2873b726561979a5b6d93c086467cd3d 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window_2.q
>  6873673a55580b3d94f2af4b7c7c0b20f191d879 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_1.q 
> 18b9f7d418eff200d551ce4f95a399741dfca3f8 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_10.q 
> 95427923164a28b1b0ef73f03fa69544daa5ff1c 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_2.q 
> 3a447fc1873bf98d748fb9fd09278d60b7c9ac55 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_3.q 
> 0823f59394dd00d9d02b0ae517454c035b21baed 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_4.q 
> 6724cec7710f981d094576f6befccd2491ebe936 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_5.q 
> d87928c07363f6bd0ba4ae8f1986f5f53f513731 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_6.q 
> 23fc3c14ce5a0c43483824de9ac0835453f74c44 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_7.q 
> 3d1cedc4f56a1bceecba390292fcd26ad6ce1863 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_8.q 
> cfcfddce506d80ad55ac4d61dc0c8069b354c5cd 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_9.q 
> 18d5cec8f98fdc7c44d3a358c765ab111019941d 
>   ql/src/test/queries/clientpositive/materialized_view_rewrite_empty.q 
> 9ae1d4e81b033a07cf38bb4900cb819d34bf3d3f 
>

Re: Review Request 69562: HIVE-16957

2018-12-21 Thread Jesús Camacho Rodríguez 


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q
> > Line 7 (original), 7 (patched)
> > 
> >
> > Is it necessary to specify schema to get auto-gather to work with CTAS?

This is a different issue: Observe that it is a return path test. CTAS is 
failing in this specific case with a column name mismatch but I did not spend 
time exploring it further. Instead, I rewrote it into a CREATE TABLE + INSERT 
to preserve the test.
I should probably create a follow-up, although I guess if we set return path to 
true we would discover many additional issues, not only this one.


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out
> > Lines 231-240 (original)
> > 
> >
> > Did we lose stats auto-gather for this merge statement?

The original query is:

explain
merge into acidTbl as t using nonAcidOrcTbl s ON t.a = s.a 
WHEN MATCHED AND s.a > 8 THEN DELETE
WHEN MATCHED THEN UPDATE SET b = 7
WHEN NOT MATCHED THEN INSERT VALUES(s.a, s.b);

Note that the branch that disappears is for `default.merge_tmp_table`, which is 
not part of the original query, and if you scroll down you can see that the 
autogather stats branch is still present for the INSERT to `acidTbl` that 
results from the MERGE.

The edge disappears because of the change in L7707 in SemanticAnalyzer that 
limits the scope of auto-gather column stats, excluding temporary tables. I 
think that makes sense?

The auto-gather basic stats is still preserved and part of the plan though. 
This should be fine since they are not written to metastore?


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
> > Lines 4640-4648 (original)
> > 
> >
> > No more auto-gather stats?

Merge statement, see explanation above.


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/insert_into_default_keyword.q.out
> > Lines 2952-2960 (original)
> > 
> >
> > Losing stats branch.

Merge statement, see explanation above.


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/runtime_stats_merge.q.out
> > Lines 169-176 (original)
> > 
> >
> > Losing stats branch.

Merge statement, see explanation above.


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out
> > Lines 3361-3368 (original)
> > 
> >
> > Losing stats branch.

Merge statement, see explanation above.


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/sqlmerge.q.out
> > Lines 213-219 (original)
> > 
> >
> > Losing stats branch.

Merge statement, see explanation above.


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/tez_nway_join.q.out
> > Line 63 (original), 63 (patched)
> > 
> >
> > Did we lose stats in this scenario?

`foo` is a temporary table, root cause is the same as described above. As part 
of the changes in this patch, I excluded auto-gather column stats on temporary 
tables for all operations, not only CTAS. That is why it is reflected in this 
case too, although the collection was done after INSERT operation.


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/llap/vector_udf2.q.out
> > Line 291 (original), 291 (patched)
> > 
> >
> > are we losing stats here?

`hive_14349` is a temporary table, same as above.


> On Dec. 20, 2018, 7:56 p.m., Ashutosh Chauhan wrote:
> > ql/src/test/results/clientpositive/parallel_orderby.q.out
> > Line 97 (original)
> > 
> >
> > Uhh.. we actually had a bug checked in the golden files :(

:( The issue is still there, this patch just hides it (probably because the 
task is not fully vectorized). I have created HIVE-21064 with the description 
and the test to repro the failure.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69562: HIVE-16957

2018-12-20 Thread Ashutosh Chauhan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69562/#review211472
---




ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q
Line 7 (original), 7 (patched)


Is it necessary to specify schema to get auto-gather to work with CTAS?



ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_3.q.out
Lines 231-240 (original)


Did we lose stats auto-gather for this merge statement?



ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out
Lines 4640-4648 (original)


No more auto-gather stats?



ql/src/test/results/clientpositive/llap/insert_into_default_keyword.q.out
Lines 2952-2960 (original)


Losing stats branch.



ql/src/test/results/clientpositive/llap/runtime_stats_merge.q.out
Lines 169-176 (original)


Losing stats branch.



ql/src/test/results/clientpositive/llap/semijoin_hint.q.out
Lines 3361-3368 (original)


Losing stats branch.



ql/src/test/results/clientpositive/llap/sqlmerge.q.out
Lines 213-219 (original)


Losing stats branch.



ql/src/test/results/clientpositive/llap/tez_nway_join.q.out
Line 63 (original), 63 (patched)


Did we lose stats in this scenario?



ql/src/test/results/clientpositive/llap/vector_udf2.q.out
Line 291 (original), 291 (patched)


are we losing stats here?



ql/src/test/results/clientpositive/parallel_orderby.q.out
Line 97 (original)


Uhh.. we actually had a bug checked in the golden files :(


- Ashutosh Chauhan


On Dec. 13, 2018, 4:50 p.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69562/
> ---
> 
> (Updated Dec. 13, 2018, 4:50 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-16957
> https://issues.apache.org/jira/browse/HIVE-16957
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16957
> 
> 
> Diffs
> -
> 
>   
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 
> d26af3b08130ce26006cc57c53e68efca1d01166 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/LimitPushdownOptimizer.java 
> 859c18f3c2059a8e0d4e3fd7f62a521a72e691fd 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
> 3a51d9795b0384356daa0a8ab576374fb05c3378 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 
> 11ccff44588e20d6acc47af31bfa05e3beba7e2e 
>   
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 
> 9aff0069fd0170cfec877caf481e8b6653435b81 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
> b330d710a185aa44c4a89088bb025ecb28ba8856 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
> f0f7b18d192f85b489ccde4e8a80e92dc11a0494 
>   ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q 
> 00c19c74ad45fc13e0a2cf74af3f0fb33b73a1a3 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q 
> 9735e61598520469f176719bc51b4437204fd522 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_2.q 
> 3f695d1ee212902a0415ac2912a4f15d521cd380 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_3.q 
> eb668a90acb546504cffb994ce25a1ab03c5b0c0 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q 
> f21db8a8d87fe47eb22a3c43d0856dd5463a1671 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q 
> 3026d9093eddbf53611a79df5fbe1ee55884273a 
>   ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q 
> 8c9da8ae69967d1e11a333a46fddc51957cd5f31 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_multi_db.q
>  85d926f9eb8c40d01bee6dab87baf5bf29790278 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q
>  72e3d65117c0712929bb217e3a5e769101b27ebd 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window.q
>  4cdb715d2873b726561979a5b6d93c086467cd3d 
>   
> ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window_2.q
>  6873673a55580b3d94f2af4b7c7c0b20f191d879 
>

Re: Review Request 69562: HIVE-16957

2018-12-13 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69562/
---

(Updated Dec. 13, 2018, 4:50 p.m.)


Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-16957
https://issues.apache.org/jira/browse/HIVE-16957


Repository: hive-git


Description
---

HIVE-16957


Diffs (updated)
-

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 
d26af3b08130ce26006cc57c53e68efca1d01166 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/LimitPushdownOptimizer.java 
859c18f3c2059a8e0d4e3fd7f62a521a72e691fd 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
3a51d9795b0384356daa0a8ab576374fb05c3378 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 
11ccff44588e20d6acc47af31bfa05e3beba7e2e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 
9aff0069fd0170cfec877caf481e8b6653435b81 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
b330d710a185aa44c4a89088bb025ecb28ba8856 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
f0f7b18d192f85b489ccde4e8a80e92dc11a0494 
  ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q 
00c19c74ad45fc13e0a2cf74af3f0fb33b73a1a3 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q 
9735e61598520469f176719bc51b4437204fd522 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_2.q 
3f695d1ee212902a0415ac2912a4f15d521cd380 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_3.q 
eb668a90acb546504cffb994ce25a1ab03c5b0c0 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q 
f21db8a8d87fe47eb22a3c43d0856dd5463a1671 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q 
3026d9093eddbf53611a79df5fbe1ee55884273a 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q 
8c9da8ae69967d1e11a333a46fddc51957cd5f31 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_multi_db.q 
85d926f9eb8c40d01bee6dab87baf5bf29790278 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q
 72e3d65117c0712929bb217e3a5e769101b27ebd 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window.q
 4cdb715d2873b726561979a5b6d93c086467cd3d 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window_2.q
 6873673a55580b3d94f2af4b7c7c0b20f191d879 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_1.q 
18b9f7d418eff200d551ce4f95a399741dfca3f8 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_10.q 
95427923164a28b1b0ef73f03fa69544daa5ff1c 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_2.q 
3a447fc1873bf98d748fb9fd09278d60b7c9ac55 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_3.q 
0823f59394dd00d9d02b0ae517454c035b21baed 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_4.q 
6724cec7710f981d094576f6befccd2491ebe936 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_5.q 
d87928c07363f6bd0ba4ae8f1986f5f53f513731 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_6.q 
23fc3c14ce5a0c43483824de9ac0835453f74c44 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_7.q 
3d1cedc4f56a1bceecba390292fcd26ad6ce1863 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_8.q 
cfcfddce506d80ad55ac4d61dc0c8069b354c5cd 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_9.q 
18d5cec8f98fdc7c44d3a358c765ab111019941d 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_empty.q 
9ae1d4e81b033a07cf38bb4900cb819d34bf3d3f 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_no_join_opt.q 
8de9c7087a80b0bd5a5a68a46f336390b02a33ff 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_no_join_opt_2.q 
a1372301feb27e0845a6dd8e260ba18bd91f03fd 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_part_1.q 
e6980c07f130a44ae4ade0a36e5591d75999eb6f 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_part_2.q 
b2e6ebd6956c945b454a8646e32688374522326c 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_ssb.q 
aed5bdbffdd225ee3d462b407d289205ff9775c8 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_ssb_2.q 
0982b66ad7841272f234608a88cbe8e255cb3bfd 
  ql/src/test/results/clientnegative/masking_mv.q.out 
54e984321209b4893f0178d49bdc66aebc38ff44 
  ql/src/test/results/clientpositive/alter_table_update_status.q.out 
ec8a64cd65c77592fae39c1b251d4d65837043a8 
  
ql/src/test/results/clientpositive/alter_table_update_status_disable_bitvector.q.out
 1b787af0a884ff4f27415b8fc5cc1593c29e7190 
  ql/src/test/results/clientpositive/autoColumnStats_4.q.out 
83ee0f76da409f525c00aa932e40cf8d5d5630be

Review Request 69562: HIVE-16957

2018-12-12 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69562/
---

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-16957
https://issues.apache.org/jira/browse/HIVE-16957


Repository: hive-git


Description
---

HIVE-16957


Diffs
-

  itests/hive-unit/src/test/java/org/apache/hadoop/hive/hooks/TestHs2Hooks.java 
d26af3b08130ce26006cc57c53e68efca1d01166 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/LimitPushdownOptimizer.java 
859c18f3c2059a8e0d4e3fd7f62a521a72e691fd 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
3a51d9795b0384356daa0a8ab576374fb05c3378 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java 
11ccff44588e20d6acc47af31bfa05e3beba7e2e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 
9aff0069fd0170cfec877caf481e8b6653435b81 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
b330d710a185aa44c4a89088bb025ecb28ba8856 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 
f0f7b18d192f85b489ccde4e8a80e92dc11a0494 
  ql/src/test/queries/clientpositive/cbo_rp_cross_product_check_2.q 
00c19c74ad45fc13e0a2cf74af3f0fb33b73a1a3 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q 
9735e61598520469f176719bc51b4437204fd522 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_2.q 
3f695d1ee212902a0415ac2912a4f15d521cd380 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_3.q 
eb668a90acb546504cffb994ce25a1ab03c5b0c0 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_4.q 
f21db8a8d87fe47eb22a3c43d0856dd5463a1671 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_5.q 
3026d9093eddbf53611a79df5fbe1ee55884273a 
  ql/src/test/queries/clientpositive/materialized_view_create_rewrite_dummy.q 
8c9da8ae69967d1e11a333a46fddc51957cd5f31 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_multi_db.q 
85d926f9eb8c40d01bee6dab87baf5bf29790278 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_rebuild_dummy.q
 72e3d65117c0712929bb217e3a5e769101b27ebd 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window.q
 4cdb715d2873b726561979a5b6d93c086467cd3d 
  
ql/src/test/queries/clientpositive/materialized_view_create_rewrite_time_window_2.q
 6873673a55580b3d94f2af4b7c7c0b20f191d879 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_1.q 
18b9f7d418eff200d551ce4f95a399741dfca3f8 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_10.q 
95427923164a28b1b0ef73f03fa69544daa5ff1c 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_2.q 
3a447fc1873bf98d748fb9fd09278d60b7c9ac55 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_3.q 
0823f59394dd00d9d02b0ae517454c035b21baed 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_4.q 
6724cec7710f981d094576f6befccd2491ebe936 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_5.q 
d87928c07363f6bd0ba4ae8f1986f5f53f513731 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_6.q 
23fc3c14ce5a0c43483824de9ac0835453f74c44 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_7.q 
3d1cedc4f56a1bceecba390292fcd26ad6ce1863 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_8.q 
cfcfddce506d80ad55ac4d61dc0c8069b354c5cd 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_9.q 
18d5cec8f98fdc7c44d3a358c765ab111019941d 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_empty.q 
9ae1d4e81b033a07cf38bb4900cb819d34bf3d3f 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_no_join_opt.q 
8de9c7087a80b0bd5a5a68a46f336390b02a33ff 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_no_join_opt_2.q 
a1372301feb27e0845a6dd8e260ba18bd91f03fd 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_part_1.q 
e6980c07f130a44ae4ade0a36e5591d75999eb6f 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_part_2.q 
b2e6ebd6956c945b454a8646e32688374522326c 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_ssb.q 
aed5bdbffdd225ee3d462b407d289205ff9775c8 
  ql/src/test/queries/clientpositive/materialized_view_rewrite_ssb_2.q 
0982b66ad7841272f234608a88cbe8e255cb3bfd 
  ql/src/test/results/clientnegative/masking_mv.q.out 
54e984321209b4893f0178d49bdc66aebc38ff44 
  ql/src/test/results/clientpositive/alter_table_update_status.q.out 
ec8a64cd65c77592fae39c1b251d4d65837043a8 
  
ql/src/test/results/clientpositive/alter_table_update_status_disable_bitvector.q.out
 1b787af0a884ff4f27415b8fc5cc1593c29e7190 
  
ql/src/test/results/clientpositive/beeline/materialized_view_create_rewrite.q.out
 1976545fe2c8ddc5382979532cace2d92571166c